Adds setting to explicitly control telemetry

Disables zone.js monkey patching by application insights
This commit is contained in:
Eric Amodio
2017-06-07 12:15:50 -04:00
parent 4eb1c3e36a
commit 9cf86a41ec
4 changed files with 12 additions and 1 deletions

View File

@@ -305,6 +305,7 @@ GitLens is highly customizable and provides many configuration settings to allow
|Name | Description |Name | Description
|-----|------------ |-----|------------
|`gitlens.advanced.toggleWhitespace.enabled`|Specifies whether or not to toggle whitespace off then showing blame annotations (*may* be required by certain fonts/themes) |`gitlens.advanced.toggleWhitespace.enabled`|Specifies whether or not to toggle whitespace off then showing blame annotations (*may* be required by certain fonts/themes)
|`gitlens.advanced.telemetry.enabled`|Specifies whether or not to enable GitLens telemetry (even if enabled still abides by the overall `telemetry.enableTelemetry` setting
|`gitlens.advanced.menus`|Specifies which commands will be added to which menus |`gitlens.advanced.menus`|Specifies which commands will be added to which menus
|`gitlens.advanced.caching.enabled`|Specifies whether git output will be cached |`gitlens.advanced.caching.enabled`|Specifies whether git output will be cached
|`gitlens.advanced.caching.maxLines`|Specifies the threshold for caching larger documents |`gitlens.advanced.caching.maxLines`|Specifies the threshold for caching larger documents

View File

@@ -691,6 +691,11 @@
"default": true, "default": true,
"description": "Specifies whether or not to close the QuickPick menu when focus is lost" "description": "Specifies whether or not to close the QuickPick menu when focus is lost"
}, },
"gitlens.advanced.telemetry.enabled": {
"type": "boolean",
"default": true,
"description": "Specifies whether or not to enable GitLens telemetry (even if enabled still abides by the overall `telemetry.enableTelemetry` setting"
},
"gitlens.advanced.toggleWhitespace.enabled": { "gitlens.advanced.toggleWhitespace.enabled": {
"type": "boolean", "type": "boolean",
"default": false, "default": false,

View File

@@ -98,6 +98,9 @@ export interface IAdvancedConfig {
quickPick: { quickPick: {
closeOnFocusOut: boolean; closeOnFocusOut: boolean;
}; };
telemetry: {
enabled: boolean;
};
toggleWhitespace: { toggleWhitespace: {
enabled: boolean; enabled: boolean;
}; };

View File

@@ -1,5 +1,6 @@
'use strict'; 'use strict';
import { Disposable, env, version, workspace } from 'vscode'; import { Disposable, env, version, workspace } from 'vscode';
import { ExtensionKey, IConfig } from './configuration';
import * as os from 'os'; import * as os from 'os';
let _reporter: TelemetryReporter; let _reporter: TelemetryReporter;
@@ -7,7 +8,8 @@ let _reporter: TelemetryReporter;
export class Telemetry extends Disposable { export class Telemetry extends Disposable {
static configure(key: string) { static configure(key: string) {
if (!workspace.getConfiguration('telemetry').get<boolean>('enableTelemetry', true)) return; const cfg = workspace.getConfiguration().get<IConfig>(ExtensionKey)!;
if (!cfg.advanced.telemetry.enabled || !workspace.getConfiguration('telemetry').get<boolean>('enableTelemetry', true)) return;
_reporter = new TelemetryReporter(key); _reporter = new TelemetryReporter(key);
} }