ckaczor/wpf-notifyicon
1
0
Fork 0
mirror of https://github.com/ckaczor/wpf-notifyicon.git synced 2026-01-26 10:55:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Added strong naming and fixed a dependency (#34)

Browse Source 
* Added strong naming for the .NET Framework 4.x dlls as was discussed in #3. Strong naming doesn't help for security but it's sometimes needed as companies want to build strongly named assemblies themselves, and these can only use other strong named assembly. The general way to do this, is to sign the assembly with a public known snk file (Which is in the repository) so it's strongly named but without negative side effects.
* Fixed a tricky issue with .resx files, concerns GenerateResourceUsePreserializedResources and dependencies.
* Fixed the copyright years.
* Fixed an issue with SystemInfo, somehow the DpiFactorX/DpiFactorY weren't initialized.
* As net45 doesn't build with "dotnet build", we need to use msbuild instead.
* Removing unneeded packages for net4x
* msbuild needs nuget restore before the build to work
* Make sure that PRs don't push the packages to the nuget feed (will fail anyway)
This commit is contained in:
Robin Krom
2020-08-05 13:47:07 +02:00
committed by GitHub
parent 6a5dd84015
commit 2601f9d525
18 changed files with 89 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Directory.Build.props
View File

@@ -22,6 +22,12 @@ Source code and extensive sample application available at http://www.hardcodet.n
<tags>NotifyIcon WPF Tray Notify ToolTip Popup Balloon Toast</tags>
</PropertyGroup>
<PropertyGroup Condition="!$(TargetFramework.StartsWith('net4'))">
<GenerateResourceUsePreserializedResources>true</GenerateResourceUsePreserializedResources>
</PropertyGroup>
<PropertyGroup Condition="$(TargetFramework.StartsWith('net4'))">
<GenerateResourceUsePreserializedResources>false</GenerateResourceUsePreserializedResources>
</PropertyGroup>
<PropertyGroup Condition="$(TargetFramework.StartsWith('net4'))">
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
</PropertyGroup>
@@ -48,8 +54,14 @@ Source code and extensive sample application available at http://www.hardcodet.n
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
</PropertyGroup>
<PropertyGroup Condition="$(TargetFramework.StartsWith('net4'))">
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\NotifyIconWpf.snk</AssemblyOriginatorKeyFile>
<DelaySign>false</DelaySign>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Nerdbank.GitVersioning" Version="3.1.91">
<PackageReference Include="Nerdbank.GitVersioning" Version="3.2.31">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>