ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add no clouds selected warning popup (#24004)

Browse Source 
* initial commit, add no clouds selected warning popup

* move to constants file
This commit is contained in:
Christopher Suh
2023-07-27 17:42:47 -07:00
committed by GitHub
parent a7491170c3
commit 08909dfb27
3 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
extensions/azurecore/src/account-provider/azureAccountProviderService.ts
View File

@@ -43,6 +43,7 @@ export class AzureAccountProviderService implements vscode.Disposable {
private readonly _uriEventHandler: UriEventHandler = new UriEventHandler();
public clientApplication!: PublicClientApplication;
private _onEncryptionKeysUpdated: vscode.EventEmitter<CacheEncryptionKeys>;
public activeProviderCount: number = 0;
constructor(private _context: vscode.ExtensionContext,
private _userStoragePath: string) {
@@ -142,18 +143,28 @@ export class AzureAccountProviderService implements vscode.Disposable {
// Case 2: Provider was enabled and is now disabled - unregister provider
if (oldConfigValue && !newConfigValue) {
providerChanges.push(this.unregisterAccountProvider(provider));
this.activeProviderCount--;
}
// Case 3: Provider was disabled and is now enabled - register provider
if (!oldConfigValue && newConfigValue) {
providerChanges.push(this.registerAccountProvider(provider));
this.activeProviderCount++;
}
// Case 4: Provider was added from JSON - register provider
if (provider.configKey !== 'enablePublicCloud' && provider.configKey !== 'enableUsGovCloud' && provider.configKey !== 'enableChinaCloud') {
if (provider.configKey !== Constants.enablePublicCloud && provider.configKey !== Constants.enableUsGovCloud && provider.configKey !== Constants.enableChinaCloud) {
providerChanges.push(this.registerAccountProvider(provider));
this.activeProviderCount++;
}
}
if (this.activeProviderCount === 0) {
void vscode.window.showWarningMessage(loc.noCloudsEnabled, loc.enablePublicCloud, loc.dismiss).then(async (result) => {
if (result === loc.enablePublicCloud) {
await vscode.workspace.getConfiguration(Constants.AccountsAzureCloudSection).update(loc.enablePublicCloudCamel, true, vscode.ConfigurationTarget.Global);
}
});
}
// Process all the changes before continuing
await Promise.all(providerChanges);

6
extensions/azurecore/src/constants.ts
View File

@@ -25,6 +25,12 @@ export const AccountsAzureAuthSection = AccountsSection + '.' + AzureSection + '
export const AccountsAzureCloudSection = AccountsSection + '.' + AzureSection + '.' + CloudSection;
export const enablePublicCloud = 'enablePublicCloud';
export const enableUsGovCloud = 'enableUsGovCloud';
export const enableChinaCloud = 'enableChinaCloud';
export const EnableArcFeaturesSection = 'enableArcFeatures';
export const ServiceName = 'azuredatastudio';

3
extensions/azurecore/src/localizedConstants.ts
View File

@@ -11,6 +11,8 @@ export const extensionName = localize('azurecore.extensionName', "Azure Accounts
export const requiresReload = localize('azurecore.requiresReload', "Modifying this setting requires reloading the window for all changes to take effect.");
export const reload = localize('azurecore.reload', "Reload");
export const cancel = localize('azurecore.reload', "Cancel");
export const enablePublicCloud = localize('azurecore.enablePublicCloud', "Enable Public Cloud");
export const enablePublicCloudCamel = localize('azurecore.enablePublicCloud', "enablePublicCloud");
export const australiaCentral = localize('azurecore.australiacentral', "Australia Central");
export const australiaCentral2 = localize('azurecore.australiacentral2', "Australia Central 2");
@@ -97,3 +99,4 @@ export function unableToFetchTokenError(tenant: string): string {
// Error Messages
export const azureCredStoreSaveFailedError = localize('azure.credStoreSaveFailedError', `Keys for token cache could not be saved in credential store, this may cause Azure access token persistence issues and connection instabilities. It's likely that SqlTools has reached credential storage limit on Windows, please clear at least 2 credentials that start with "Microsoft.SqlTools|" in Windows Credential Manager and reload.`);
export const noCloudsEnabled = localize('azure.noCloudsEnabled', "No clouds are enabled, please enable a cloud to continue.");