ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-12 02:58:31 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding additional parameter to data workspace provider API (#13570) (#13574)

Browse Source
This commit is contained in:
Benjin Dubishar
2020-11-30 13:50:31 -08:00
committed by GitHub
parent 6ac5b7c8a5
commit 1eda5eb33a
4 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/data-workspace/src/dataworkspace.d.ts vendored
View File

@@ -55,8 +55,9 @@ declare module 'dataworkspace' {
*
* @param name Create a project
* @param location the parent directory of the project
* @param projectTypeId the identifier of the selected project type
*/
createProject(name: string, location: vscode.Uri): Promise<vscode.Uri>;
createProject(name: string, location: vscode.Uri, projectTypeId: string): Promise<vscode.Uri>;
/**
* Gets the supported project types

2
extensions/data-workspace/src/services/workspaceService.ts
View File

@@ -174,7 +174,7 @@ export class WorkspaceService implements IWorkspaceService {
async createProject(name: string, location: vscode.Uri, projectTypeId: string): Promise<vscode.Uri> {
const provider = ProjectProviderRegistry.getProviderByProjectType(projectTypeId);
if (provider) {
const projectFile = await provider.createProject(name, location);
const projectFile = await provider.createProject(name, location, projectTypeId);
this.addProjectsToWorkspace([projectFile]);
this._onDidWorkspaceProjectsChange.fire();
return projectFile;

2
extensions/data-workspace/src/test/projectProviderRegistry.test.ts
View File

@@ -29,7 +29,7 @@ export function createProjectProvider(projectTypes: IProjectType[]): IProjectPro
getProjectTreeDataProvider: (projectFile: vscode.Uri): Promise<vscode.TreeDataProvider<any>> => {
return Promise.resolve(treeDataProvider);
},
createProject: (name: string, location: vscode.Uri): Promise<vscode.Uri> => {
createProject: (name: string, location: vscode.Uri, projectTypeId: string): Promise<vscode.Uri> => {
return Promise.resolve(location);
}
};

2
extensions/sql-database-projects/src/projectProvider/projectProvider.ts
View File

@@ -58,7 +58,7 @@ export class SqlDatabaseProjectProvider implements dataworkspace.IProjectProvide
* @param location the parent directory
* @returns Uri of the newly created project file
*/
async createProject(name: string, location: vscode.Uri): Promise<vscode.Uri> {
async createProject(name: string, location: vscode.Uri, _: string): Promise<vscode.Uri> {
const projectFile = await this.projectController.createNewProject(name, location, true);
return vscode.Uri.file(projectFile);
}