ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Notebooks: Add telemetry event for mime type renderer not found (#18200)

Browse Source 
* Add event for mime type renderer not found

* Add back missing return statement
This commit is contained in:
Chris LaFreniere
2022-02-03 09:48:06 -08:00
committed by GitHub
parent c535c2dbde
commit 230c0f317f
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/sql/platform/telemetry/common/telemetryKeys.ts
View File

@@ -101,7 +101,8 @@ export const enum NbTelemetryAction {
KernelChanged = 'KernelChanged', KernelChanged = 'KernelChanged',
NewNotebookFromConnections = 'NewNotebookWithConnectionProfile', NewNotebookFromConnections = 'NewNotebookWithConnectionProfile',
UndoCell = 'UndoCell', UndoCell = 'UndoCell',
RedoCell = 'RedoCell' RedoCell = 'RedoCell',
MIMETypeRendererNotFound = 'MIMETypeRendererNotFound'
} }
export const enum TelemetryPropertyName { export const enum TelemetryPropertyName {

5
src/sql/workbench/contrib/notebook/browser/cellViews/output.component.ts
View File

@@ -23,6 +23,7 @@ import { getErrorMessage } from 'vs/base/common/errors';
import { CellView, findHighlightClass, findRangeSpecificClass } from 'sql/workbench/contrib/notebook/browser/cellViews/interfaces'; import { CellView, findHighlightClass, findRangeSpecificClass } from 'sql/workbench/contrib/notebook/browser/cellViews/interfaces';
import { INotebookService, NotebookRange } from 'sql/workbench/services/notebook/browser/notebookService'; import { INotebookService, NotebookRange } from 'sql/workbench/services/notebook/browser/notebookService';
import { NotebookInput } from 'sql/workbench/contrib/notebook/browser/models/notebookInput'; import { NotebookInput } from 'sql/workbench/contrib/notebook/browser/models/notebookInput';
import * as TelemetryKeys from 'sql/platform/telemetry/common/telemetryKeys';
export const OUTPUT_SELECTOR: string = 'output-component'; export const OUTPUT_SELECTOR: string = 'output-component';
const USER_SELECT_CLASS = 'actionselect'; const USER_SELECT_CLASS = 'actionselect';
@@ -152,9 +153,11 @@ export class OutputComponent extends CellView implements OnInit, AfterViewInit {
); );
this.errorText = undefined; this.errorText = undefined;
if (!mimeType) { if (!mimeType) {
const mimeTypesWithoutRenderer = Object.keys(options.data);
this.errorText = localize('noMimeTypeFound', "No {0}renderer could be found for output. It has the following MIME types: {1}", this.errorText = localize('noMimeTypeFound', "No {0}renderer could be found for output. It has the following MIME types: {1}",
options.trusted ? '' : localize('safe', "safe "), options.trusted ? '' : localize('safe', "safe "),
Object.keys(options.data).join(', ')); mimeTypesWithoutRenderer.join(', '));
this.cellModel?.notebookModel?.sendNotebookTelemetryActionEvent(TelemetryKeys.NbTelemetryAction.MIMETypeRendererNotFound, { mime_types: mimeTypesWithoutRenderer });
return; return;
} }
let selector = componentRegistry.getCtorFromMimeType(mimeType); let selector = componentRegistry.getCtorFromMimeType(mimeType);