ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix notebook connection dropdown opening multiple connection dialogs (#14283) (#14293)

Browse Source 
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This commit is contained in:
Chris LaFreniere
2021-02-12 21:44:20 -08:00
committed by GitHub
parent f212ddc253
commit 3419dd5498
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/workbench/contrib/notebook/browser/notebookActions.ts
View File

@@ -451,8 +451,10 @@ export class AttachToDropdown extends SelectBox {
}
public doChangeContext(connection?: ConnectionProfile, hideErrorMessage?: boolean): void {
if (this.value === msgChangeConnection || this.value === msgSelectConnection) {
if (this.value === msgChangeConnection) {
this.openConnectionDialog().catch(err => this._notificationService.error(getErrorMessage(err)));
} else if (this.value === msgSelectConnection) {
// no-op, select connection is the default option and so shouldn't have any action done when selected (which only happens if a user cancels out of the connection dialog)
} else {
this.model.changeContext(this.value, connection, hideErrorMessage).catch(err => this._notificationService.error(getErrorMessage(err)));
}