ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add required field to kube config picker (#15795)

Browse Source
This commit is contained in:
Charles Gagnon
2021-06-17 19:38:38 -07:00
committed by GitHub
parent efd752aafe
commit 35832e83da
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/arc/src/test/ui/components/filePicker.test.ts
View File

@@ -18,7 +18,7 @@ const newFileUri = vscode.Uri.file(path.join('path', 'to', 'new', '.kube', 'conf
describe('filePicker', function (): void { describe('filePicker', function (): void {
beforeEach(async () => { beforeEach(async () => {
const { modelBuilderMock } = createModelViewMock(); const { modelBuilderMock } = createModelViewMock();
filePicker = new FilePicker(modelBuilderMock.object, initialPath, (_disposable) => { }, '', ''); filePicker = new FilePicker(modelBuilderMock.object, initialPath, (_disposable) => { }, '', '', true);
}); });
afterEach(() => { afterEach(() => {

4
extensions/arc/src/ui/components/filePicker.ts
View File

@@ -21,7 +21,8 @@ export class FilePicker {
initialPath: string, initialPath: string,
onNewDisposableCreated: (disposable: vscode.Disposable) => void, onNewDisposableCreated: (disposable: vscode.Disposable) => void,
ariaLabel: string, ariaLabel: string,
validationErrorMessage: string validationErrorMessage: string,
required: boolean
) { ) {
const buttonWidth = 80; const buttonWidth = 80;
this.filePathInputBox = modelBuilder.inputBox() this.filePathInputBox = modelBuilder.inputBox()
@@ -29,6 +30,7 @@ export class FilePicker {
value: initialPath, value: initialPath,
ariaLabel: ariaLabel, ariaLabel: ariaLabel,
validationErrorMessage: validationErrorMessage, validationErrorMessage: validationErrorMessage,
required: required,
width: 350 width: 350
}).withValidation(async () => { }).withValidation(async () => {
try { try {

3
extensions/arc/src/ui/dialogs/connectControllerDialog.ts
View File

@@ -98,7 +98,8 @@ abstract class ControllerDialogBase extends InitializingComponent {
controllerInfo?.kubeConfigFilePath || getDefaultKubeConfigPath(), controllerInfo?.kubeConfigFilePath || getDefaultKubeConfigPath(),
(disposable) => this._toDispose.push(disposable), (disposable) => this._toDispose.push(disposable),
loc.controllerKubeConfig, loc.controllerKubeConfig,
loc.invalidConfigPath loc.invalidConfigPath,
true
); );
this.modelBuilder.inputBox() this.modelBuilder.inputBox()
.withProps({ .withProps({