ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix accessibility issue for open dialog location radio button (#22812)

Browse Source 
* fix accessibliity issue where location radio button showed as required

* fix ariaLabel
This commit is contained in:
Kim Santiago
2023-04-21 09:53:02 -07:00
committed by GitHub
parent c8618d39fe
commit 41e6f3b84b
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/data-workspace/src/common/constants.ts
View File

@@ -85,6 +85,7 @@ export const GitRepoUrlTitle = localize('dataworkspace.gitRepoUrlTitle', "Git re
export const GitRepoUrlPlaceholder = localize('dataworkspace.gitRepoUrlPlaceholder', "Enter remote git repository URL"); export const GitRepoUrlPlaceholder = localize('dataworkspace.gitRepoUrlPlaceholder', "Enter remote git repository URL");
export const LocalClonePathTitle = localize('dataworkspace.localClonePathTitle', "Local clone path"); export const LocalClonePathTitle = localize('dataworkspace.localClonePathTitle', "Local clone path");
export const LocalClonePathPlaceholder = localize('dataworkspace.localClonePathPlaceholder', "Select location to clone repository locally"); export const LocalClonePathPlaceholder = localize('dataworkspace.localClonePathPlaceholder', "Select location to clone repository locally");
export const ProjectFileTitle = localize('dataworkspace.projectFileTitle', "Project file");
// Workspace settings for saving new projects // Workspace settings for saving new projects
export const ProjectConfigurationKey = 'projects'; export const ProjectConfigurationKey = 'projects';

8
extensions/data-workspace/src/dialogs/openExistingDialog.ts
View File

@@ -119,7 +119,6 @@ export class OpenExistingDialog extends DialogBase {
this.locationRadioButtonFormComponent = { this.locationRadioButtonFormComponent = {
title: constants.LocationSelectorTitle, title: constants.LocationSelectorTitle,
required: true,
component: view.modelBuilder.flexContainer() component: view.modelBuilder.flexContainer()
.withItems([this.localRadioButton, this.remoteGitRepoRadioButton], { flex: '0 0 auto', CSSStyles: { 'margin-right': '15px' } }) .withItems([this.localRadioButton, this.remoteGitRepoRadioButton], { flex: '0 0 auto', CSSStyles: { 'margin-right': '15px' } })
.withProps({ ariaRole: 'radiogroup' }) .withProps({ ariaRole: 'radiogroup' })
@@ -192,7 +191,7 @@ export class OpenExistingDialog extends DialogBase {
}; };
this.filePathTextBox = view.modelBuilder.inputBox().withProps({ this.filePathTextBox = view.modelBuilder.inputBox().withProps({
ariaLabel: constants.LocationSelectorTitle, ariaLabel: constants.ProjectFileTitle,
placeHolder: constants.ProjectFilePlaceholder, placeHolder: constants.ProjectFilePlaceholder,
required: true, required: true,
width: constants.DefaultInputWidth width: constants.DefaultInputWidth
@@ -212,9 +211,10 @@ export class OpenExistingDialog extends DialogBase {
this.register(localProjectBrowseFolderButton.onDidClick(() => this.onBrowseButtonClick())); this.register(localProjectBrowseFolderButton.onDidClick(() => this.onBrowseButtonClick()));
const flexContainer = this.createHorizontalContainer(view, [this.filePathTextBox, localProjectBrowseFolderButton]); const flexContainer = this.createHorizontalContainer(view, [this.filePathTextBox, localProjectBrowseFolderButton]);
void flexContainer.updateCssStyles({ 'margin-top': '-10px' });
this.filePathAndButtonComponent = { this.filePathAndButtonComponent = {
component: flexContainer component: flexContainer,
title: constants.ProjectFileTitle,
required: true
}; };
this.formBuilder = view.modelBuilder.formContainer().withFormItems([ this.formBuilder = view.modelBuilder.formContainer().withFormItems([