remove dispose of button listeners (#4914)

This commit is contained in:
Anthony Dresser
2019-04-09 01:08:56 -07:00
committed by GitHub
parent a4bd31e96a
commit 4ece9b0085

View File

@@ -384,7 +384,7 @@ export abstract class Modal extends Disposable implements IThemable {
let footerButton = DOM.$('.footer-button');
let button = new Button(footerButton);
button.label = label;
this._register(button.onDidClick(() => onSelect()));
button.onDidClick(() => onSelect()); // @todo this should be registered to dispose but that brakes some dialogs
if (orientation === 'left') {
DOM.append(this._leftFooter, footerButton);
} else {