Add back common extension linting rules (#23271)

* Add back common extension linting rules

* Fix lint issues
This commit is contained in:
Charles Gagnon
2023-05-31 14:31:00 -07:00
committed by GitHub
parent 631461494f
commit 50e08e11df
22 changed files with 75 additions and 40 deletions

View File

@@ -1038,7 +1038,6 @@ export class Project implements ISqlProject {
/**
* Moves a file to a different location
* @param node Node being moved
* @param projectFilePath Full file path to .sqlproj
* @param destinationRelativePath path of the destination, relative to .sqlproj
*/
public async move(node: BaseProjectTreeItem, destinationRelativePath: string): Promise<azdataType.ResultStatus> {

View File

@@ -23,7 +23,6 @@ export class DatabaseReferencesTreeItem extends BaseProjectTreeItem {
* @param projectNodeName Name of the project node. Used for creating the relative path of the Database References node to the project
* @param sqlprojUri Full URI to the .sqlproj
* @param databaseReferences Array of database references in the project
* @param project
*/
constructor(projectNodeName: string, sqlprojUri: vscode.Uri, databaseReferences: IDatabaseReferenceProjectEntry[]) {
super(vscode.Uri.file(path.join(projectNodeName, constants.databaseReferencesNodeName)), sqlprojUri);

View File

@@ -21,7 +21,6 @@ export class SqlCmdVariablesTreeItem extends BaseProjectTreeItem {
* @param projectNodeName Name of the project node. Used for creating the relative path of the SQLCMD Variables node to the project
* @param sqlprojUri Full URI to the .sqlproj
* @param sqlCmdVariables Collection of SQLCMD variables in the project
* @param project
*/
constructor(projectNodeName: string, sqlprojUri: vscode.Uri, sqlCmdVariables: Map<string, string>) {
super(vscode.Uri.file(path.join(projectNodeName, constants.sqlcmdVariablesNodeName)), sqlprojUri);

View File

@@ -100,8 +100,10 @@ export async function createTestFile(test: Mocha.Runnable | undefined, contents:
* -file5.sql
* - file2.txt
*
* @param test
* @param createList Boolean specifying to create a list of the files and folders been created
* @param list List of files and folders that are been created
* @param testFolderPath
*/
export async function createDummyFileStructure(test: Mocha.Runnable | undefined, createList?: boolean, list?: Uri[], testFolderPath?: string): Promise<string> {
testFolderPath = testFolderPath ?? await generateTestFolderPath(test);
@@ -159,8 +161,10 @@ export async function createDummyFileStructure(test: Mocha.Runnable | undefined,
* - Script.PreDeployment2.sql
* - Script.PostDeployment1.sql
*
* @param test
* @param createList Boolean specifying to create a list of the files and folders been created
* @param list List of files and folders that are been created
* @param testFolderPath
*/
export async function createDummyFileStructureWithPrePostDeployScripts(test: Mocha.Runnable | undefined, createList?: boolean, list?: Uri[], testFolderPath?: string): Promise<string> {
testFolderPath = await createDummyFileStructure(test, createList, list, testFolderPath);