Add getOptionKeyIdNames to IConnectionProfile (#23262)

This commit is contained in:
Karl Burtram
2023-05-31 09:00:30 -07:00
committed by GitHub
parent 716176be07
commit 631461494f
12 changed files with 26 additions and 0 deletions

View File

@@ -254,6 +254,7 @@ export class ConnectionProfile extends ProviderConnectionInfo implements interfa
databaseName: this.databaseName,
authenticationType: this.authenticationType,
getOptionsKey: this.getOptionsKey,
getOptionKeyIdNames: this.getOptionKeyIdNames,
matches: this.matches,
groupId: this.groupId,
groupFullName: this.groupFullName,

View File

@@ -10,6 +10,7 @@ export type ProfileMatcher = (a: IConnectionProfile, b: IConnectionProfile) => b
export interface IConnectionProfile extends azdata.IConnectionProfile {
getOptionsKey(): string;
getOptionKeyIdNames(): string[];
matches(profile: azdata.IConnectionProfile): boolean;
}

View File

@@ -277,6 +277,7 @@ suite('ConnectionConfig', () => {
groupFullName: undefined,
groupId: undefined,
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -309,6 +310,7 @@ suite('ConnectionConfig', () => {
savePassword: true,
groupFullName: undefined,
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -341,6 +343,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'g2/g2-2',
groupId: undefined,
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -484,6 +487,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'g3',
groupId: 'g3',
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -514,6 +518,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'g3',
groupId: 'g3',
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -551,6 +556,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'g3',
groupId: 'newid',
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -631,6 +637,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'g3',
groupId: 'g3',
getOptionsKey: () => { return 'connectionId'; },
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -648,6 +655,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'test',
groupId: 'test',
getOptionsKey: () => { return 'connectionId'; },
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -688,6 +696,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'g3',
groupId: 'g3',
getOptionsKey: () => { return 'connectionId'; },
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -790,6 +799,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'g3',
groupId: 'g3',
getOptionsKey: () => { return 'connectionId'; },
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -807,6 +817,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'test',
groupId: 'test',
getOptionsKey: () => { return 'connectionId'; },
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},
@@ -824,6 +835,7 @@ suite('ConnectionConfig', () => {
groupFullName: 'test',
groupId: 'test',
getOptionsKey: () => { return 'connectionId'; },
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: 'MSSQL',
options: {},

View File

@@ -26,6 +26,7 @@ suite('SQL ConnectionProfileInfo tests', () => {
groupFullName: 'g2/g2-2',
groupId: 'group id',
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: mssqlProviderName,
options: {},

View File

@@ -32,6 +32,7 @@ suite('ConnectionStore', () => {
groupId: '',
groupFullName: '',
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: () => false,
providerName: mssqlProviderName,
options: {},

View File

@@ -25,6 +25,7 @@ suite('SQL ProviderConnectionInfo tests', () => {
groupFullName: 'g2/g2-2',
groupId: undefined,
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: mssqlProviderName,
options: undefined!,

View File

@@ -27,6 +27,7 @@ let connectionProfile: IConnectionProfile = {
groupFullName: 'g2/g2-2',
groupId: 'group id',
getOptionsKey: () => 'connection1',
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: mssqlProviderName,
options: {},
@@ -44,6 +45,7 @@ let editorConnectionProfile: IConnectionProfile = {
groupFullName: 'g2/g2-2',
groupId: 'group id',
getOptionsKey: () => 'connection2',
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: mssqlProviderName,
options: {},
@@ -61,6 +63,7 @@ let connectionProfileWithoutDbName: IConnectionProfile = {
groupFullName: 'g2/g2-2',
groupId: 'group id',
getOptionsKey: () => 'connection1',
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: mssqlProviderName,
options: {},

View File

@@ -68,6 +68,7 @@ suite('SQL ConnectionManagementService tests', () => {
groupFullName: 'g2/g2-2',
groupId: 'group id',
getOptionsKey: () => { return 'connectionId'; },
getOptionKeyIdNames: undefined!,
matches: undefined,
providerName: 'MSSQL',
options: {},

View File

@@ -75,6 +75,7 @@ suite('Insights Dialog Controller Tests', () => {
groupFullName: '',
groupId: '',
getOptionsKey: () => '',
getOptionKeyIdNames: undefined!,
matches: undefined,
providerName: '',
saveProfile: true,

View File

@@ -36,6 +36,7 @@ suite('AsyncServerTreeDragAndDrop', () => {
groupFullName: 'g2/g2-2',
groupId: 'group id',
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: mssqlProviderName,
options: {},

View File

@@ -41,6 +41,7 @@ suite('SQL Drag And Drop Controller tests', () => {
groupFullName: 'g2/g2-2',
groupId: 'group id',
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: mssqlProviderName,
options: {},
@@ -59,6 +60,7 @@ suite('SQL Drag And Drop Controller tests', () => {
groupFullName: 'g2/g2-2',
groupId: 'group id',
getOptionsKey: undefined!,
getOptionKeyIdNames: undefined!,
matches: undefined!,
providerName: pgsqlProviderName,
options: {},

View File

@@ -89,6 +89,7 @@ suite('Firewall rule dialog controller tests', () => {
groupFullName: 'g2/g2-2',
groupId: 'group id',
getOptionsKey: () => '',
getOptionKeyIdNames: undefined!,
matches: () => false,
providerName: mssqlProviderName,
options: {},