Add back common extension linting rules (#23271)

* Add back common extension linting rules

* Fix lint issues

.eslintignore

@@ -1,41 +1,22 @@
 **/build/*/**/*.js
 **/dist/**/*.js
+**/extensions/shared.webpack.config.js
+**/extensions/*/extension.webpack.config.js
 **/extensions/**/*.d.ts
 **/extensions/**/build/**
 **/extensions/**/colorize-fixtures/**
-**/extensions/azurecore/extension.webpack.config.js
 **/extensions/css-language-features/server/test/pathCompletionFixtures/**
 **/extensions/html-language-features/server/lib/jquery.d.ts
 **/extensions/html-language-features/server/src/test/pathCompletionFixtures/**
+**/extensions/ipynb/notebook-out/**
 **/extensions/markdown-language-features/media/**
 **/extensions/markdown-language-features/notebook-out/**
 **/extensions/markdown-math/notebook-out/**
 **/extensions/notebook-renderers/renderer-out/index.js
 **/extensions/simple-browser/media/index.js
 **/extensions/typescript-language-features/test-workspace/**
-**/vs/nls.build.js
+**/extensions/typescript-language-features/extension.webpack.config.js
-**/vs/nls.js
+**/extensions/typescript-language-features/extension-browser.webpack.config.js
-**/vs/css.build.js
-**/vs/css.js
-**/vs/loader.js
-**/dompurify/**
-**/marked/**
-**/semver/**
-**/test/**/*.js
-**/node_modules/**
-**/extensions/**/out/**
-**/extensions/**/build/**
-**/extensions/**/colorize-fixtures/**
-**/extensions/html-language-features/server/lib/jquery.d.ts
-/extensions/markdown-language-features/media/**
-/extensions/markdown-language-features/notebook-out/**
-**/extensions/markdown-math/notebook-out/**
-**/extensions/typescript-basics/test/colorize-fixtures/**
-**/extensions/**/dist/**
-/extensions/types
-/extensions/typescript-language-features/test-workspace/**
-/test/automation/out
-/resources/web/code-web.js
 **/extensions/vscode-api-tests/testWorkspace/**
 **/extensions/vscode-api-tests/testWorkspace2/**
 **/fixtures/**
@@ -49,10 +30,7 @@
 **/src/typings/**/*.d.ts
 **/src/vs/*/**/*.d.ts
 **/src/vs/base/test/common/filters.perf.data.js
-**/src/vs/css.build.js
-**/src/vs/css.js
 **/src/vs/loader.js
-**/src/vs/nls.build.js
-**/src/vs/nls.js
 **/test/unit/assert.js
+**/test/automation/out/**
 **/typings/**

extensions/.eslintrc.json

@@ -0,0 +1,8 @@
+{
+	"rules": {
+		"no-cond-assign": 2,
+		"jsdoc/check-param-names": "error",
+		"@typescript-eslint/explicit-function-return-type": ["error"],
+		"@typescript-eslint/await-thenable": ["error"]
+	}
+}

extensions/css-language-features/.eslintrc.json

@@ -0,0 +1,6 @@
+{
+	"rules": {
+		"@typescript-eslint/explicit-function-return-type": ["off"],
+		"@typescript-eslint/await-thenable": ["off"]
+	}
+}

extensions/datavirtualization/.eslintrc.json

@@ -0,0 +1,9 @@
+{
+	"parserOptions": {
+		"project": "./extensions/datavirtualization/tsconfig.json",
+		"createDefaultProgram": true
+	},
+	"rules": {
+		"@typescript-eslint/explicit-function-return-type": ["off"]
+	}
+}

extensions/datavirtualization/src/wizards/tableFromFile/pages/fileConfigPage.ts

@@ -187,7 +187,7 @@ export class FileConfigPage extends ImportPage {
 	private async populateDatabaseDropdown(): Promise<boolean> {
 		let idx = -1;
 		let count = -1;
-		let dbNames = await this.model.allDatabases.map(dbName => {
+		let dbNames = this.model.allDatabases.map(dbName => {
 			count++;
 			if (this.model.database && dbName === this.model.database) {
 				idx = count;

extensions/git-base/.eslintrc.json

@@ -0,0 +1,6 @@
+{
+	"rules": {
+		"@typescript-eslint/explicit-function-return-type": ["off"],
+		"@typescript-eslint/await-thenable": ["off"]
+	}
+}

extensions/html-language-features/.eslintrc.json

@@ -0,0 +1,6 @@
+{
+	"rules": {
+		"@typescript-eslint/explicit-function-return-type": ["off"],
+		"@typescript-eslint/await-thenable": ["off"]
+	}
+}

extensions/ipynb/.eslintrc.json

@@ -0,0 +1,6 @@
+{
+	"rules": {
+		"@typescript-eslint/explicit-function-return-type": ["off"],
+		"@typescript-eslint/await-thenable": ["off"]
+	}
+}

extensions/mssql/src/sqlProjects/sqlProjectsService.ts

@@ -288,7 +288,6 @@ export class SqlProjectsService extends BaseService implements mssql.ISqlProject
 	 * @param projectUri Absolute path of the project, including .sqlproj
 	 * @param name Name of the SQLCMD variable
 	 * @param defaultValue Default value of the SQLCMD variable
-	 * @param value Value of the SQLCMD variable, with or without the $()
 	 */
 	public async addSqlCmdVariable(projectUri: string, name: string, defaultValue: string): Promise<azdata.ResultStatus> {
 		const params: contracts.AddSqlCmdVariableParams = { projectUri: projectUri, name: name, defaultValue: defaultValue };
@@ -310,7 +309,6 @@ export class SqlProjectsService extends BaseService implements mssql.ISqlProject
 	 * @param projectUri Absolute path of the project, including .sqlproj
 	 * @param name Name of the SQLCMD variable
 	 * @param defaultValue Default value of the SQLCMD variable
-	 * @param value Value of the SQLCMD variable, with or without the $()
 	 */
 	public async updateSqlCmdVariable(projectUri: string, name: string, defaultValue: string): Promise<azdata.ResultStatus> {
 		const params: contracts.AddSqlCmdVariableParams = { projectUri: projectUri, name: name, defaultValue: defaultValue };

extensions/notebook-renderers/.eslintrc.json

@@ -0,0 +1,6 @@
+{
+	"rules": {
+		"@typescript-eslint/explicit-function-return-type": ["off"],
+		"@typescript-eslint/await-thenable": ["off"]
+	}
+}

extensions/sql-database-projects/src/models/project.ts

@@ -1038,7 +1038,6 @@ export class Project implements ISqlProject {
 	/**
 	 * Moves a file to a different location
 	 * @param node Node being moved
-	 * @param projectFilePath Full file path to .sqlproj
 	 * @param destinationRelativePath path of the destination, relative to .sqlproj
 	 */
 	public async move(node: BaseProjectTreeItem, destinationRelativePath: string): Promise<azdataType.ResultStatus> {

extensions/sql-database-projects/src/models/tree/databaseReferencesTreeItem.ts

@@ -23,7 +23,6 @@ export class DatabaseReferencesTreeItem extends BaseProjectTreeItem {
 	 * @param projectNodeName Name of the project node. Used for creating the relative path of the Database References node to the project
 	 * @param sqlprojUri Full URI to the .sqlproj
 	 * @param databaseReferences Array of database references in the project
-	 * @param project
 	 */
 	constructor(projectNodeName: string, sqlprojUri: vscode.Uri, databaseReferences: IDatabaseReferenceProjectEntry[]) {
 		super(vscode.Uri.file(path.join(projectNodeName, constants.databaseReferencesNodeName)), sqlprojUri);

extensions/sql-database-projects/src/models/tree/sqlcmdVariableTreeItem.ts

@@ -21,7 +21,6 @@ export class SqlCmdVariablesTreeItem extends BaseProjectTreeItem {
 	 * @param projectNodeName Name of the project node. Used for creating the relative path of the SQLCMD Variables node to the project
 	 * @param sqlprojUri Full URI to the .sqlproj
 	 * @param sqlCmdVariables Collection of SQLCMD variables in the project
-	 * @param project
 	 */
 	constructor(projectNodeName: string, sqlprojUri: vscode.Uri, sqlCmdVariables: Map<string, string>) {
 		super(vscode.Uri.file(path.join(projectNodeName, constants.sqlcmdVariablesNodeName)), sqlprojUri);

extensions/sql-database-projects/src/test/testUtils.ts

@@ -100,8 +100,10 @@ export async function createTestFile(test: Mocha.Runnable | undefined, contents:
  * 			-file5.sql
  * 		- file2.txt
  *
+ * @param test
  * @param createList Boolean specifying to create a list of the files and folders been created
  * @param list List of files and folders that are been created
+ * @param testFolderPath
  */
 export async function createDummyFileStructure(test: Mocha.Runnable | undefined, createList?: boolean, list?: Uri[], testFolderPath?: string): Promise<string> {
 	testFolderPath = testFolderPath ?? await generateTestFolderPath(test);
@@ -159,8 +161,10 @@ export async function createDummyFileStructure(test: Mocha.Runnable | undefined,
  * 		- Script.PreDeployment2.sql
  * 		- Script.PostDeployment1.sql
  *
+ * @param test
  * @param createList Boolean specifying to create a list of the files and folders been created
  * @param list List of files and folders that are been created
+ * @param testFolderPath
  */
 export async function createDummyFileStructureWithPrePostDeployScripts(test: Mocha.Runnable | undefined, createList?: boolean, list?: Uri[], testFolderPath?: string): Promise<string> {
 	testFolderPath = await createDummyFileStructure(test, createList, list, testFolderPath);

extensions/sql-migration/src/dashboard/migrationDetailsTab.ts

@@ -124,7 +124,7 @@ export class MigrationDetailsTab extends MigrationDetailsTabBase<MigrationDetail
 			await this.statusBar.clearError();
 
 			if (initialize) {
-				await this._clearControlsValue();
+				this._clearControlsValue();
 				await utils.updateControlDisplay(this._fileTable, false);
 				await this._fileTable.updateProperty('columns', this._getTableColumns(this.model?.migration));
 				await this._showControls(this.model?.migration);

extensions/sql-migration/src/dashboard/migrationDetailsTabBase.ts

@@ -247,7 +247,7 @@ export abstract class MigrationDetailsTabBase<T> extends TabBase<T> {
 					await this.statusBar.clearError();
 					if (canRetryMigration(this.model.migration)) {
 						const errorMessage = getMigrationErrors(this.model.migration);
-						await openRetryMigrationDialog(
+						openRetryMigrationDialog(
 							errorMessage,
 							async () => {
 								try {

extensions/sql-migration/src/dashboard/migrationDetailsTableTab.ts

@@ -89,7 +89,7 @@ export class MigrationDetailsTableTab extends MigrationDetailsTabBase<MigrationD
 			this.refreshLoader.loading = true;
 			await this.statusBar.clearError();
 			if (initialize) {
-				await this._clearControlsValue();
+				this._clearControlsValue();
 			}
 			await this.model.fetchStatus();
 			await this._loadData();

extensions/sql-migration/src/dashboard/sqlServerDashboard.ts

@@ -361,7 +361,7 @@ export class DashboardWidget {
 					const migration = await this._getMigrationById(args.migrationId, args.migrationOperationId);
 					if (service && migration && canRetryMigration(migration)) {
 						const errorMessage = getMigrationErrors(migration);
-						await openRetryMigrationDialog(
+						openRetryMigrationDialog(
 							errorMessage,
 							async () => {
 								try {

extensions/sql-migration/src/wizard/databaseBackupPage.ts

@@ -1468,7 +1468,7 @@ export class DatabaseBackupPage extends MigrationWizardPage {
 
 	private async getSubscriptionValues(): Promise<void> {
 		this._networkShareContainerSubscription.value = this.migrationStateModel._targetSubscription.name;
-		this._networkShareContainerLocation.value = await this.migrationStateModel._location.displayName;
+		this._networkShareContainerLocation.value = this.migrationStateModel._location.displayName;
 
 		this._blobContainerSubscription.value = this.migrationStateModel._targetSubscription.name;
 		this._blobContainerLocation.value = this.migrationStateModel._location.displayName;

extensions/typescript-language-features/.eslintrc.json

@@ -0,0 +1,6 @@
+{
+	"rules": {
+		"@typescript-eslint/explicit-function-return-type": ["off"],
+		"@typescript-eslint/await-thenable": ["off"]
+	}
+}

extensions/vscode-api-tests/.eslintrc.json

@@ -0,0 +1,6 @@
+{
+	"rules": {
+		"@typescript-eslint/explicit-function-return-type": ["off"],
+		"@typescript-eslint/await-thenable": ["off"]
+	}
+}

src/vs/nls.build.js

@@ -169,7 +169,6 @@ var NLSBuildLoaderPlugin;
                 bundles: this._getEntryPointsMap()
             }, null, '\t'));
         };
-        ;
         NLSPlugin.DEFAULT_TAG = 'i-default';
         NLSPlugin.BUILD_MAP = {};
         NLSPlugin.BUILD_MAP_KEYS = {};