ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-09 09:42:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

More MSSQL strict null (#22420)

Browse Source
This commit is contained in:
Charles Gagnon
2023-03-23 11:13:04 -07:00
committed by GitHub
parent 2805f9f499
commit 57c35ca255
5 changed files with 29 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/mssql/src/cms/cmsService.ts
View File

@@ -42,7 +42,7 @@ export class CmsService implements ICmsService {
},
e => {
this.client.logFailedRequest(contracts.CreateCentralManagementServerRequest.type, e);
return Promise.reject(new Error(e.message));
return Promise.reject(e);
}
);
}
@@ -55,7 +55,7 @@ export class CmsService implements ICmsService {
},
e => {
this.client.logFailedRequest(contracts.ListRegisteredServersRequest.type, e);
return Promise.reject(new Error(e.message));
return Promise.reject(e);
}
);
}
@@ -68,7 +68,7 @@ export class CmsService implements ICmsService {
},
e => {
this.client.logFailedRequest(contracts.AddRegisteredServerRequest.type, e);
return Promise.reject(new Error(e.message));
return Promise.reject(e);
}
);
}
@@ -81,7 +81,7 @@ export class CmsService implements ICmsService {
},
e => {
this.client.logFailedRequest(contracts.RemoveRegisteredServerRequest.type, e);
return Promise.reject(new Error(e.message));
return Promise.reject(e);
}
);
}

18
extensions/mssql/src/dacfx/dacFxService.ts
View File

@@ -38,7 +38,7 @@ export class DacFxService implements mssql.IDacFxService {
undefined,
e => {
this.client.logFailedRequest(contracts.ExportRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e);
}
);
}
@@ -49,7 +49,7 @@ export class DacFxService implements mssql.IDacFxService {
undefined,
e => {
this.client.logFailedRequest(contracts.ImportRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(undefined);
}
);
}
@@ -60,7 +60,7 @@ export class DacFxService implements mssql.IDacFxService {
undefined,
e => {
this.client.logFailedRequest(contracts.ExtractRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(undefined);
}
);
}
@@ -71,7 +71,7 @@ export class DacFxService implements mssql.IDacFxService {
undefined,
e => {
this.client.logFailedRequest(contracts.ExtractRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(undefined);
}
);
}
@@ -82,7 +82,7 @@ export class DacFxService implements mssql.IDacFxService {
undefined,
e => {
this.client.logFailedRequest(contracts.DeployRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(undefined);
}
);
}
@@ -93,7 +93,7 @@ export class DacFxService implements mssql.IDacFxService {
undefined,
e => {
this.client.logFailedRequest(contracts.GenerateDeployScriptRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(undefined);
}
);
}
@@ -104,7 +104,7 @@ export class DacFxService implements mssql.IDacFxService {
undefined,
e => {
this.client.logFailedRequest(contracts.GenerateDeployPlanRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(undefined);
}
);
}
@@ -115,7 +115,7 @@ export class DacFxService implements mssql.IDacFxService {
undefined,
e => {
this.client.logFailedRequest(contracts.GetOptionsFromProfileRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(undefined);
}
);
}
@@ -126,7 +126,7 @@ export class DacFxService implements mssql.IDacFxService {
undefined,
e => {
this.client.logFailedRequest(contracts.ValidateStreamingJobRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(undefined);
}
);
}

6
extensions/mssql/src/errorDiagnostics/errorDiagnosticsProvider.ts
View File

@@ -136,5 +136,9 @@ export class ErrorDiagnosticsProvider extends SqlOpsFeature<any> {
super(client, ErrorDiagnosticsProvider.messagesTypes);
}
protected registerProvider(options: any): Disposable { return undefined; }
protected registerProvider(options: any): Disposable {
return {
dispose: () => { }
}
}
}

4
extensions/mssql/src/resourceProvider/resourceProvider.ts
View File

@@ -65,8 +65,8 @@ function asCreateFirewallRuleParams(account: azdata.Account, params: azdata.Fire
account: account,
firewallRuleName: params.firewallRuleName,
serverName: params.serverName,
startIpAddress: params.startIpAddress,
endIpAddress: params.endIpAddress,
startIpAddress: params.startIpAddress || '',
endIpAddress: params.endIpAddress || '',
securityTokenMappings: params.securityTokenMappings
};
}

18
extensions/mssql/src/schemaCompare/schemaCompareService.ts
View File

@@ -38,7 +38,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
undefined,
e => {
this.client.logFailedRequest(contracts.SchemaCompareRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e)
}
);
}
@@ -49,7 +49,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
undefined,
e => {
this.client.logFailedRequest(contracts.SchemaCompareGenerateScriptRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e)
}
);
}
@@ -60,7 +60,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
undefined,
e => {
this.client.logFailedRequest(contracts.SchemaComparePublishDatabaseChangesRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e)
}
);
}
@@ -71,7 +71,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
undefined,
(e: any) => {
this.client.logFailedRequest(contracts.SchemaComparePublishProjectChangesRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e)
}
);
}
@@ -82,7 +82,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
undefined,
e => {
this.client.logFailedRequest(contracts.SchemaCompareGetDefaultOptionsRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e)
}
);
}
@@ -93,7 +93,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
undefined,
e => {
this.client.logFailedRequest(contracts.SchemaCompareIncludeExcludeNodeRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e)
}
);
}
@@ -104,7 +104,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
undefined,
e => {
this.client.logFailedRequest(contracts.SchemaCompareOpenScmpRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e)
}
);
}
@@ -115,7 +115,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
undefined,
e => {
this.client.logFailedRequest(contracts.SchemaCompareSaveScmpRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e)
}
);
}
@@ -126,7 +126,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
undefined,
e => {
this.client.logFailedRequest(contracts.SchemaCompareCancellationRequest.type, e);
return Promise.resolve(undefined);
return Promise.reject(e)
}
);
}