More MSSQL strict null (#22420)

extensions/mssql/src/cms/cmsService.ts

@@ -42,7 +42,7 @@ export class CmsService implements ICmsService {
 			},
 			e => {
 				this.client.logFailedRequest(contracts.CreateCentralManagementServerRequest.type, e);
-				return Promise.reject(new Error(e.message));
+				return Promise.reject(e);
 			}
 		);
 	}
@@ -55,7 +55,7 @@ export class CmsService implements ICmsService {
 			},
 			e => {
 				this.client.logFailedRequest(contracts.ListRegisteredServersRequest.type, e);
-				return Promise.reject(new Error(e.message));
+				return Promise.reject(e);
 			}
 		);
 	}
@@ -68,7 +68,7 @@ export class CmsService implements ICmsService {
 			},
 			e => {
 				this.client.logFailedRequest(contracts.AddRegisteredServerRequest.type, e);
-				return Promise.reject(new Error(e.message));
+				return Promise.reject(e);
 			}
 		);
 	}
@@ -81,7 +81,7 @@ export class CmsService implements ICmsService {
 			},
 			e => {
 				this.client.logFailedRequest(contracts.RemoveRegisteredServerRequest.type, e);
-				return Promise.reject(new Error(e.message));
+				return Promise.reject(e);
 			}
 		);
 	}

extensions/mssql/src/dacfx/dacFxService.ts

@@ -38,7 +38,7 @@ export class DacFxService implements mssql.IDacFxService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.ExportRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e);
 			}
 		);
 	}
@@ -49,7 +49,7 @@ export class DacFxService implements mssql.IDacFxService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.ImportRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(undefined);
 			}
 		);
 	}
@@ -60,7 +60,7 @@ export class DacFxService implements mssql.IDacFxService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.ExtractRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(undefined);
 			}
 		);
 	}
@@ -71,7 +71,7 @@ export class DacFxService implements mssql.IDacFxService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.ExtractRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(undefined);
 			}
 		);
 	}
@@ -82,7 +82,7 @@ export class DacFxService implements mssql.IDacFxService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.DeployRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(undefined);
 			}
 		);
 	}
@@ -93,7 +93,7 @@ export class DacFxService implements mssql.IDacFxService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.GenerateDeployScriptRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(undefined);
 			}
 		);
 	}
@@ -104,7 +104,7 @@ export class DacFxService implements mssql.IDacFxService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.GenerateDeployPlanRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(undefined);
 			}
 		);
 	}
@@ -115,7 +115,7 @@ export class DacFxService implements mssql.IDacFxService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.GetOptionsFromProfileRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(undefined);
 			}
 		);
 	}
@@ -126,7 +126,7 @@ export class DacFxService implements mssql.IDacFxService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.ValidateStreamingJobRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(undefined);
 			}
 		);
 	}

extensions/mssql/src/errorDiagnostics/errorDiagnosticsProvider.ts

@@ -136,5 +136,9 @@ export class ErrorDiagnosticsProvider extends SqlOpsFeature<any> {
 		super(client, ErrorDiagnosticsProvider.messagesTypes);
 	}
 
-	protected registerProvider(options: any): Disposable { return undefined; }
+	protected registerProvider(options: any): Disposable {
+		return {
+			dispose: () => { }
+		}
+	}
 }

extensions/mssql/src/resourceProvider/resourceProvider.ts

@@ -65,8 +65,8 @@ function asCreateFirewallRuleParams(account: azdata.Account, params: azdata.Fire
 		account: account,
 		firewallRuleName: params.firewallRuleName,
 		serverName: params.serverName,
-		startIpAddress: params.startIpAddress,
+		startIpAddress: params.startIpAddress || '',
-		endIpAddress: params.endIpAddress,
+		endIpAddress: params.endIpAddress || '',
 		securityTokenMappings: params.securityTokenMappings
 	};
 }

extensions/mssql/src/schemaCompare/schemaCompareService.ts

@@ -38,7 +38,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.SchemaCompareRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e)
 			}
 		);
 	}
@@ -49,7 +49,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.SchemaCompareGenerateScriptRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e)
 			}
 		);
 	}
@@ -60,7 +60,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.SchemaComparePublishDatabaseChangesRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e)
 			}
 		);
 	}
@@ -71,7 +71,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
 			undefined,
 			(e: any) => {
 				this.client.logFailedRequest(contracts.SchemaComparePublishProjectChangesRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e)
 			}
 		);
 	}
@@ -82,7 +82,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.SchemaCompareGetDefaultOptionsRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e)
 			}
 		);
 	}
@@ -93,7 +93,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.SchemaCompareIncludeExcludeNodeRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e)
 			}
 		);
 	}
@@ -104,7 +104,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.SchemaCompareOpenScmpRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e)
 			}
 		);
 	}
@@ -115,7 +115,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.SchemaCompareSaveScmpRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e)
 			}
 		);
 	}
@@ -126,7 +126,7 @@ export class SchemaCompareService implements mssql.ISchemaCompareService {
 			undefined,
 			e => {
 				this.client.logFailedRequest(contracts.SchemaCompareCancellationRequest.type, e);
-				return Promise.resolve(undefined);
+				return Promise.reject(e)
 			}
 		);
 	}