ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

remove sql server 2005 and 2008 as options for sql database projects (#18664)

Browse Source 
* remove sql server 2005 and 2008 from target platforms

* also remove 2005 and 2008 from SqlTargetPlatform enum

* fix a windows test
This commit is contained in:
Kim Santiago
2022-03-10 18:11:49 -08:00
committed by GitHub
parent 85d6b2ef46
commit 5f2d8b2bd5
3 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/sql-database-projects/src/common/constants.ts
View File

@@ -510,8 +510,6 @@ export function differentDbDifferentServerExampleUsage(server: string, db: strin
// Target platforms // Target platforms
export const targetPlatformToVersion: Map<string, string> = new Map<string, string>([ export const targetPlatformToVersion: Map<string, string> = new Map<string, string>([
[SqlTargetPlatform.sqlServer2005, '90'],
[SqlTargetPlatform.sqlServer2008, '100'],
[SqlTargetPlatform.sqlServer2012, '110'], [SqlTargetPlatform.sqlServer2012, '110'],
[SqlTargetPlatform.sqlServer2014, '120'], [SqlTargetPlatform.sqlServer2014, '120'],
[SqlTargetPlatform.sqlServer2016, '130'], [SqlTargetPlatform.sqlServer2016, '130'],

2
extensions/sql-database-projects/src/sqldbproj.d.ts vendored
View File

@@ -173,8 +173,6 @@ declare module 'sqldbproj' {
* Target platforms for a sql project * Target platforms for a sql project
*/ */
export const enum SqlTargetPlatform { export const enum SqlTargetPlatform {
sqlServer2005 = 'SQL Server 2005',
sqlServer2008 = 'SQL Server 2008',
sqlServer2012 = 'SQL Server 2012', sqlServer2012 = 'SQL Server 2012',
sqlServer2014 = 'SQL Server 2014', sqlServer2014 = 'SQL Server 2014',
sqlServer2016 = 'SQL Server 2016', sqlServer2016 = 'SQL Server 2016',

2
extensions/sql-database-projects/src/test/buildHelper.test.ts
View File

@@ -30,7 +30,7 @@ describe('BuildHelper: Build Helper tests', function (): void {
const resultArg = buildHelper.constructBuildArguments('dummy\\project path\\more space in path', 'dummy\\dll path', true); const resultArg = buildHelper.constructBuildArguments('dummy\\project path\\more space in path', 'dummy\\dll path', true);
if (os.platform() === 'win32') { if (os.platform() === 'win32') {
should(resultArg).equal(' build "dummy\\\\project path\\\\more space in path" /p:NetCoreBuild=true /p:SystemDacpacsLocation=="dummy\\\\dll path"'); should(resultArg).equal(' build "dummy\\\\project path\\\\more space in path" /p:NetCoreBuild=true /p:SystemDacpacsLocation="dummy\\\\dll path"');
} }
else { else {
should(resultArg).equal(' build "dummy/project path/more space in path" /p:NetCoreBuild=true /p:SystemDacpacsLocation="dummy/dll path"'); should(resultArg).equal(' build "dummy/project path/more space in path" /p:NetCoreBuild=true /p:SystemDacpacsLocation="dummy/dll path"');