ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add back "Install" text on welcome page button and remove tooltip (#24214)

Browse Source 
* remove tooltip from install button on welcome page

* fix missing Install text
This commit is contained in:
Kim Santiago
2023-08-28 18:43:43 -07:00
committed by GitHub
parent 98c17b85e7
commit 7640a7b4a3
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/sql/workbench/contrib/welcome/browser/welcomePage.ts
View File

@@ -577,12 +577,12 @@ class WelcomePage extends Disposable {
if (btnContainer) { if (btnContainer) {
extensionPacks.forEach((extension) => { extensionPacks.forEach((extension) => {
const installText = localize('welcomePage.install', "Install"); const installText = localize('welcomePage.install', "Install");
this._register(new Button(btnContainer, { title: installText, supportIcons: true, ...defaultButtonStyles })); let dropdownBtn = this._register(new Button(btnContainer, { supportIcons: true, ...defaultButtonStyles }));
dropdownBtn.label = installText;
const classes = ['btn']; const classes = ['btn'];
const getDropdownBtn = container.querySelector('.extensionPack .monaco-button:first-of-type') as HTMLAnchorElement; const getDropdownBtn = container.querySelector('.extensionPack .monaco-button:first-of-type') as HTMLAnchorElement;
getDropdownBtn.id = 'dropdown-btn'; getDropdownBtn.id = 'dropdown-btn';
getDropdownBtn.classList.add(...classes); getDropdownBtn.classList.add(...classes);
getDropdownBtn.title = extension.title || (extension.isKeymap ? localize('welcomePage.installKeymap', "Install {0} keymap", extension.name) : localize('welcomePage.installExtensionPack', "Install additional support for {0}", extension.name));
getDropdownBtn.setAttribute('aria-haspopup', 'true'); getDropdownBtn.setAttribute('aria-haspopup', 'true');
getDropdownBtn.setAttribute('aria-controls', 'dropdown'); getDropdownBtn.setAttribute('aria-controls', 'dropdown');
getDropdownBtn.setAttribute('role', 'navigation'); getDropdownBtn.setAttribute('role', 'navigation');
@@ -602,7 +602,7 @@ class WelcomePage extends Disposable {
const header = container.querySelector('.extension-pack-header'); const header = container.querySelector('.extension-pack-header');
const installedText = localize('welcomePage.installed', "Installed"); const installedText = localize('welcomePage.installed', "Installed");
let installedButton = new Button(btnContainer, { title: installedText, supportIcons: true, ...defaultButtonStyles }); let installedButton = new Button(btnContainer, { supportIcons: true, ...defaultButtonStyles });
this._register(installedButton); this._register(installedButton);
installedButton.label = installedText; installedButton.label = installedText;
@@ -610,7 +610,6 @@ class WelcomePage extends Disposable {
const getInstalledButton = container.querySelector('.extensionPack .monaco-button:nth-of-type(2)') as HTMLAnchorElement; const getInstalledButton = container.querySelector('.extensionPack .monaco-button:nth-of-type(2)') as HTMLAnchorElement;
getInstalledButton.innerText = localize('welcomePage.installed', "Installed"); getInstalledButton.innerText = localize('welcomePage.installed', "Installed");
getInstalledButton.title = extension.isKeymap ? localize('welcomePage.installedKeymap', "{0} keymap is already installed", extension.name) : localize('welcomePage.installedExtensionPack', "{0} support is already installed", extension.name);
getInstalledButton.classList.add('enabledExtension'); getInstalledButton.classList.add('enabledExtension');
getInstalledButton.classList.add(...classes); getInstalledButton.classList.add(...classes);
getInstalledButton.setAttribute('data-extension', extension.id); getInstalledButton.setAttribute('data-extension', extension.id);