fixed insights crash (#2596)

This commit is contained in:
Aditya Bist
2018-09-14 21:20:37 -07:00
committed by Karl Burtram
parent dede5c5ef5
commit 77e1cd8b32
2 changed files with 2 additions and 0 deletions

View File

@@ -518,5 +518,6 @@ export abstract class Modal extends Disposable implements IThemable {
public dispose() {
super.dispose();
this._keydownListener.dispose();
this._footerButtons = [];
}
}

View File

@@ -334,6 +334,7 @@ export class InsightsDialogView extends Modal {
this.hide();
dispose(this._taskButtonDisposables);
this._taskButtonDisposables = [];
this.dispose();
}
protected onClose(e: StandardKeyboardEvent) {