ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

fixed insights crash (#2596)

Browse Source
This commit is contained in:
Aditya Bist
2018-09-14 21:20:37 -07:00
committed by Karl Burtram
parent dede5c5ef5
commit 77e1cd8b32
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/sql/base/browser/ui/modal/modal.ts
View File

@@ -518,5 +518,6 @@ export abstract class Modal extends Disposable implements IThemable {
public dispose() { public dispose() {
super.dispose(); super.dispose();
this._keydownListener.dispose(); this._keydownListener.dispose();
this._footerButtons = [];
} }
} }

1
src/sql/parts/insights/browser/insightsDialogView.ts
View File

@@ -334,6 +334,7 @@ export class InsightsDialogView extends Modal {
this.hide(); this.hide();
dispose(this._taskButtonDisposables); dispose(this._taskButtonDisposables);
this._taskButtonDisposables = []; this._taskButtonDisposables = [];
this.dispose();
} }
protected onClose(e: StandardKeyboardEvent) { protected onClose(e: StandardKeyboardEvent) {