ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix #4145 Possible for loading icon to appear with rendered widget (#4147)

Browse Source 
- For cached insights, it was going down the checkStorage path which wasn't covered
This commit is contained in:
Kevin Cunnane
2019-02-22 18:06:00 -08:00
committed by GitHub
parent 8bb71eeb51
commit 7d5ce7b5d7
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/sql/parts/dashboard/widgets/insights/insightsWidget.component.ts
View File

@@ -107,7 +107,7 @@ export class InsightsWidget extends DashboardWidget implements IDashboardWidget,
this.queryObv = Observable.fromPromise(TPromise.as<SimpleExecuteResult>(error)); this.queryObv = Observable.fromPromise(TPromise.as<SimpleExecuteResult>(error));
} }
} }
); ).then(() => this._cd.detectChanges());
}); });
this._register(toDisposable(() => cancelablePromise.cancel())); this._register(toDisposable(() => cancelablePromise.cancel()));
} }
@@ -183,6 +183,7 @@ export class InsightsWidget extends DashboardWidget implements IDashboardWidget,
let storedResult: IStorageResult = JSON.parse(storage); let storedResult: IStorageResult = JSON.parse(storage);
let date = new Date(storedResult.date); let date = new Date(storedResult.date);
this.lastUpdated = nls.localize('insights.lastUpdated', "Last Updated: {0} {1}", date.toLocaleTimeString(), date.toLocaleDateString()); this.lastUpdated = nls.localize('insights.lastUpdated', "Last Updated: {0} {1}", date.toLocaleTimeString(), date.toLocaleDateString());
this._loading = false;
if (this._init) { if (this._init) {
this._updateChild(storedResult.results); this._updateChild(storedResult.results);
this.setupInterval(); this.setupInterval();