Remove deprecated "Asynchronous Processing" connection property (#20830)

extensions/cms/package.json

@@ -165,20 +165,6 @@
           "isRequired": false,
           "isArray": false
         },
-        {
-          "specialValueType": null,
-          "isIdentity": false,
-          "name": "asynchronousProcessing",
-          "displayName": "%cms.connectionOptions.asynchronousProcessing.displayName%",
-          "description": "%cms.connectionOptions.asynchronousProcessing.description%",
-          "groupName": "%cms.connectionOptions.groupName.initialization%",
-          "valueType": "boolean",
-          "defaultValue": null,
-          "objectType": null,
-          "categoryValues": null,
-          "isRequired": false,
-          "isArray": false
-        },
         {
           "specialValueType": null,
           "isIdentity": false,

extensions/cms/package.nls.json

@@ -60,8 +60,6 @@
 	"cms.connectionOptions.password.description": "Indicates the password to be used when connecting to the data source",
 	"cms.connectionOptions.applicationIntent.displayName": "Application intent",
 	"cms.connectionOptions.applicationIntent.description": "Declares the application workload type when connecting to a server",
-	"cms.connectionOptions.asynchronousProcessing.displayName": "Asynchronous processing",
-	"cms.connectionOptions.asynchronousProcessing.description": "When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider",
 	"cms.connectionOptions.connectTimeout.displayName": "Connect timeout",
 	"cms.connectionOptions.connectTimeout.description": "The length of time (in seconds) to wait for a connection to the server before terminating the attempt and generating an error",
 	"cms.connectionOptions.currentLanguage.displayName": "Current language",

extensions/mssql/package.json

@@ -946,20 +946,6 @@
           "isRequired": false,
           "isArray": false
         },
-        {
-          "specialValueType": null,
-          "isIdentity": false,
-          "name": "asynchronousProcessing",
-          "displayName": "%mssql.connectionOptions.asynchronousProcessing.displayName%",
-          "description": "%mssql.connectionOptions.asynchronousProcessing.description%",
-          "groupName": "%mssql.connectionOptions.groupName.initialization%",
-          "valueType": "boolean",
-          "defaultValue": null,
-          "objectType": null,
-          "categoryValues": null,
-          "isRequired": false,
-          "isArray": false
-        },
         {
           "specialValueType": null,
           "isIdentity": false,

extensions/mssql/package.nls.json

@@ -127,8 +127,6 @@
 	"mssql.connectionOptions.password.description": "Indicates the password to be used when connecting to the data source",
 	"mssql.connectionOptions.applicationIntent.displayName": "Application intent",
 	"mssql.connectionOptions.applicationIntent.description": "Declares the application workload type when connecting to a server",
-	"mssql.connectionOptions.asynchronousProcessing.displayName": "Asynchronous processing",
-	"mssql.connectionOptions.asynchronousProcessing.description": "When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider",
 	"mssql.connectionOptions.connectTimeout.displayName": "Connect timeout",
 	"mssql.connectionOptions.connectTimeout.description": "The length of time (in seconds) to wait for a connection to the server before terminating the attempt and generating an error",
 	"mssql.connectionOptions.currentLanguage.displayName": "Current language",

resources/xlf/en/cms.xlf

@@ -95,12 +95,6 @@
     <trans-unit id="cms.connectionOptions.applicationName.displayName">
       <source xml:lang="en">Application name</source>
     </trans-unit>
-    <trans-unit id="cms.connectionOptions.asynchronousProcessing.description">
-      <source xml:lang="en">When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider</source>
-    </trans-unit>
-    <trans-unit id="cms.connectionOptions.asynchronousProcessing.displayName">
-      <source xml:lang="en">Asynchronous processing</source>
-    </trans-unit>
     <trans-unit id="cms.connectionOptions.attachDbFilename.displayName">
       <source xml:lang="en">Attach DB filename</source>
     </trans-unit>

resources/xlf/en/mssql.xlf

@@ -724,12 +724,6 @@
     <trans-unit id="mssql.connectionOptions.applicationName.displayName">
       <source xml:lang="en">Application name</source>
     </trans-unit>
-    <trans-unit id="mssql.connectionOptions.asynchronousProcessing.description">
-      <source xml:lang="en">When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider</source>
-    </trans-unit>
-    <trans-unit id="mssql.connectionOptions.asynchronousProcessing.displayName">
-      <source xml:lang="en">Asynchronous processing</source>
-    </trans-unit>
     <trans-unit id="mssql.connectionOptions.attachDbFilename.displayName">
       <source xml:lang="en">Attach DB filename</source>
     </trans-unit>

src/sql/workbench/test/browser/modal/optionsDialogHelper.test.ts

@@ -47,9 +47,9 @@ suite('Advanced options helper tests', () => {
 		};
 
 		booleanOption = {
-			name: 'asynchronousProcessing',
+			name: 'trustServerCertificate',
-			displayName: 'Asynchronous processing enabled',
+			displayName: 'Trust Server Certificate enabled',
-			description: 'When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider',
+			description: 'When true (and encrypt=true), SQL Server uses SSL encryption for all data sent between the client and server without validating the server certificate',
 			groupName: 'Initialization',
 			categoryValues: null,
 			defaultValue: null,
@@ -228,7 +228,7 @@ suite('Advanced options helper tests', () => {
 		booleanOption.defaultValue = null;
 		booleanOption.isRequired = false;
 		possibleInputs = [];
-		options['asynchronousProcessing'] = true;
+		options['trustServerCertificate'] = true;
 		let optionValue = OptionsDialogHelper.getOptionValueAndCategoryValues(booleanOption, options, possibleInputs);
 		assert.strictEqual(optionValue, 'True');
 		assert.strictEqual(possibleInputs.length, 3);
@@ -241,7 +241,7 @@ suite('Advanced options helper tests', () => {
 		booleanOption.defaultValue = null;
 		booleanOption.isRequired = true;
 		possibleInputs = [];
-		options['asynchronousProcessing'] = 'False';
+		options['trustServerCertificate'] = 'False';
 		let optionValue = OptionsDialogHelper.getOptionValueAndCategoryValues(booleanOption, options, possibleInputs);
 		assert.strictEqual(optionValue, 'False');
 		assert.strictEqual(possibleInputs.length, 2);