ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixed color contrast for error message in connect a dc window. (#18411)

Browse Source 
* Fixed color contrast for error message in connect a dc window.

* Remove color check for error message

* Remove more unneeded checks

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
This commit is contained in:
Candice Ye
2022-02-16 21:06:51 -08:00
committed by GitHub
parent 2be1394748
commit 83698a14b0
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/arc/src/test/ui/components/radioOptionsGroup.test.ts
View File

@@ -52,9 +52,6 @@ describe('radioOptionsGroup', function (): void {
const label = radioOptionsGroup.items[0] as azdata.TextComponent; const label = radioOptionsGroup.items[0] as azdata.TextComponent;
should(label.value).not.be.undefined(); should(label.value).not.be.undefined();
label.value!.should.deepEqual(loc.loadingClusterContextsError(loadingError)); label.value!.should.deepEqual(loc.loadingClusterContextsError(loadingError));
should(label.CSSStyles).not.be.undefined();
should(label.CSSStyles!.color).not.be.undefined();
label.CSSStyles!.color.should.equal('Red');
}); });
describe('getters and setters', async () => { describe('getters and setters', async () => {

2
extensions/arc/src/ui/components/radioOptionsGroup.ts
View File

@@ -67,7 +67,7 @@ export class RadioOptionsGroup {
this.component().loadingCompletedText = this._loadingCompleteMessage; this.component().loadingCompletedText = this._loadingCompleteMessage;
} }
catch (e) { catch (e) {
const errorLabel = this._modelBuilder.text().withProps({ value: loc.loadingClusterContextsError(e), CSSStyles: { 'color': 'Red' } }).component(); const errorLabel = this._modelBuilder.text().withProps({ value: loc.loadingClusterContextsError(e), textType: azdata.TextType.Error }).component();
this._divContainer.addItem(errorLabel); this._divContainer.addItem(errorLabel);
this.component().loadingCompletedText = this._loadingCompleteErrorMessage(e); this.component().loadingCompletedText = this._loadingCompleteErrorMessage(e);
} }