ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

NaN checks aren't possible with an equality check (#7268)

Browse Source
This commit is contained in:
Amir Omidi
2019-09-18 10:59:58 -07:00
committed by GitHub
parent 6e7e6ee434
commit 86a9a2c069
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/base/browser/ui/table/tableDataView.ts
View File

@@ -22,7 +22,7 @@ function defaultSort<T extends { [key: string]: any }>(args: Slick.OnSortEventAr
const sign = args.sortAsc ? 1 : -1; const sign = args.sortAsc ? 1 : -1;
let comparer: (a: T, b: T) => number; let comparer: (a: T, b: T) => number;
if (types.isString(data[0][field])) { if (types.isString(data[0][field])) {
if (Number(data[0][field]) !== NaN) { if (!isNaN(Number(data[0][field]))) {
comparer = (a: T, b: T) => { comparer = (a: T, b: T) => {
let anum = Number(a[field]); let anum = Number(a[field]);
let bnum = Number(b[field]); let bnum = Number(b[field]);