ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Parameter renaming and number of calls reduce (#23760)

Browse Source 
Co-authored-by: Alexander Perfilyev <aperfilyev@microsoft.com>
This commit is contained in:
Alexander Perfilyev
2023-07-12 15:28:23 -07:00
committed by GitHub
parent 8bdc7d0346
commit 8b4b84e5c0
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/sql-migration/src/constants/strings.ts
View File

@@ -141,7 +141,7 @@ export const ASSESSMENT_COMPLETED = (serverName: string): string => {
export const ASSESSMENT_FAILED = (serverName: string): string => { export const ASSESSMENT_FAILED = (serverName: string): string => {
return localize('sql.migration.assessment.failed', "The assessment of your SQL Server instance '{0}' failed.", serverName); return localize('sql.migration.assessment.failed', "The assessment of your SQL Server instance '{0}' failed.", serverName);
}; };
export function ASSESSMENT_TILE(serverName: string): string { export function ASSESSMENT_TITLE(serverName: string): string {
return localize('sql.migration.assessment', "Assessment results for '{0}'", serverName); return localize('sql.migration.assessment', "Assessment results for '{0}'", serverName);
} }
export function CAN_BE_MIGRATED(eligibleDbs: number, totalDbs: number): string { export function CAN_BE_MIGRATED(eligibleDbs: number, totalDbs: number): string {

7
extensions/sql-migration/src/wizard/skuRecommendationPage.ts
View File

@@ -417,9 +417,10 @@ export class SKURecommendationPage extends MigrationWizardPage {
this._serverName = this.migrationStateModel.serverName || (await getSourceConnectionProfile()).serverName; this._serverName = this.migrationStateModel.serverName || (await getSourceConnectionProfile()).serverName;
const miDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE(this._serverName), this, MigrationTargetType.SQLMI); const assessmentTitle = constants.ASSESSMENT_TITLE(this._serverName);
const vmDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE(this._serverName), this, MigrationTargetType.SQLVM); const miDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, assessmentTitle, this, MigrationTargetType.SQLMI);
const dbDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE(this._serverName), this, MigrationTargetType.SQLDB); const vmDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, assessmentTitle, this, MigrationTargetType.SQLVM);
const dbDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, assessmentTitle, this, MigrationTargetType.SQLDB);
this._disposables.push(button.onDidClick(async (e) => { this._disposables.push(button.onDidClick(async (e) => {
switch (this._rbg.selectedCardId) { switch (this._rbg.selectedCardId) {