ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Displaying all event data (#1635)

Browse Source 
* Displaying all event data

* Fixing viewing blank text panels and highlighting

* add aria-label for insights dialog (#1629)

* Displaying all event data

* Fixing viewing blank text panels and highlighting

* descriptive comments, removing redundant code
This commit is contained in:
Madeline MacDonald
2018-06-15 14:16:42 -07:00
committed by GitHub
parent af2bc859d1
commit 8d89364d72
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/parts/profiler/editor/profilerEditor.ts
View File

@@ -228,7 +228,9 @@ export class ProfilerEditor extends BaseEditor {
if (data) { if (data) {
this._modelService.updateModel(this._editorModel, data['TextData']); this._modelService.updateModel(this._editorModel, data['TextData']);
this._detailTableData.clear(); this._detailTableData.clear();
this._detailTableData.push(Object.keys(data).map(key => { this._detailTableData.push(Object.keys(data).filter(key => {
return data[key] !== ' ';
}).map(key => {
return { return {
label: key, label: key,
value: data[key] value: data[key]

13
src/sql/parts/profiler/editor/profilerInput.ts
View File

@@ -129,7 +129,6 @@ export class ProfilerInput extends EditorInput implements IProfilerSession {
let data = {}; let data = {};
data['EventClass'] = e.name; data['EventClass'] = e.name;
data['StartTime'] = e.timestamp; data['StartTime'] = e.timestamp;
data['EndTime'] = e.timestamp;
const columns = [ const columns = [
'TextData', 'TextData',
'ApplicationName', 'ApplicationName',
@@ -156,12 +155,14 @@ export class ProfilerInput extends EditorInput implements IProfilerSession {
columnNameMap['cpu_time'] = 'CPU'; columnNameMap['cpu_time'] = 'CPU';
columnNameMap['duration'] = 'Duration'; columnNameMap['duration'] = 'Duration';
columnNameMap['logical_reads'] = 'Reads'; columnNameMap['logical_reads'] = 'Reads';
columnNameMap['event_sequence'] = 'EventSequence';
columnNameMap['client_pid'] = 'ClientProcessID';
columnNameMap['writes'] = 'Writes';
for (let idx = 0; idx < columns.length; ++idx) { // Using ' ' instead of '' fixed the error where clicking through events
let columnName = columns[idx]; // with empty text fields causes future text panes to be highlighted.
data[columnName] = ''; // This is a temporary fix, and should be changed before the July release
} data['TextData'] = ' ';
for (let key in e.values) { for (let key in e.values) {
let columnName = columnNameMap[key]; let columnName = columnNameMap[key];
if (columnName) { if (columnName) {