ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add required property in missing places in sql projects (#22253)

Browse Source 
* add required property for missing places in sql projects

* remove comma
This commit is contained in:
Kim Santiago
2023-03-09 08:45:21 -08:00
committed by GitHub
parent ec515a3b23
commit ab68c3060c
3 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/data-workspace/src/dialogs/newProjectDialog.ts
View File

@@ -284,7 +284,6 @@ export class NewProjectDialog extends DialogBase {
this.formBuilder = view.modelBuilder.formContainer().withFormItems([ this.formBuilder = view.modelBuilder.formContainer().withFormItems([
{ {
title: constants.TypeTitle, title: constants.TypeTitle,
required: true,
component: projectTypeRadioCardGroup component: projectTypeRadioCardGroup
}, },
{ {

3
extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts
View File

@@ -330,7 +330,8 @@ export class CreateProjectFromDatabaseDialog {
value: '', value: '',
ariaLabel: constants.location, ariaLabel: constants.location,
placeHolder: constants.projectLocationPlaceholderText, placeHolder: constants.projectLocationPlaceholderText,
width: cssStyles.createProjectFromDatabaseTextboxWidth width: cssStyles.createProjectFromDatabaseTextboxWidth,
required: true
}).component(); }).component();
this.projectLocationTextBox.onTextChanged(() => { this.projectLocationTextBox.onTextChanged(() => {

12
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
View File

@@ -569,7 +569,8 @@ export class PublishDatabaseDialog {
width: cssStyles.publishDialogTextboxWidth, width: cssStyles.publishDialogTextboxWidth,
enabled: true, enabled: true,
inputType: 'number', inputType: 'number',
validationErrorMessage: constants.portMustBeNumber validationErrorMessage: constants.portMustBeNumber,
required: true
}).withValidation(component => utils.validateSqlServerPortNumber(component.value)).component(); }).withValidation(component => utils.validateSqlServerPortNumber(component.value)).component();
this.serverPortTextBox.onTextChanged(() => { this.serverPortTextBox.onTextChanged(() => {
@@ -583,7 +584,8 @@ export class PublishDatabaseDialog {
width: cssStyles.publishDialogTextboxWidth, width: cssStyles.publishDialogTextboxWidth,
enabled: true, enabled: true,
inputType: 'password', inputType: 'password',
validationErrorMessage: constants.invalidSQLPasswordMessage(name) validationErrorMessage: constants.invalidSQLPasswordMessage(name),
required: true
}).withValidation(component => !utils.isEmptyString(component.value) && utils.isValidSQLPassword(component.value || '')).component(); }).withValidation(component => !utils.isEmptyString(component.value) && utils.isValidSQLPassword(component.value || '')).component();
const serverPasswordRow = this.createFormRow(view, constants.serverPassword(name), this.serverAdminPasswordTextBox); const serverPasswordRow = this.createFormRow(view, constants.serverPassword(name), this.serverAdminPasswordTextBox);
@@ -594,7 +596,8 @@ export class PublishDatabaseDialog {
width: cssStyles.publishDialogTextboxWidth, width: cssStyles.publishDialogTextboxWidth,
enabled: true, enabled: true,
inputType: 'password', inputType: 'password',
validationErrorMessage: constants.passwordNotMatch(name) validationErrorMessage: constants.passwordNotMatch(name),
required: true
}).withValidation(component => component.value === this.serverAdminPasswordTextBox?.value).component(); }).withValidation(component => component.value === this.serverAdminPasswordTextBox?.value).component();
this.serverAdminPasswordTextBox.onTextChanged(() => { this.serverAdminPasswordTextBox.onTextChanged(() => {
this.tryEnableGenerateScriptAndOkButtons(); this.tryEnableGenerateScriptAndOkButtons();
@@ -614,7 +617,8 @@ export class PublishDatabaseDialog {
values: baseImagesValues, values: baseImagesValues,
ariaLabel: constants.baseDockerImage(name), ariaLabel: constants.baseDockerImage(name),
width: cssStyles.publishDialogTextboxWidth, width: cssStyles.publishDialogTextboxWidth,
enabled: true enabled: true,
required: true
}).component(); }).component();
const imageInfo = baseImages.find(x => x.displayName === (<azdataType.CategoryValue>this.baseDockerImageDropDown?.value)?.displayName); const imageInfo = baseImages.find(x => x.displayName === (<azdataType.CategoryValue>this.baseDockerImageDropDown?.value)?.displayName);