ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-17 09:35:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix the "Failed to show notebook document" errors (#4649)

Browse Source
This commit is contained in:
Chris LaFreniere
2019-03-21 16:06:17 -07:00
committed by GitHub
parent 0b44b7d384
commit b00352570b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/api/node/extHostNotebookDocumentsAndEditors.ts
View File

@@ -109,7 +109,7 @@ export class ExtHostNotebookDocumentsAndEditors implements ExtHostNotebookDocume
this._mainContext.getProxy(SqlMainContext.MainThreadNotebookDocumentsAndEditors),
data.id,
documentData,
typeConverters.ViewColumn.to(data.editorPosition)
typeof data.editorPosition === 'number' ? typeConverters.ViewColumn.to(data.editorPosition) : undefined
);
this._editors.set(data.id, editor);
}

2
src/sql/workbench/api/node/sqlExtHost.protocol.ts
View File

@@ -840,7 +840,7 @@ export interface INotebookModelChangedData {
export interface INotebookEditorAddData {
id: string;
documentUri: UriComponents;
editorPosition: EditorViewColumn;
editorPosition: EditorViewColumn | undefined;
}
export interface INotebookShowOptions {