Fix the "Failed to show notebook document" errors (#4649)

This commit is contained in:
Chris LaFreniere
2019-03-21 16:06:17 -07:00
committed by GitHub
parent 0b44b7d384
commit b00352570b
2 changed files with 2 additions and 2 deletions

View File

@@ -109,7 +109,7 @@ export class ExtHostNotebookDocumentsAndEditors implements ExtHostNotebookDocume
this._mainContext.getProxy(SqlMainContext.MainThreadNotebookDocumentsAndEditors), this._mainContext.getProxy(SqlMainContext.MainThreadNotebookDocumentsAndEditors),
data.id, data.id,
documentData, documentData,
typeConverters.ViewColumn.to(data.editorPosition) typeof data.editorPosition === 'number' ? typeConverters.ViewColumn.to(data.editorPosition) : undefined
); );
this._editors.set(data.id, editor); this._editors.set(data.id, editor);
} }

View File

@@ -840,7 +840,7 @@ export interface INotebookModelChangedData {
export interface INotebookEditorAddData { export interface INotebookEditorAddData {
id: string; id: string;
documentUri: UriComponents; documentUri: UriComponents;
editorPosition: EditorViewColumn; editorPosition: EditorViewColumn | undefined;
} }
export interface INotebookShowOptions { export interface INotebookShowOptions {