Fix web smoke tests (#11759)

* fix web smoke tests

* readd web smoke
This commit is contained in:
Anthony Dresser
2020-08-12 12:02:42 -07:00
committed by GitHub
parent 8cbf73dff6
commit bc44014532
2 changed files with 8 additions and 9 deletions

View File

@@ -129,14 +129,13 @@ steps:
displayName: Run smoke tests (Electron)
condition: and(succeeded(), eq(variables['RUN_TESTS'], 'true'))
# - script: |
# set -e
# node ./node_modules/playwright/install.js
# VSCODE_REMOTE_SERVER_PATH="$(agent.builddirectory)/azuredatastudio-reh-web-darwin" \
# yarn smoketest --web --headless --screenshots "$(build.artifactstagingdirectory)/smokeshots"
# displayName: Run smoke tests (Browser)
# continueOnError: true
# condition: and(succeeded(), eq(variables['RUN_TESTS'], 'true'))
- script: |
set -e
node ./node_modules/playwright/install.js
VSCODE_REMOTE_SERVER_PATH="$(agent.builddirectory)/azuredatastudio-reh-web-darwin" \
yarn smoketest --web --headless --screenshots "$(build.artifactstagingdirectory)/smokeshots"
displayName: Run smoke tests (Browser)
condition: and(succeeded(), eq(variables['RUN_TESTS'], 'true'))
- script: |
set -e

View File

@@ -30,7 +30,7 @@ export class ConnectionDialog extends Dialog {
private static readonly CONNECT_BUTTON_SELECTOR = '.modal .modal-footer a[aria-label="Connect"]:not(.disabled)';
async connect(): Promise<void> {
await this.code.waitAndClick(ConnectionDialog.CONNECT_BUTTON_SELECTOR, 50, 24); // adjust for potentially a notification being in the way
await this.code.waitAndClick(ConnectionDialog.CONNECT_BUTTON_SELECTOR, 0, 10); // adjust for potentially a notification being in the way
return this.waitForDialogGone();
}