ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-17 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Reverting a change to ensure immediate notebook fix (#15326)

Browse Source
This commit is contained in:
Udeesha Gautam
2021-05-04 14:12:53 -07:00
committed by GitHub
parent 0fa0431707
commit bd4ebe65cc
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/base/browser/ui/selectBox/selectBox.ts
View File

@@ -216,12 +216,6 @@ export class SelectBox extends vsSelectBox {
let selectOptions: SelectOptionItemSQL[] = SelectBox.createOptions(options);
this.populateOptionsDictionary(selectOptions);
super.setOptions(selectOptions, selected);
// Calling super.setOptions even with a value selected doesn't fire the onSelected event and doesn't update this._selectedOption,
// So manually updating it here to ensure that the value is kept in sync.
// Currently we're not firing the onDidSelect event in this case to align with the base implementation, but that can change if there's a need for that to happen
if (this._dialogOptions !== undefined) {
this._selectedOption = this._dialogOptions[selected]?.value;
}
}
public get value(): string {