ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-13 17:22:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

set mode explicitly to notebook (#18089)

Browse Source 
* set mode explicitly to notebook

* move setMode to untitledNotebookInput

* wait until input is resolved for setMode

* invoke only when textInput is undefined

* pass the untitledTextInput in test
This commit is contained in:
Maddy
2022-01-24 14:17:34 -08:00
committed by GitHub
parent 3eff450322
commit bf5f18ea72
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/contrib/notebook/browser/models/untitledNotebookInput.ts
View File

@@ -26,6 +26,8 @@ export class UntitledNotebookInput extends NotebookInput {
@IExtensionService extensionService: IExtensionService
) {
super(title, resource, textInput, true, textModelService, instantiationService, notebookService, extensionService);
// Set the mode explicitly so that the auto language detection doesn't run and mark the model as being JSON
this.textInput.resolve().then(() => this.setMode('notebook'));
}
public override get textInput(): UntitledTextEditorInput {

2
src/sql/workbench/contrib/notebook/test/browser/notebookInput.test.ts
View File

@@ -84,7 +84,7 @@ suite('Notebook Input', function (): void {
// Input title
assert.strictEqual(untitledNotebookInput.getTitle(), testTitle);
let noTitleInput = instantiationService.createInstance(UntitledNotebookInput, undefined, untitledUri, undefined);
let noTitleInput = instantiationService.createInstance(UntitledNotebookInput, undefined, untitledUri, untitledTextInput);
assert.strictEqual(noTitleInput.getTitle(), basenameOrAuthority(untitledUri));
// Text Input