Fix css to fix new dashboard tab dialog (#5385)

* fix css to fix new dashboard tab dialog

* add readonly
This commit is contained in:
Anthony Dresser
2019-05-06 17:25:51 -07:00
committed by Karl Burtram
parent a7e94d433f
commit c6564c0d84
2 changed files with 7 additions and 8 deletions

View File

@@ -30,13 +30,10 @@ import { ILogService } from 'vs/platform/log/common/log';
class ExtensionListDelegate implements IListVirtualDelegate<IDashboardUITab> {
constructor(
private _height: number
) {
}
private static readonly HEIGHT = 101;
public getHeight(element: IDashboardUITab): number {
return this._height;
return ExtensionListDelegate.HEIGHT;
}
public getTemplateId(element: IDashboardUITab): string {
@@ -92,7 +89,6 @@ class ExtensionListRenderer implements IListRenderer<IDashboardUITab, ExtensionL
}
export class NewDashboardTabDialog extends Modal {
public static EXTENSIONLIST_HEIGHT = 101;
// MEMBER letIABLES ////////////////////////////////////////////////////
private _addNewTabButton: Button;
@@ -168,7 +164,7 @@ export class NewDashboardTabDialog extends Modal {
private createExtensionList(container: HTMLElement) {
// Create a fixed list view for the extensions
let extensionTabViewContainer = DOM.$('.extensionTab-view');
let delegate = new ExtensionListDelegate(NewDashboardTabDialog.EXTENSIONLIST_HEIGHT);
let delegate = new ExtensionListDelegate();
let extensionTabRenderer = new ExtensionListRenderer();
this._extensionList = new List<IDashboardUITab>(extensionTabViewContainer, delegate, [extensionTabRenderer]);