Fix dialog buttons (#23843)

* Fix dialog buttons

* comments

* Remove debug
This commit is contained in:
Charles Gagnon
2023-07-12 20:53:59 -07:00
committed by GitHub
parent 8b4b84e5c0
commit d294c81588
3 changed files with 4 additions and 4 deletions

View File

@@ -138,7 +138,8 @@ export class DialogModal extends Modal {
if (this._doneButton.enabled) {
let buttonSpinnerHandler = setTimeout(() => {
this._doneButton.enabled = false;
this._doneButton.element.innerHTML = '&nbsp';
// Temporarily set the label to empty since we're showing a spinner instead
this._doneButton.label = ''
this._doneButton.element.classList.add('validating');
}, 100);
if (await this._dialog.validateClose()) {

View File

@@ -319,7 +319,8 @@ export class WizardModal extends Modal {
let button = newPage === undefined ? this._doneButton : this._nextButton;
let buttonSpinnerHandler = setTimeout(() => {
button.enabled = false;
button.element.innerHTML = '&nbsp';
// Temporarily set the label to empty since we're showing a spinner instead
button.label = '';
button.element.classList.add('validating');
}, 100);
let navigationValid = await this._wizard.validateNavigation(newPage);

View File

@@ -49,8 +49,6 @@
"sql/base/browser/ui/panel/panel.ts",
"sql/base/browser/ui/selectBox/selectBox.ts",
"sql/base/browser/ui/panel/panel.component.ts",
"sql/workbench/services/dialog/browser/dialogModal.ts",
"sql/workbench/services/dialog/browser/wizardModal.ts",
"sql/base/browser/ui/taskbar/taskbar.ts",
"sql/workbench/contrib/notebook/browser/outputs/notebookMarkdown.ts",
"sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts",