ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix issue with empty connection (#5602)

Browse Source
This commit is contained in:
Anthony Dresser
2019-05-23 16:07:28 -07:00
committed by GitHub
parent 7b01a6ca61
commit db5a0a892a
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/platform/connection/common/connectionProfile.ts
View File

@@ -43,7 +43,7 @@ export class ConnectionProfile extends ProviderConnectionInfo implements interfa
this.saveProfile = model.saveProfile; this.saveProfile = model.saveProfile;
this._id = model.id; this._id = model.id;
this.azureTenantId = model.azureTenantId; this.azureTenantId = model.azureTenantId;
if (this.capabilitiesService) { if (this.capabilitiesService && model.providerName) {
const options = this.capabilitiesService.getCapabilities(model.providerName).connection.connectionOptions; const options = this.capabilitiesService.getCapabilities(model.providerName).connection.connectionOptions;
let appNameOption = options.find(option => option.specialValueType === ConnectionOptionSpecialType.appName); let appNameOption = options.find(option => option.specialValueType === ConnectionOptionSpecialType.appName);
if (appNameOption) { if (appNameOption) {

4
src/sqltest/parts/connection/connectionProfile.test.ts
View File

@@ -214,4 +214,8 @@ suite('SQL ConnectionProfileInfo tests', () => {
assert.notEqual(newProfile.id, conn.id); assert.notEqual(newProfile.id, conn.id);
assert.equal(newProfile.databaseName, 'new db'); assert.equal(newProfile.databaseName, 'new db');
}); });
test('an empty connection profile does not cause issues', () => {
assert.doesNotThrow(() => new ConnectionProfile(capabilitiesService, {} as IConnectionProfile));
});
}); });