ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove async keyword from abstract functions (#14150)

Browse Source
This commit is contained in:
Charles Gagnon
2021-02-03 12:16:50 -08:00
committed by GitHub
parent 52a642f351
commit dcf17cc08b
8 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/agent/src/dialogs/agentDialog.ts
View File

@@ -30,9 +30,9 @@ export abstract class AgentDialog<T extends IAgentDialogData> {
return this.model.dialogMode; return this.model.dialogMode;
} }
protected abstract async updateModel(): Promise<void>; protected abstract updateModel(): Promise<void>;
protected abstract async initializeDialog(dialog: azdata.window.Dialog): Promise<void>; protected abstract initializeDialog(dialog: azdata.window.Dialog): Promise<void>;
public async openDialog(dialogName?: string) { public async openDialog(dialogName?: string) {
if (!this._isOpen) { if (!this._isOpen) {

2
extensions/arc/src/ui/components/dashboard.ts
View File

@@ -24,5 +24,5 @@ export abstract class Dashboard {
return dashboard; return dashboard;
} }
protected abstract async registerTabs(modelView: azdata.ModelView): Promise<(azdata.DashboardTab | azdata.DashboardTabGroup)[]>; protected abstract registerTabs(modelView: azdata.ModelView): Promise<(azdata.DashboardTab | azdata.DashboardTabGroup)[]>;
} }

2
extensions/azurecore/src/account-provider/auths/azureAuth.ts
View File

@@ -214,7 +214,7 @@ export abstract class AzureAuth implements vscode.Disposable {
protected abstract async login(tenant: Tenant, resource: Resource): Promise<{ response: OAuthTokenResponse, authComplete: Deferred<void, Error> }>; protected abstract login(tenant: Tenant, resource: Resource): Promise<{ response: OAuthTokenResponse, authComplete: Deferred<void, Error> }>;
/** /**
* Refreshes a token, if a refreshToken is passed in then we use that. If it is not passed in then we will prompt the user for consent. * Refreshes a token, if a refreshToken is passed in then we use that. If it is not passed in then we will prompt the user for consent.

2
extensions/big-data-cluster/src/bigDataCluster/tree/treeNode.ts
View File

@@ -187,7 +187,7 @@ export abstract class TreeNode {
} }
} }
public abstract async getChildren(): Promise<TreeNode[]>; public abstract getChildren(): Promise<TreeNode[]>;
public abstract getTreeItem(): vscode.TreeItem; public abstract getTreeItem(): vscode.TreeItem;
public abstract getNodeInfo(): azdata.NodeInfo; public abstract getNodeInfo(): azdata.NodeInfo;
} }

2
extensions/resource-deployment/src/ui/resourceTypeModel.ts
View File

@@ -14,7 +14,7 @@ export abstract class ResourceTypeModel extends Model {
} }
abstract initialize(): void; abstract initialize(): void;
abstract async onOk(): Promise<void>; abstract onOk(): Promise<void>;
abstract onCancel(): void; abstract onCancel(): void;
/** /**
* performs the script generation and returns true if script was generated successfully * performs the script generation and returns true if script was generated successfully

2
extensions/sql-assessment/src/tabs/sqlAssessmentTab.ts
View File

@@ -29,7 +29,7 @@ export abstract class SqlAssessmentTab implements azdata.Tab, vscode.Disposable
return this; return this;
} }
abstract async tabContent(view: azdata.ModelView): Promise<azdata.Component>; abstract tabContent(view: azdata.ModelView): Promise<azdata.Component>;
} }

2
extensions/sql-migration/src/dialog/assessmentResults/model/assessmentDialogComponent.ts
View File

@@ -7,5 +7,5 @@ import * as azdata from 'azdata';
export abstract class AssessmentDialogComponent { export abstract class AssessmentDialogComponent {
abstract async createComponent(view: azdata.ModelView): Promise<azdata.Component>; abstract createComponent(view: azdata.ModelView): Promise<azdata.Component>;
} }

8
extensions/sql-migration/src/models/migrationWizardPage.ts
View File

@@ -27,14 +27,14 @@ export abstract class MigrationWizardPage {
}); });
} }
protected abstract async registerContent(view: azdata.ModelView): Promise<void>; protected abstract registerContent(view: azdata.ModelView): Promise<void>;
public getwizardPage(): azdata.window.WizardPage { public getwizardPage(): azdata.window.WizardPage {
return this.wizardPage; return this.wizardPage;
} }
public abstract async onPageEnter(): Promise<void>; public abstract onPageEnter(): Promise<void>;
public abstract async onPageLeave(): Promise<void>; public abstract onPageLeave(): Promise<void>;
private readonly stateChanges: (() => Promise<void>)[] = []; private readonly stateChanges: (() => Promise<void>)[] = [];
protected async onStateChangeEvent(e: StateChangeEvent) { protected async onStateChangeEvent(e: StateChangeEvent) {
@@ -66,7 +66,7 @@ export abstract class MigrationWizardPage {
this.queueActive = false; this.queueActive = false;
} }
protected abstract async handleStateChange(e: StateChangeEvent): Promise<void>; protected abstract handleStateChange(e: StateChangeEvent): Promise<void>;
public canEnter(): Promise<boolean> { public canEnter(): Promise<boolean> {
return Promise.resolve(true); return Promise.resolve(true);