Commit Graph

208 Commits

Author SHA1 Message Date
Charles Gagnon
e8d02dbc44 Cleanup typings from vs code merge (#14267) 2021-02-11 22:18:03 -08:00
Charles Gagnon
45adb7d8d7 Add ability to pass in initial variable values to deployment wizards (#14224) 2021-02-10 13:55:16 -08:00
Karl Burtram
ce612a3d96 Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79 (#14050)
* Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79

* Fix breaks

* Extension management fixes

* Fix breaks in windows bundling

* Fix/skip failing tests

* Update distro

* Add clear to nuget.config

* Add hygiene task

* Bump distro

* Fix hygiene issue

* Add build to hygiene exclusion

* Update distro

* Update hygiene

* Hygiene exclusions

* Update tsconfig

* Bump distro for server breaks

* Update build config

* Update darwin path

* Add done calls to notebook tests

* Skip failing tests

* Disable smoke tests
2021-02-09 16:15:05 -08:00
Charles Gagnon
13255f845b Update azdata-test to official Microsoft org version (#14203) 2021-02-09 08:35:47 -08:00
Alan Ren
a3cddbc8aa align with portal button style (#14187)
* align with portal button style

* fix welcome page

* image button

* more fixes

* use withProperties

* add comment back

* add border radius
2021-02-08 15:12:54 -08:00
Aasim Khan
1944813c4a Adding help text for resourceTypes (#14166)
* Adding help text to arc resource deployment.

* Fixing null help text and agreement logic

* Made some types optional
Fixed a language specific link
2021-02-04 23:45:29 -08:00
Charles Gagnon
dcf17cc08b Remove async keyword from abstract functions (#14150) 2021-02-03 12:16:50 -08:00
Charles Gagnon
2f49513bae Rename name field of resourceSubType to resourceName (#14103)
* Rename name field of resourceSubType to resourceName

* update comment

* bump arc version
2021-02-01 13:04:05 -08:00
Charles Gagnon
927e435aea Fix deployment wizard for filtered options (#14114) 2021-01-29 13:20:19 -08:00
Aasim Khan
90b33b256d Fixing the null check for agreements (#14111) 2021-01-29 11:34:16 -08:00
Charles Gagnon
db845754c6 Add resource deployment filtering by option values (#14101)
* Add resource deployment filtering by option values

* Fix compile error
2021-01-28 17:19:08 -08:00
Charles Gagnon
8677ffc68c Fix deployment wizard to not close when cancelling out of password prompt (#14083) 2021-01-28 09:00:46 -08:00
Aasim Khan
14cf6add73 Added SQL MI tile and sub resource types to resource deployment (#14043)
* Made azure arc as resourcesubtype
Added new azure arc resource type
Added support for different eula statement for different subtypes
Consolidated getSelectedOption

* Fixed some PR based comments

* Fixed more pr comments

* Fixed the error in unit test by deep copying extension resourceTypes (to keep the original one intact)

* Fixed property name 'agreement' to 'agreements'

* Cloning subresourceTypes
2021-01-27 22:06:53 -08:00
Charles Gagnon
d828a1f042 Fix stringify error from resource deployment extension (#14059)
* Fix stringify error from resource deployment extension

* add comment
2021-01-26 12:00:05 -08:00
Arvind Ranasaria
cf7c506d75 populate drop down options values from options source (#13870) 2020-12-23 19:13:27 -08:00
Aasim Khan
0b00533f99 Added fix for the infinite page refresh in resource Deployment tools page (#13813)
* Added fixed for the infinite loop in resource Deployment tools page
Generating events for select boxes only when the select box value is changed.

* Fixed the check logic in select method

* Reverted to old code and fixed some bugs

* Fixed event generation check logic
2020-12-18 10:06:12 -08:00
Charles Gagnon
7f38e87ef3 Use azdata-test modelview stubs (#13818) 2020-12-16 16:28:02 -08:00
Aasim Khan
dcb6cddab4 Fixed the stray validation error message in Resource Deployment wizard (#13747)
* Fixed the stray validation error message

* Removed not working ' with validation
Adding back cancel button disabling
2020-12-16 10:32:51 -08:00
Charles Gagnon
4575f2bbe6 Fix paths for tests (#13816) 2020-12-15 16:04:36 -08:00
Charles Gagnon
dc8788b77f Add loading text properties for option sources (#13743)
* Add loading text to deployment radio options

* Fix loading race condition

* Update text
2020-12-09 18:32:05 -08:00
Charles Gagnon
e7884b8b61 Make loading components not valid and improve RD radio group (#13738) 2020-12-09 13:15:35 -08:00
Charles Gagnon
97a4de4111 Have resource deployment providers return disposables (#13690)
* Add dependent field provider to resource deployment

* Change name to value provider service

* Add error handling

* providerId -> id

* Set dropdown value correctly

* missed id

* back to providerId

* fix updating missed id

* Make resource deployment providers disposable
2020-12-07 10:27:37 -08:00
Charles Gagnon
a70dce7855 Add dependent field provider to resource deployment (#13664)
* Add dependent field provider to resource deployment

* Change name to value provider service

* Add error handling

* providerId -> id

* Set dropdown value correctly

* missed id

* back to providerId

* fix updating missed id

* remove placeholder
2020-12-04 17:21:30 -08:00
Charles Gagnon
aeb22011d2 Remove placeholder on deployment wizards when field is disabled dynamically (#13658) 2020-12-04 09:25:56 -08:00
Charles Gagnon
3d82074656 Remove debug console log (#13669) 2020-12-04 09:25:44 -08:00
Charles Gagnon
6dc07e5804 Add test for dynamic enablement (#13602)
* Add test for dynamic enablement

* update names
2020-12-04 09:15:34 -08:00
Arvind Ranasaria
8027993ab4 Make 'Script to notebook' consistent with 'Deploy' when user cancels during password re-acquisition for controller (#13557) 2020-12-01 22:57:00 -08:00
Charles Gagnon
b03a914934 Update required icon for labels for dynamic enablement (#13515) 2020-11-24 15:05:29 -08:00
Charles Gagnon
84822b23ac Fix BDC Deployment table (#13538)
* Fix BDC Deployment table

* fix mappings

* Fix names
2020-11-24 14:28:19 -08:00
Charles Gagnon
145b2491df Cleanup Resource Deployment ModelView (#13510) 2020-11-20 18:29:00 -08:00
Charles Gagnon
172a044ba7 Remove inputValueTransformer and getInputComponentValue (#13502) 2020-11-20 10:51:00 -08:00
Charles Gagnon
175d46d508 Add support for dynamic enablement of resource deployment components (#13464)
* saving wip to merge main

* temp fixes for textValidation* removal

* save wip to switch tasks

* save wip to switch tasks

* save wip to switch tasks

* code complete - with known bugs

* missed test file

* fix extHostModelView changes

* validation module

* missed test changes

* missed change

* pr feedback

* pr feedback

* revert inadvertent change

* remove unneeded change

* merge from bug/12082-2

* pr feedback

* pr feedback

* bdd -> tdd for validation tests

* bdd -> tdd for validation tests

* pr feedback

* remove unneeded file

* pr feedback

* EOL instead of '\n'

* pr feedback

* pr feedback

* minor fixes.

* pr feedback

* fix comment

* comments and var renames

* test fixes

* working version after validation simplification

* working version after validation simplification

* remove inadvertent change

* simplified validations

* undo uneeded change

* cleanup

* working version after latest merge

* comments and whitespace fixes

* remove is_integer checks

* sentence case field validation messages

* Use generic strings in sample fields

* minor fixes to sample extension strings

* spaces to tabs for indentation

* request fields before limit fields

* reaarange request/limit fields

* is_integer checks for PG Server Group number fields

* Thenable to Promise

* InputBoxInfo

* pr feedback

* pr feedback

* isUndefinedOrEmpty to utils

* include asde package.json

* use ValidationValueType

* ValidationValueType -> InputValueType

* Add support for dynamic enablement of resource deployment components

* use instanceof function

* getValue returns InputValueType

Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
2020-11-19 16:23:28 -08:00
Arvind Ranasaria
c7cca5afea Improved Validations for ARC Wizards (#12945) 2020-11-18 22:03:59 -08:00
Aasim Khan
438bc67072 Fixed the generate script logic for notebook wizards. (#13418)
* Fixed the generate script logic for notebook wizards.

* -reverted previous changes
-added last page check to the page validation change logic.

* checking if the page is valid when entering it.

* removing unnecessary index variable in forEach loop

* added comments for generate script button enabling on notebookwizard page.
2020-11-17 10:26:45 -08:00
Arvind Ranasaria
39e1181c5d Remove WizardBase.ts (#13350) 2020-11-16 19:21:26 -08:00
Arvind Ranasaria
b3d99117ca onComplete -> onLeave for toolsAndEulaPage (#13394) 2020-11-13 09:59:08 -08:00
Aasim Khan
6c920f6d54 Fixed the table width so it does not overflow from the wizard. (#13372) 2020-11-12 15:06:03 -08:00
Arvind Ranasaria
d7a6b55f82 Hook up generateScriptButton to lastPageValidation (#13339) 2020-11-10 13:16:25 -08:00
Aasim Khan
1c9322c0e8 Fixes for incorrect button labels and the password validation error. (#13333) 2020-11-10 09:05:28 -08:00
Aasim Khan
712c6ae5d8 Adding tools and Eula page to Resource Deployment (#13182)
* SQL VM wizard migration to ResourceType Wizard

* Revert "SQL VM wizard migration to ResourceType Wizard"

This reverts commit e58cd47707a7e2812be20d915f1fe638b96b035f.

* migrated notebook wizard

* SQL VM wizard migration to ResourceType Wizard

* Fixed some imports on SQL VM wizard

* migrated sqldb wizard to generic ResourceTypeWizard

* Added missing import
Solving errors from the merge

* Moved some common functionality into ResourceTypeWizard

* Changed logic of start deployment

* fixed some import after changing files.

* added pagelss model and tools and Eula Page

* Hacky solution to fix wizard update bugs

* Removed tools and Eula components from resourceTypePickerDialog

* Removing changes in ext host

* reverting every change in ext host dialog

* Fixed setting the first provider for resourceTypeWizard.

* Some PR related changes
-Fixed typo in localized constants
-made some code logic concise
-Removed unnecessary check in tools&Eula

* Added some fixes for compilation error

* some refactoring for PRs

* moved comment

* cleaning up some code to make it more readable

* fixed comment typo

* Some additional cleaning up of code.

* Adding a public getter for model

* -Adding error message for failed EULA validation
-Removed unnecessary check for selected resource.

* Added comment to explain model variable behavior

* Added additional comments

* Fixed a comment to make it accurate

* Better phrasing for a comment
2020-11-06 13:05:41 -08:00
Arvind Ranasaria
3ec1f7cc2b Kube Service tests (#13183) 2020-11-03 15:46:31 -08:00
Arvind Ranasaria
b175c97dfe Notebook Service tests (#13181) 2020-11-03 14:16:11 -08:00
Arvind Ranasaria
f10ac10f6d platformService tests and move tests from tdd to bdd (#13131) 2020-11-03 13:34:33 -08:00
Aasim Khan
4f96ac46be Migrating other deployment wizards to the generic ResourceTypeWizard (#13132)
* SQL VM wizard migration to ResourceType Wizard

* Revert "SQL VM wizard migration to ResourceType Wizard"

This reverts commit e58cd47707a7e2812be20d915f1fe638b96b035f.

* migrated notebook wizard

* SQL VM wizard migration to ResourceType Wizard

* Fixed some imports on SQL VM wizard

* migrated sqldb wizard to generic ResourceTypeWizard

* Added missing import
Solving errors from the merge

* Moved some common functionality into ResourceTypeWizard

* Changed logic of start deployment

* fixed some import after changing files.
2020-10-30 12:42:20 -07:00
Aasim Khan
e15ad17967 Aasim/fix/sqldbtypos (#13130)
* fixed some easy typos on sql db wizard.

* Fixed some instructions in the notebook

* - Added option to enable or disable firewall rules

* converted toggle firewall dropdown to checkbox
2020-10-29 11:53:56 -07:00
Aasim Khan
dd77c79090 Refactoring Deploy Cluster to use the a generic Wizard (#13105)
* Refactoring Deploy Cluster to use the generic ResourceTypeWizard

* - Remove unnecessary error message
- Fixed spacing
- Fixed onCancel method implementation in deploy cluster
2020-10-28 20:47:27 -07:00
Charles Gagnon
2db51ca243 Allow string for deployment icons and update a couple (#13076)
* Update to colorized versions of bdc and container deployment icons

* update edge

* Allow string for icons
2020-10-26 13:27:12 -07:00
Arvind Ranasaria
2bc2f7f520 New Validation Module for Resource Deployment Extension (#13075) 2020-10-26 11:41:04 -07:00
Arvind Ranasaria
1c6d7866e8 Revert "New Validation Module for Resource-Deployment extension. (#12953)" (#13074)
quick revert of a merge done from PR too soon. Will merge it again later.
2020-10-26 10:03:37 -07:00
Arvind Ranasaria
c810c5a0bb New Validation Module for Resource-Deployment extension. (#12953) 2020-10-26 09:50:25 -07:00