Commit Graph

337 Commits

Author SHA1 Message Date
Daniel Grajeda
08acd6aadc Notebook Views grid fixes (#17170) 2021-09-28 14:52:00 -07:00
Vasu Bhog
db1d3cc517 Markdown Horizontal Scrollbar Fix (#17083)
* dynamically change horizontal scrollbar

* working horizontal scrollbar

* created new event to handle both scrollbar and mouse wheel

* only show scrollbar when needed
2021-09-27 16:54:43 -07:00
Daniel Grajeda
4a715e473a Add guids to RunAll and RunCell events (#17123)
Add guids to RunAll and RunCell events
2021-09-21 20:56:46 -07:00
Charles Gagnon
8d3b57cb76 Add no-cond-assign rule (#17039) 2021-09-09 16:23:18 -07:00
Chris LaFreniere
d32f25425b Use updated markdown renderer from vscode (#16988) 2021-09-03 10:43:25 -07:00
Chris LaFreniere
b27bdb0027 Add tooltip for WYSIWYG callout link (#16967) 2021-09-01 17:24:06 -07:00
Daniel Grajeda
e02ae0865a Notebook Views Insert Cells Modal (#16836)
* Add html-to-image package

* Add image card type
2021-08-31 13:11:21 -07:00
Vasu Bhog
529e4fe0de Fix ADS Web notebook cross linking (#16926)
* fix cross linking files

* use host location instead
2021-08-30 15:43:16 -07:00
Lucy Zhang
ea5f9091d1 add horizontal scroll bar to output (#16918) 2021-08-27 11:42:02 -07:00
Charles Gagnon
0aede16aaa Fix duplicate editor windows on reload (#16893) 2021-08-25 20:07:58 -07:00
Cory Rivera
cb7b7da0a4 Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569) 2021-08-25 16:28:29 -07:00
Charles Gagnon
fe1f8fb2f3 Add setting for enabling using new markdown renderer (#16864)
* Add setting for enabling using new markdown renderer

* Use const

* Fix circular dependency

* Default setting to false
2021-08-25 12:43:32 -07:00
Daniel Grajeda
ed280cb003 Add html-to-image library (#16845)
For use by the Notebook Views insert cells modal
2021-08-20 17:18:23 -07:00
Daniel Grajeda
640c6f30f4 Notebook views UI 2 (#15865)
Provide access to the Notebook Views UI. Feature is hidden behind a feature flag.

Co-authored-by: rkselfhost <rkselfhost@outlook.com>
2021-08-17 14:15:28 -07:00
Daniel Grajeda
10ee4f2d7c Notebook Views Actions fix for ADS Web (#16707) 2021-08-11 13:19:02 -07:00
Lucy Zhang
9f761c44c4 Add incremental grid loading option to notebooks (#16577)
* render grids incrementally

* add loading spinner

* fix loading animation

* move rendergrids to notebook editor component

* add setting for incremental grid loading

* check configuration

* just use setTimeout to queue grids

* remove extra line

* add setter/getter for isloading

* add comment
2021-08-05 13:44:26 -07:00
Daniel Grajeda
0567141bc4 Notebook Views Actions (#16207)
This adds the actions currently needed by the views
2021-08-03 22:52:27 -07:00
Daniel Grajeda
e2dd257fa9 Add Notebook Views dropdown (#16228)
This adds the entry point to NVs. It is currently hidden behind a feature flag, which can be enabled in the settings.
2021-08-03 21:15:11 -07:00
Vasu Bhog
179678b495 Refactor Notebook Link Handling (#16473)
* add keep absolute paths instead convert setting

* update tests/config

* refactor links in NotebookLinkHandler
2021-07-30 19:20:38 -07:00
Vasu Bhog
788c84a1ee fix email else condition (#16491) 2021-07-29 18:37:06 -07:00
Cory Rivera
63a65f5821 Remove quotes from inserted markdown links (#16457) 2021-07-27 16:40:20 -07:00
Charles Gagnon
2d8e0d648a Fix SQL/Notebook editors opening as plaintext (#16442)
* Register overrides at startup

* Always wait for extensions

* Fix compile errors
2021-07-27 13:46:16 -07:00
Vasu Bhog
151522013f Notebook Markdown email rendering fix (#16417)
* fix email WYSIWYG rendering
2021-07-23 15:24:34 -07:00
Charles Gagnon
66c62fcce3 Fix relative path check in HtmlMarkdownConverter (#16192) 2021-07-23 12:33:45 -07:00
Daniel Grajeda
fd954ddcb2 Plotly output resize (#16313)
Allow plotly to resize based on the size of the output itself, not only when the window is resized. This allows cells in Notebook Views to adjust based on  resize.
2021-07-21 21:06:26 -07:00
Daniel Grajeda
c5c7ca019d Notebook Views autodash feature (#16238)
The autodash feature in notebook views creates an initial grid layout for users when a view is created. It is intended to reduce the effort required by the user to start editing their view. Instead of displaying every cell and stacking them vertically like the default notebook layout, we use guidelines to determine which cells are worth displaying and how to arrange them.
2021-07-21 20:46:58 -07:00
Barbara Valdez
f17689319c Revert to previous markdown renderer (#16246)
* Add marked files under sql/base/common
2021-07-16 17:51:53 -07:00
Vasu Bhog
63e97caa94 Fix Windows WYSIWYG linking issue (switching to splitview and resolving links in WYSIWYG) (#16133)
* fix relative links not correctly formatted due to marked js

* logic in one place
2021-07-16 13:27:45 -07:00
Charles Gagnon
8faa0cf0e2 Update compile pipeline and fix eslint (#16129)
* Update pipelines

* eslint

* Fix layering

* update tsec exemption
2021-07-14 14:43:23 -07:00
Vasu Bhog
27823e9900 Fix CalloutDialog not opening after bad link (#16051)
* fix null parentNode
2021-07-09 09:01:48 -07:00
Charles Gagnon
8f202d91b6 editorReplacer -> editorOverride (#16041)
* editorReplacer -> editorOverride

* Update lifecycle phsae

* add back input factories

* Add comment

* add back tests

* comments

* fix log

* comments
2021-07-09 08:46:50 -07:00
Alan Ren
c5893a488f toolbar separator overlapping with other items (#16012)
* separator overlapping with other items

* Update notebook.css
2021-07-07 14:44:41 -07:00
Lucy Zhang
f8c4d332bb add height css (#16026) 2021-07-07 13:49:33 -07:00
Lucy Zhang
9ba4057a3c fix notebook icon highlights (#16009) 2021-07-06 17:50:54 -07:00
Lucy Zhang
9ac1f16cea Fix notebook toolbar when ADS screen width is decreased (#15987)
* fix toolbar when width is decreased

* remove height css
2021-07-06 11:45:46 -07:00
Barbara Valdez
0e10e3e3ca fix WYSIWYG toolbar (#15901)
* fix WYSIWYG toolbar

* add height

* remove new rule and specify css selectors
2021-06-30 17:28:11 -07:00
Lucy Zhang
189fe762a9 remove layout call in output component init (#15905) 2021-06-28 14:48:44 -07:00
Chris LaFreniere
f7a723d98d Notebooks A11Y: Add button role for Placeholder Links (#15851)
* Add button role

* Add aria-label

* localize aria label
2021-06-23 16:48:01 -07:00
Maddy
90b90afeab remove images from metadata on source update (#15640)
* remove images from metadata on update

* update comment

* reset only on html update

* add comment

* fixes

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2021-06-21 13:55:37 -07:00
Alan Ren
03f31a865a use more specific css selectors (#15826) 2021-06-18 18:33:25 -07:00
Cory Rivera
d92c1d5ca8 Add max size setting for Rich Text undo history in notebooks. (#15793) 2021-06-18 16:04:45 -07:00
Chris LaFreniere
06e7d4d489 Let parent control width for text cell preview (#15800) 2021-06-18 12:51:58 -07:00
Charles Gagnon
d96835c083 Fix secondary actions for Notebook editor toolbar (#15788) 2021-06-17 14:52:36 -07:00
Charles Gagnon
3cb2f552a6 Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>
2021-06-17 08:17:11 -07:00
Charles Gagnon
db3a0ef7ac Trim pathname for link callout file paths (#15716)
* Don't use pathname for link URLs

* Trim pathname instead
2021-06-15 09:52:27 -07:00
Cory Rivera
a61462a2c0 Improve Undo and Redo functionality for notebook Rich Text editors (#15627) 2021-06-08 13:24:58 -07:00
Maddy
d04451985c Highlight all matches in Notebook on Find (#15562)
* iterate over every cell and highlight ranges.

* fix yellow for all matches and orange for current

* fix

* avoid duplicate deltaDecorations call

* initialize on declare
2021-06-04 15:45:51 -07:00
Maddy
b490d53284 Add image as attachment on copy/paste into cell (#15602)
* add pasted image as attachment

* handle duplicate image logic

* replace with regex

* address PR comments
2021-06-04 15:20:18 -07:00
Maddy
ed7521e846 flex style in split mode (#15612) 2021-06-03 11:27:48 -07:00
Vasu Bhog
1de05a2339 Fix WYWIWYG Table cell adding new line in table cell (#15594)
* fixes new line in table cell

* add test and fix for table head
2021-05-28 13:47:50 -07:00