Barbara Valdez
275a772496
Reimplement drag and drop with the new interface ( #21037 )
...
* re enable drag and drop in book tree view
2022-10-31 10:12:23 -07:00
Karl Burtram
8a3d08f0de
Merge vscode 1.67 ( #20883 )
...
* Fix initial build breaks from 1.67 merge (#2514 )
* Update yarn lock files
* Update build scripts
* Fix tsconfig
* Build breaks
* WIP
* Update yarn lock files
* Misc breaks
* Updates to package.json
* Breaks
* Update yarn
* Fix breaks
* Breaks
* Build breaks
* Breaks
* Breaks
* Breaks
* Breaks
* Breaks
* Missing file
* Breaks
* Breaks
* Breaks
* Breaks
* Breaks
* Fix several runtime breaks (#2515 )
* Missing files
* Runtime breaks
* Fix proxy ordering issue
* Remove commented code
* Fix breaks with opening query editor
* Fix post merge break
* Updates related to setup build and other breaks (#2516 )
* Fix bundle build issues
* Update distro
* Fix distro merge and update build JS files
* Disable pipeline steps
* Remove stats call
* Update license name
* Make new RPM dependencies a warning
* Fix extension manager version checks
* Update JS file
* Fix a few runtime breaks
* Fixes
* Fix runtime issues
* Fix build breaks
* Update notebook tests (part 1)
* Fix broken tests
* Linting errors
* Fix hygiene
* Disable lint rules
* Bump distro
* Turn off smoke tests
* Disable integration tests
* Remove failing "activate" test
* Remove failed test assertion
* Disable other broken test
* Disable query history tests
* Disable extension unit tests
* Disable failing tasks
2022-10-19 19:13:18 -07:00
Barbara Valdez
46a7fbd313
Fix unpin notebook ( #20393 )
...
* convert uri to vscode uri
2022-08-17 15:29:25 -07:00
Barbara Valdez
2119c96c88
Update pin/unpin icon after pinning notebook ( #20273 )
2022-08-12 14:59:07 -07:00
Lucy Zhang
b8435a67df
Add telemetry for Python on Jupyter server startup ( #19970 )
...
* add telemetry for python on jupyter server startup
* remove extra lines
2022-07-11 12:20:22 -07:00
Chris LaFreniere
4f2a430c77
Fix Uncalled Function ( #19819 )
2022-06-23 17:14:39 -07:00
Chris LaFreniere
1b1117f07d
Attempt to Fix Unstable Notebooks Tests ( #19806 )
...
* Add check if currentBook exists
* adding checks for currentBook
2022-06-23 17:14:15 -07:00
Barbara Valdez
683d906138
Create directory when adding a book section from book tree view ( #18966 )
...
* create folder when creating a book section
* fix test
2022-04-07 16:19:33 -07:00
Charles Gagnon
1c9ba64ee0
check-param-names ( #18189 )
2022-01-31 12:39:22 -08:00
Maddy
4012f26976
fix the endless loop scenario that breaks tree scroll ( #17971 )
...
* fix the endless loop scenario
* add comments
2022-01-21 17:43:37 -08:00
Maddy
a05be3912e
add path.posix while reading relative paths ( #17326 )
...
* path.posix
* add test for nested folders scenario
* update message and remove the redundant check
2021-10-21 12:47:01 -07:00
Barbara Valdez
9a38578c54
Edit books using dnd fix ( #17141 )
...
* add hierarchyId to tree element
2021-09-29 19:33:36 -07:00
Barbara Valdez
ce13d01efb
Book Editing: Support adding new sections to a book ( #17074 )
...
* add a new section command
2021-09-14 11:31:43 -07:00
Barbara Valdez
08eee69bbc
only modify toc and move files if the target is a section or book ( #17054 )
2021-09-13 10:15:30 -07:00
Barbara Valdez
bb3ccb92a4
Edit book using drag and drop ( #16906 )
...
- Use the onDrop method for moving notebooks/sections in the Notebooks Tree View.
- Allow multi selection in tree view
- Modify notebook commands to only show when a single tree item is selected.
2021-09-02 11:07:03 -07:00
Charles Gagnon
76e01fee60
Fix rest of notebook unhandled promises ( #16933 )
...
* Fix rest of notebook unhandled promises
* add rule
* fix some tests
2021-08-30 14:14:48 -07:00
Charles Gagnon
7804c87c87
Fix some unhandled promise lint errors ( #16924 )
2021-08-30 09:08:28 -07:00
Barbara Valdez
8aa0dffccf
Remove circular reference from book tree item ( #16579 )
...
* Enable drag and drop and multiple selection in Book Tree View
* replace children for hasChildren to remove circular reference
2021-08-18 10:37:54 -07:00
Barbara Valdez
6df69f525c
Add conditional operator before checking length ( #16180 )
...
* add optional op to sections
* remove check for undefined
2021-07-16 11:38:18 -07:00
Barbara Valdez
f7fc145b0c
Set notebook path before moving. ( #16055 )
...
* set the original path when moving a single notebook
* save original file path before attempting to move in case of error_
)
2021-07-12 10:32:15 -07:00
Barbara Valdez
74cfac39d2
Fix book toc manager tests ( #16034 )
...
* fix book toc manager tests
* add js-yaml to notebooks package.json
2021-07-08 11:51:08 -07:00
Charles Gagnon
3cb2f552a6
Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 ( #15681 )
...
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898
* Fixes and cleanup
* Distro
* Fix hygiene yarn
* delete no yarn lock changes file
* Fix hygiene
* Fix layer check
* Fix CI
* Skip lib checks
* Remove tests deleted in vs code
* Fix tests
* Distro
* Fix tests and add removed extension point
* Skip failing notebook tests for now
* Disable broken tests and cleanup build folder
* Update yarn.lock and fix smoke tests
* Bump sqlite
* fix contributed actions and file spacing
* Fix user data path
* Update yarn.locks
Co-authored-by: ADS Merger <karlb@microsoft.com >
2021-06-17 08:17:11 -07:00
Barbara Valdez
aef6511ba6
Show book's notebook TOC title in pinned notebooks view ( #15583 )
...
* Show notebook title in pinned notebooks view
* fix test
* change interface name
2021-05-27 14:09:51 -07:00
Barbara Valdez
558dfd693c
Notebooks View: Do not recenter view when selecting a notebook that is visible ( #15442 )
...
* do not focus element when tree item is visible
* reset reveal behavior
* add comment
2021-05-13 10:19:19 -07:00
Maddy
6d95b113d5
fix the logic to check the same level folders ( #15143 )
2021-04-16 11:35:51 -07:00
Charles Gagnon
42cd650147
Only reveal parent node when finding notebook item ( #15091 )
2021-04-12 13:12:04 -07:00
Maddy
7484b04158
Select active notebook in viewlet when opened from command pallet ( #15027 )
...
* await initialized
* fixes specific for windows
* address comments
* update comment
2021-04-08 15:27:33 -07:00
Maddy
43db30d1da
Add more Notebook telemetry events ( #14755 )
...
* initial checkin
* telemetry for search in notebooks
* telemetry for move notebook
* address comments
* feedback changes
* fix tests paasing NullAdsTelemetryService
* move changeKernel telemetry higher up
* remove telemetry service
* Fix new Notebook events (#14982 )
* Notebook telemetry fixes
* update2
* Move event location
* remove service
* remove unused
Co-authored-by: chgagnon <chgagnon@microsoft.com >
2021-04-05 16:08:39 -07:00
Maddy
13ad4c9497
Select notebook in viewlet when opened in editor ( #14854 )
...
* test changes
* code clean up
* remove extra line
* remove commented code
* remove unnecessary import
* update expand logic
* implement parent,children on bookitem
* merge conflicts
* refactor code
* fix trustBook test
* typo on condition
* feedback
* indexOf to include
* fix undefined error on expand
* remove set parent
* revert getTreeItem logic
* Fix duplicated nodes
* remove debug
* Clean up logic
* Fix tests
* Fix logic
* cleanup
* Cleanup findAndExpandParentNode (#14960 )
Co-authored-by: chgagnon <chgagnon@microsoft.com >
2021-04-02 19:33:41 -07:00
Barbara Valdez
fde5caa9a4
Add documentation and fix paths ( #14948 )
...
* use posix relative path
* add doc link in dialog
* rename book to Jupyter book
2021-04-02 15:44:25 -07:00
Barbara Valdez
a00ffa0469
fix search action ( #14937 )
...
* fix search action
* remove book version from book tree item
2021-04-01 11:16:32 -07:00
Barbara Valdez
8aa222d1c8
Add new file UI ( #14773 )
...
Adds a notebook or markdown file to a book's top level or a section by right click on Book Tree View
2021-03-30 18:44:52 -07:00
Barbara Valdez
784d76b886
Remove book notebook from toc ( #14704 )
...
* Add remove notebook from book
2021-03-16 15:02:29 -07:00
Barbara Valdez
4b462a41ab
Queue concurrent calls when initializing contents in BookModel ( #14586 )
...
* Initial work for handling concurrent operations when calling initialized books
* fixes to init contents
* create a queue of deferred promises for initializing books
* resolve active promise and set to undefined
* remove duplicated variable
* address pr comments
2021-03-09 10:19:30 -08:00
Barbara Valdez
a17a4a585e
[Editing Books] - Refactor buildToc method ( #14532 )
...
* refactor buildToc method to only modify the section found and return a boolean
* fix tests
* Address pr comments
2021-03-05 11:41:31 -08:00
Barbara Valdez
3f0ca8b714
Create book dialog improvements ( #14429 )
...
* add improvements TODO on creating book experience
* fix create book to support a more complex folder structure
* replace \\ to a forward slash on windows
* address pr comments
* fix tests
* use the posix version of path.sep
2021-03-02 21:23:28 -08:00
Barbara Valdez
3d5ff25d13
Fix debounce issue when book toc is updated ( #14392 )
...
* pass function to debounce
* remove debounce decorator and move watch methods to bookmodel
* Move the vscode tree change data event to book model
* address pr comments
* fix book tests
2021-02-24 14:24:50 -08:00
Barbara Valdez
5ece9b968a
Create book UI ( #14210 )
...
* Add dialog for creating books
* create empty book
* add localized constants
* add validation to dialog
* reset the create book command to original
* address pr comments
* change error message
* Init book toc manager in bookTreeView
2021-02-22 13:29:09 -08:00
Barbara Valdez
0f748a60b3
Fix not numbered inconsistency ( #14269 )
...
* fix not numbered field
* fix for adding extra field and removing it from sections
* use const for variable
* use spread operator to create new object
* address pr comments
* change function name and simplify
* Add comment and put the initializeContents in the finally block
2021-02-12 19:17:22 -08:00
Barbara Valdez
75cda19504
Add await to refresh book method ( #14236 )
...
* add await to refresh book method
* change name of method
* Reload tree view
* address pr comments
* adding finally on finally
2021-02-11 21:57:53 -08:00
Karl Burtram
ce612a3d96
Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79 ( #14050 )
...
* Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79
* Fix breaks
* Extension management fixes
* Fix breaks in windows bundling
* Fix/skip failing tests
* Update distro
* Add clear to nuget.config
* Add hygiene task
* Bump distro
* Fix hygiene issue
* Add build to hygiene exclusion
* Update distro
* Update hygiene
* Hygiene exclusions
* Update tsconfig
* Bump distro for server breaks
* Update build config
* Update darwin path
* Add done calls to notebook tests
* Skip failing tests
* Disable smoke tests
2021-02-09 16:15:05 -08:00
Barbara Valdez
06bace1fcf
replace backlash when moving notebooks on windows ( #14186 )
2021-02-07 20:17:30 -08:00
Barbara Valdez
467a34e878
Fix book editing issues ( #14177 )
...
* Fix issue moving a duplicated section to another book
2021-02-05 18:50:29 -08:00
Barbara Valdez
3c4ffd2a9c
Fix book tests on Windows. ( #14173 )
...
* fix tests
* fix reveal active item test
* show error message
* revert trusted book test back to original
2021-02-05 10:45:59 -08:00
Barbara Valdez
cce8a961ac
Fix decorations for modified notebooks in Books View ( #14152 )
...
* Tree item resource uri should be the root when it's a book and notebook path for notebooks
2021-02-03 18:17:08 -08:00
Barbara Valdez
9ac180d772
Editing Books ( #13535 )
...
* start work on ui
* Move notebooks complete
* Simplify version handling
* fix issues with add section method
* fix issues with the edit experience and add the quick pick for editing
* add version handler for re-writing tocs
* fix book toc manager tests
* add notebook test
* fix localize constant
* normalize paths on windows
* check that a section has sections before attempting to mve files
* Implement method for renaming duplicated files
* moving last notebook from section converts the section into notebook
* Add recovery method restore original state of file system
* Add clean up, for files that are copied instead of renamed
* remove dir complexity
* divide edit book in methods for easier testing and remove promise chain
* Keep structure of toc
* normalize paths on windows
* fix external link
* Add other fields for versions
* fix paths in uri of findSection
* add section to section test
* Add error messages
* address pr comments and add tests
* check that the new path of a notebook is different from the original path before deleting
2021-02-02 20:39:11 -08:00
Barbara Valdez
fa150fbe67
Initialize releases when creating remoteBookController ( #14064 )
...
* Check that releases if not undefined
* Initialize model with empty releases
2021-01-27 15:17:32 -08:00
Maddy
5be2e01632
Notebook Telemetry initial changes ( #13929 )
...
* initial changes
* add ads-telemetry to nb extension
* add aiKey to notebook extension
* add run cell telemetry in cellmodel
* add NbTelemetryAction
* remove source
* remove telemtery for run notebook for now
* fix optional variable call
* addr comments
* changing the dependency package
* revert
* removed webpack config for telemetry compat
* add opentelemetry to externals
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com >
2021-01-25 09:42:37 -08:00
Barbara Valdez
9df56c5c0f
Normalize path to change ( #13660 )
2020-12-03 19:17:55 -08:00
Barbara Valdez
6f731fcd9e
add await to thenable method ( #13635 )
2020-12-02 16:14:26 -08:00
