Commit Graph

150 Commits

Author SHA1 Message Date
Charles Gagnon
726ad26a75 Trim spaces from arc connect controller dialog (#15321) 2021-05-04 08:38:06 -07:00
nasc17
7a726e5dfa Fix for PG parameters table disappearing when trying to reset a value (#15303)
* Working on table bug

* Removed unit test checking for onEngineSettingsUpdated event to fire since removed from model

* Moved instanceofcheckbox function to utils, pr fixes

* Fix comment
2021-04-30 20:50:39 -07:00
Charles Gagnon
ef57812a95 Arc april updates (#15237)
* Enables being able to view and edit Coordinator node scheduling params (#15114)

* Trying to save per role settings

* Updated spec

* Cleaning up

* Removed unneccessary code and comments

* Added separate type for { w?: string, c?: string}, PR fixes

* Added methods to refresh mr,ml,cr,cl versus per role

* Fixed spec

* Put back optional properties, removed passing empty string to reset scheduling params

* Spacing

* vBump arc

* Included roles in fake show output for testing (#15196)

* Update arc specs (#15225)

* Update azdata Arc specs to match April azdata

* vcores -> cpu

* fix spacing

* Consolidate types and update storage volumes

* Fix compile

* Update min azdata version

Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: nasc17 <nasc@microsoft.com>
2021-04-26 16:20:27 -07:00
Charles Gagnon
34c8c77dc1 Fix MIAA connection strings page showing user as undefined (#15105) 2021-04-12 18:15:56 -07:00
Charles Gagnon
febd8b29c9 Arc updates for March release (#14970)
* Updated Postgres Spec for where to find engine version, removed calling calling -ev in edit commands (#14735)

* Added spec.engine.version, took out calling engine version with edit calls

* Added text wrong place

* missed updates

* PR fix

* Update Arc Postgres troubleshooting notebook

Co-authored-by: Brian Bergeron <brberger@microsoft.com>

* Remove AzdataSession from azdata commands (#14856)

* remove session

* Add in controller-context support

* Revert "Add in controller-context support"

This reverts commit 3b39b968efbf6054041cb01cb2d8443532643a82.

* Add azdataContext to login

* Undo book change

* Undo change correctly

* Add controller context support (#14862)

* remove session

* Add in controller-context support

* Add params to fake

* Fix tests

* Add info and placeholder for controller URL/name (#14887)

* Add info and placeholder for controller URL

* add period + update name

* update memento and allow editing of namespace/URL

* vBump

* vBump

* Fix tests

Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
2021-04-05 11:47:36 -07:00
Charles Gagnon
37af88e265 Fix some spelling errors (#14944) 2021-04-01 11:16:08 -07:00
nasc17
2164bc0bb9 Unit test for Postgres Connections Strings Page (#14905)
* Start writing test (2)

* How read property pairs

* Connection strings check

* Delete folder

* PR fixes
2021-03-31 13:21:44 -07:00
nasc17
6ab9844909 Cleaning up PG Compute and Storage code and adding reset for Cores (#14919)
* Add reset ability to cores request and limit

* Remove not needed !

* Changed withProperties to with Props
2021-03-31 11:54:53 -07:00
nasc17
e080770c19 Updates how the Postgres Parameter Dashboard adds data to its table and discard values. (#14840)
* Clear updates in discard

* Update discarding values

* Changed where the info bubble is created , added function for collecting all changed components.

* Remove parameters if the same as original value  reset individually

* Moved refreshParametersTable to be private function, try catch for postgresmodel.refresh

* Discard enable if fail

* Made changedCompoenentValues a set, removed unnessaery ! throughout file, cleaned up connec and load
2021-03-26 13:59:33 -07:00
nasc17
e0f24cc268 Add try catch block to model refresh in compute/storage pages (#14861)
* Add try catch block to model refresh in compute/storage pages

* spacing
2021-03-26 08:30:42 -07:00
Charles Gagnon
72295d46c2 Add close method to ModelView dashboards (#14812)
* Add close method to ModelView dashboards

* fix closing

* remove accessors

* Update errors
2021-03-22 10:17:16 -07:00
nasc17
2086ca6039 Postgres Parameters edit calls missing try catch block (#14805)
* try catch block within save and reset functions

* pr fix

* Pr fix sessions

* Pr changes
2021-03-19 17:25:48 -07:00
Brian Bergeron
ce39b4bd19 Arc - Unit tests for deleting Postgres (#14502)
* tests for deleting postgres from overview page

* upgrade to azdata-test 1.5.0

* Fix api stubbing

Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2021-03-19 13:12:26 -07:00
Charles Gagnon
a0a97d1611 Revert "Updated Postgres Spec for where to find engine version, removed calling calling -ev in edit commands (#14735)" (#14794)
This reverts commit 318559dcd7.
2021-03-18 14:19:59 -07:00
nasc17
947633f244 Clear updates in discard (#14781) 2021-03-17 16:15:45 -07:00
Charles Gagnon
4425b2afd3 Fix MIAA connection strings page not populating (#14763) 2021-03-17 09:40:47 -07:00
nasc17
318559dcd7 Updated Postgres Spec for where to find engine version, removed calling calling -ev in edit commands (#14735)
* Added spec.engine.version, took out calling engine version with edit calls

* Added text wrong place

* missed updates

* PR fix
2021-03-16 08:25:16 -07:00
nasc17
42347b4681 Pass in empty string quotation (#14717) 2021-03-12 15:50:41 -08:00
nasc17
98828aa67d Unit test for Postgres Model (#14651)
* Figure out initial test

* First trys at refresh unit test

* refresh unit test completed

* Connection profile unit test, need to pass in false

* Engine settings start

* All passing

* Clean up

* Removed class, updated showdialog stubs, using sinon spy

* Removed comment
2021-03-12 14:02:55 -08:00
nasc17
973f151e07 Add a note that opening new support request from ADS works only after uploading configuration to the cloud/portal (#14601)
* Added note to support request page

* Fixed note
2021-03-09 15:09:21 -08:00
nasc17
dba5880f35 Postgres Resource Health Paage (#14575)
* Add podstatus to spec

* Added image to table and fixed spacing.

* Added pod status to spec

* PR fixes

* Added resource health page, created overiew box

* Pod condtion table is up

* Tryingt to fix how table refreshes

* Fixed how drop down changes table

* Overview box shows number of running and pending pods

* overview box refresh fix

* Updated summary section

* PR fixes

* Condensed create pod list function

* Added enum

* fixed refresh

* Fixed refresh, fixed if all availble section add
2021-03-08 10:05:11 -08:00
Charles Gagnon
9c886dd80a Remove unneeded validation error messages (#14531) 2021-03-04 09:50:57 -08:00
nasc17
1e67388653 Reset scheduling parameters CPU/mem request/limit to defaults (#14492)
* reset scheduling parameters

* Added right quotation marks

* Fixed comment

* Worker text box needs to have value, can't pass in emptry string

* Fixed ConfigurationSpecModel and added doc comment to handleOnTextChanged

* Add to information bubbles that user can reset scheduling parameters by passing in empty value

* Changed name of handleOnTextChanged
2021-03-02 16:15:40 -08:00
nasc17
9e02123330 Add loading component to Postgres Connection String Page (#14468)
* Add loading component

* Removed setting loading to true in update command
2021-03-01 16:45:33 -08:00
nasc17
cf08963fc1 Node configuration needs to show different size for data and logs volume for postgresql. (#14466)
* Included storage size of log and data

* Added backups and removed putting 0

* Added localized constants
2021-03-01 16:45:05 -08:00
nasc17
ac9a2dcf68 Nasc/per role parameters (#14425)
* Creating separate pages for worker and coordinator parameters

* Added new gear, hid coordinator server parameters page

* Commented out azdataApi

* Added white gear, created abstract class for server parameters page

* Chaged gear name, condensed base class more, changed file name

* Added colored gears for parameter pages

* Edited to describe configuring both coordinator and worker
2021-02-26 13:33:40 -08:00
nasc17
b10626d6f4 Nasc/per role compute and storage pg (#14424)
* Start adding coordinator section

* Coordinator section shown on CS page

* Updated information bubbles, edited discard button

* Cleaned up code, hid coordinator section

* Add return types to functions, fixed configuration string name

* Configuration section does not need to be edited when model is refreshed since it is not seen

* Changed back information bubble to inform that both worker and coordinator nodes will be configured
2021-02-26 13:17:53 -08:00
Charles Gagnon
00feb955d9 Add telemetry for deployment type being selected (#14410)
* Add telemetry for deployment type being selected

* Fix build
2021-02-24 15:47:17 -08:00
Charles Gagnon
d5385f66d3 Default to current controller when deploying from Arc dashboard (#14409) 2021-02-23 17:17:52 -08:00
nasc17
f62889002d Adds copy button to subscription id on postgres properties page (#14374)
* add copy button to subscription id

* Changed ordering
2021-02-22 13:05:08 -08:00
nasc17
cd4024625f Fixed data controller name on postgres properties page (#14373)
* Fixed data controller name

* Took out extra textkeyvalue for datacontroller
2021-02-22 10:57:17 -08:00
Charles Gagnon
238a0c60d9 Fix error when listing MIAA databases (#14286) 2021-02-12 17:16:11 -08:00
nasc17
35c8a20eb3 Added Server Group Nodes status table to Overview page (#14194)
* Add podstatus to spec

* Added image to table and fixed spacing.

* Added pod status to spec

* PR fixes

* Edited so that when page is closed and reopened, does not have empty server group node table
2021-02-12 16:24:27 -08:00
Charles Gagnon
e8d02dbc44 Cleanup typings from vs code merge (#14267) 2021-02-11 22:18:03 -08:00
Karl Burtram
ce612a3d96 Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79 (#14050)
* Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79

* Fix breaks

* Extension management fixes

* Fix breaks in windows bundling

* Fix/skip failing tests

* Update distro

* Add clear to nuget.config

* Add hygiene task

* Bump distro

* Fix hygiene issue

* Add build to hygiene exclusion

* Update distro

* Update hygiene

* Hygiene exclusions

* Update tsconfig

* Bump distro for server breaks

* Update build config

* Update darwin path

* Add done calls to notebook tests

* Skip failing tests

* Disable smoke tests
2021-02-09 16:15:05 -08:00
Charles Gagnon
13255f845b Update azdata-test to official Microsoft org version (#14203) 2021-02-09 08:35:47 -08:00
Alan Ren
a3cddbc8aa align with portal button style (#14187)
* align with portal button style

* fix welcome page

* image button

* more fixes

* use withProperties

* add comment back

* add border radius
2021-02-08 15:12:54 -08:00
nasc17
7a0ac71b98 Search function to be case insensitive (#14196)
* Search function does looks at all uppercase

* Add toUpperCase call only in filterParameters function
2021-02-08 14:09:11 -08:00
Charles Gagnon
da01c75dcf Add connect button to MIAA dashboard (#14183)
* Add connect button to MIAA dashboard

* PR comments
2021-02-08 10:33:16 -08:00
Charles Gagnon
350034cbb1 Fix arc dashboard component order error (#14164) 2021-02-04 15:53:29 -08:00
nasc17
e99b4a7bed Making the Postgres Properties Page Visible (#14161)
* Make properties page visible

* Set max length to text box
2021-02-04 12:39:51 -08:00
nasc17
814dfba338 Making the Postgres Parameters Page Visible (#14156)
* Having parameters page be visible and fixing information bubbles

* Added sessions to edit commands

* Fix table style
2021-02-04 09:52:39 -08:00
Charles Gagnon
395dfd6c52 Add setFilter to DeclarativeTableComponent (#14143)
* Add setFilter to DeclarativeTableComponent

* fix tests

* Update param name
2021-02-03 12:18:36 -08:00
Charles Gagnon
dcf17cc08b Remove async keyword from abstract functions (#14150) 2021-02-03 12:16:50 -08:00
Charles Gagnon
86a5cb27b7 Add debounce to pg parameters search filter (#14140)
* Add debounce to pg parameters search filter

* Update tsconfig
2021-02-02 16:15:31 -08:00
Charles Gagnon
f6e39a7211 Fix other fields being editable in password reprompt for Arc (#14117) 2021-01-29 16:27:20 -08:00
nasc17
d98ac86bd9 Postgres Parameters Page (#13855)
* Addition: properties page with link to dashboard

* Include new page

* Initial Parameter page start

* Include new changes from merged PRs

* Including new constants

* Git errors

* Add parameter commands and help

* Reset command

* Added chart

* git fix

* Fixed string issues

* connectSqlDialog is an abstract class. Separated out Miaa and Postgress connection

* Initial start to adding connect to sql for postgres instance

* Simplified classes extending ConnectToSqlDialog, added get providerName, and function to create error message

* Miaa models provides dialog title

* Updated failed message parameters

* completionPromise.reject

* Fixed connect to MSSql

* Messy dialog showing from button

* removed this._completionPromise.reject

* Cleaning up code

* Set connectSqlDialog to be an abstract class. Separated out Miaa and Postgres.  (#13532)

* connectSqlDialog is an abstract class. Separated out Miaa and Postgress connection

* Simplified classes extending ConnectToSqlDialog, added get providerName, and function to create error message

* Miaa models provides dialog title

* Updated failed message parameters

* completionPromise.reject

* Fixed connect to MSSql

* removed this._completionPromise.reject

* Connect button clean up

* Format

* Format doc

* Fixed compile errors

* Cleaning up page

* Clean up

* clean up refresh

* Format doc

* Removed ellipse

* Cleaning up problems

* Updating localized constants

* Missing username update

* Get connection profile added to Resource model, abstract method created for calling connection dialog

* Added createConnectionProfile

* took out import

* Pulled in new changes, fixed usercancellederror

* Getting engine settings

* Git errors

* Git errors

* Git errors fix

* Fixing Css

* Freezes, Search function working, 20 parameters

* Fixed re

* Git errors

* Save and reset commands working

* Discard works, updated how engine settings refresh with model

* Updated search, add back loading for when trying to connect

* Cleaning up comments left in code

* Git error

* Corrected names of icons and constants, Fixed Miaa dialog title

* Removed using any on page, added void return types, took out commented code

* Changed gear svg, made postgres extension a loc constant, fixed formatting

* Fixed controller model name

* Put connection profile and id in resource model, changed back controller model in base class

* Fixed a comment

* Added loading component for waiting for postgres extension to be installed

* Fix parameters page to show parameters if engine settings are already loaded (#13996)

* Added progress message for installing postgres extension

* Minor styling updates

* Making sure search box and rest buttons are enabled when opening page with loaded data. Update refresh

* Git errors

* change name

* Code review updates: Combined create parameters and refresh table.

* Update sql-assessment to use latest ads-extension-telemetry npm package (#14003)

* Change configure Jupyter server steps from async to sync (#13937)

* change config steps to sync

* fix tests

* use pathexistsSync

* remove pathExistsSync call

* address PR comments

* Use a minimum cell height to prevent whitespace markdown cells from becoming invisible. (#14008)

* Fix validation errors (#14009)

* Fix validation errors

* fix compile

* update return type

* Cleanup model component wrapper event handlers (#14012)

* Clean up button component disposables (#14011)

* Clean up button component disposables

* consolidate logic

* Adding Dacpac extension telemetry and core wizard/page telemetry updates(#13859)

* Dacpac telmetry code changes

* Removed added spaces

* Generate deployScript accessibility changed back to public

* code review suggessions updates

* dacpac extension tests fixes

* Updated time and filesize methods allowing general return values

* Telemetry code updates

* Dacpac Telemetry potential data loss capture and PII error excluded

* Dacpac telemetry code updates for comments

* Wizard pages navigation telemetry event capture moved to the core

* DacpacTelemetry code updates

* Extension wizard cancel telemetry for data loss

* Dacpac telemetry pagename and small code updates

* final Dacpac telemetry code updates...

* migrated loc files (#14015)

* Took out some info bubbles and addingitems

* Update search function

* Handle special value occasions

* Undo change

* Undo change

Co-authored-by: chgagnon <chgagnon@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: khoiph1 <khoiph@microsoft.com>
2021-01-29 13:48:35 -08:00
Charles Gagnon
db845754c6 Add resource deployment filtering by option values (#14101)
* Add resource deployment filtering by option values

* Fix compile error
2021-01-28 17:19:08 -08:00
Charles Gagnon
8677ffc68c Fix deployment wizard to not close when cancelling out of password prompt (#14083) 2021-01-28 09:00:46 -08:00
Charles Gagnon
dd0fa50d32 Fix hang when expanding arc tree node without azdata (#14033) 2021-01-22 17:54:20 -08:00