Commit Graph

66 Commits

Author SHA1 Message Date
Lewis Sanchez
a400ff2f43 Save sql plan no longer uses the exact same name as the default (#21563)
* Save sql plan no longer uses the same name

* Minor clean up
2023-01-10 16:59:37 -08:00
Josh Parnham
7d11b88b43 Change execution plan default save location when not in a workspace (#21461) 2023-01-03 14:51:30 -08:00
Karl Burtram
25d4d42d3e Fix casing on execution plan command titles (#21170) 2022-11-08 19:22:13 -08:00
Aasim Khan
00b797b4f3 Adding keyboard shortcuts for column resizing in slickgrid (#21100)
* Adding column resize keyboard shortcuts in slickgrid

* Switching to standard keyboard evt

* Adding comment for the functionality

* Cleaning up code and adding more comments

* Using quick input to get column resize width

* Adding check for negative sizes

* Fixing some stuff
2022-11-04 16:15:04 -07:00
Lewis Sanchez
f8b7c32030 Centers selected node found by the expensive operation widget (#21103) 2022-11-04 10:34:25 -07:00
Lewis Sanchez
ca78491238 Bumps azdataGraph version to 0.0.56 (#21089)
* Bumps azdataGraph version to 0.0.56

* Removed warning popup since widget only contains avail metrics
2022-11-03 08:16:20 -07:00
Aasim Khan
4823a76833 Adding screen reader optimized mode to slickgrid (#21069) 2022-11-02 15:11:16 -07:00
Aasim Khan
512eba5675 Remove preview checks from ep (#21008) 2022-10-27 10:05:16 -07:00
Aasim Khan
1743c7ea13 Fixes: (#21004)
1. Navigation info announcement when user enter graph
2. Allowing users to expand/collapse button
3. Tooltips shown only when enter is pressed
2022-10-26 22:16:36 -07:00
Aasim Khan
4d5e9adbc1 Adding option to sort columns using F3 key in SlickGrid. (#20897) 2022-10-25 08:22:31 -07:00
Aasim Khan
84305c32c0 Adding accessible tooltips and tooltip based alerts (#20912) 2022-10-21 14:28:27 -07:00
Aasim Khan
5942980300 Adding missing stream icons for execution plan (#20896) 2022-10-20 15:24:30 -07:00
Karl Burtram
8a3d08f0de Merge vscode 1.67 (#20883)
* Fix initial build breaks from 1.67 merge (#2514)

* Update yarn lock files

* Update build scripts

* Fix tsconfig

* Build breaks

* WIP

* Update yarn lock files

* Misc breaks

* Updates to package.json

* Breaks

* Update yarn

* Fix breaks

* Breaks

* Build breaks

* Breaks

* Breaks

* Breaks

* Breaks

* Breaks

* Missing file

* Breaks

* Breaks

* Breaks

* Breaks

* Breaks

* Fix several runtime breaks (#2515)

* Missing files

* Runtime breaks

* Fix proxy ordering issue

* Remove commented code

* Fix breaks with opening query editor

* Fix post merge break

* Updates related to setup build and other breaks (#2516)

* Fix bundle build issues

* Update distro

* Fix distro merge and update build JS files

* Disable pipeline steps

* Remove stats call

* Update license name

* Make new RPM dependencies a warning

* Fix extension manager version checks

* Update JS file

* Fix a few runtime breaks

* Fixes

* Fix runtime issues

* Fix build breaks

* Update notebook tests (part 1)

* Fix broken tests

* Linting errors

* Fix hygiene

* Disable lint rules

* Bump distro

* Turn off smoke tests

* Disable integration tests

* Remove failing "activate" test

* Remove failed test assertion

* Disable other broken test

* Disable query history tests

* Disable extension unit tests

* Disable failing tasks
2022-10-19 19:13:18 -07:00
Alan Ren
5d731fe0ad table cell selection improvement (#20854)
* Support SHIFT key for table cell selection

* fix for mac

* PR comment
2022-10-14 19:44:14 -07:00
Lewis Sanchez
f51e5c370b Registers all disposable items for query execution plans (#20851) 2022-10-14 14:50:25 -07:00
Lewis Sanchez
61fb5db66c Adds titles to execution plan widget combo boxes (#20815)
* Adds titles to execution plan widget combo boxes

* Renames const and title
2022-10-12 16:03:02 -07:00
Lewis Sanchez
e24068baaa Fixes resize bug affecting the find node widget (#20824) 2022-10-12 14:52:08 -07:00
Lewis Sanchez
636efa841d Fixes same title for reverse alphabetical properties button (#20813) 2022-10-11 20:40:46 -07:00
Lewis Sanchez
5ec1d3a8e6 Adds add execution plan button and context menu to the bottom half of the plan comparison screen (#20770)
* Adds context menu option placeholder plan container

* Adds context menu and button to add execution plan to placeholder

* Minor clean up

* Replaces taskbar with button to add execution plans

* Removes unneeded CSS styling.

* Adjusts button type to secondary
2022-10-10 14:53:27 -07:00
Aasim Khan
9f5ee32825 Adding new filter icon (#20762) 2022-10-06 21:34:21 -07:00
Lewis Sanchez
00ff3ac50f Add functionality to expand and collapse all property rows. (#20746)
* Adds ability to expand and collapse all property rows

* Removes duplicate collapse/expand all logic

* Code review changes

* Removes unnecessary enum

* Updates comment

* Code review changes

* Code review changes

* Minor clean up

* Renames expand/collapse method

* Corrects collapse all action IDs and labels
2022-10-06 20:47:20 -07:00
Lewis Sanchez
f046129515 Adds not equal operator and expands unequal collapsed header rows (#20737)
* Adds not equal operator and expands unequal collapsed prop rows

* Minor clean up.
2022-10-06 13:45:04 -07:00
Lewis Sanchez
65a3bd7491 Shows not equal operator when comparing non-null props to null props (#20740) 2022-10-05 18:49:06 -07:00
Lewis Sanchez
6ea75bb538 Removes summary section from plan comparison properties view (#20735) 2022-10-05 18:48:53 -07:00
Lewis Sanchez
5e48cb99e1 Fixes bug around sorting equal and unequal properties (#20702)
* Fixes bug around sorting equal and unequal properties

* Uses deepClone to deepCopy objects

* Code review changes

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2022-10-03 23:10:45 -07:00
Lewis Sanchez
f521d7cc63 Query Execution Plan Expensive Operator Highlighting (#20579)
* Boilerplate for new context menu options

* Enables checkmarks for expensive operator context menu actions

* Updates azdataGraph version to 0.0.44

* Adds clearing logic to actions and retrieves additional info from nodes

* Removes unnecessary actions that aren't supported by other providers

* Finishes setting up the rest of the context menu actions

* Corrects context menu action label

* Defines new widget type for finding expensive operations

* Adds TODO for class icon name

* Creates action to open the expensive operation widget

* Adds escape and enter key shortcuts to findExpensiveOperation widget

* Styles find expensive operation widget

* Corrects class name for finding expensive operator action

* Corrects import statement.

* Code clean up

* Bumps azdataGraph version to 0.0.45

* Adds an info box for when a metric doesn't find any nodes

* Adds label to find expensive operator widget

* Invokes dispose when widget controller removes widget

* Implements disposable in all execution plan widgets.

* Adds off action to clear highlighting

* Adds a default setting and default prompt for highlighting metric

* Fixes not all code paths return error

* Removes shortcut key from text for widget actions

* Adds enum description

* Removes added dictionary type, and renames class name

* Removes unnecessary null checks

* Removes cost metric dictionary and adds corresponding properties

* Code review changes

* Removes incorrectly implemented key down event for widget.

* Renames widget and action class names for highlighting expensive ops

* File rename

* Cleans up labels to better reflect highlight action

* Removes hardcoded button width style and sets it to auto

* More clean up

* Clean up import statement

* Code review changes

* Drop down list only shows available metrics

* Updates highlight expensive operation icon

* Update STS version
2022-10-03 12:32:39 -07:00
Aasim Khan
2a9c0a6935 Fixing filter stylings (#20685) 2022-09-30 10:00:13 -07:00
Lewis Sanchez
7c83739c25 Reorganized Execution Plan Comparison Properties View (#20673)
* Adds summary view to comparison properties view

* Equal rows are collapsed at the bottom of the properties view window

* Variable rename

* Variable rename

* Adds row header for equal properties.

* Adds middle column with diff icon to comparison properties table

* Resolves hygiene issue

* Code review changes

* Fixes undefined error bug

* Adds styles to less than and greater than codicon's

* Changes equivalent properties collapsed header

* Removes unnecessary check

* Integrates alphabetical and importance sorting to equivalency sorting
2022-09-29 13:53:10 -07:00
Aasim Khan
fd8993134f Execution Plan Filtering and UI improvements (#20631)
* Fixing execution plan stuff

* Adding filter to top operations

* Flipped custom zoom icon

* changing keys

* Moving constants to a file

* Search properties

* Making logic concise
2022-09-23 12:57:30 -07:00
Lewis Sanchez
12c5aa0f80 Fixes incorrect operation label when plans are oriented vertically and node selection changes. (#20630)
* Fixes incorrect label when plans are vertical

* Code review changes.

* Adds helper methods to get localized strings

* Helper functions moved to module level

* Renames fields from top and bottom to primary and secondary
2022-09-21 10:40:09 -07:00
Aasim Khan
3f6f6ed07b Changing property header row styling for execution plan properties (#20594) 2022-09-12 17:20:16 -07:00
Aasim Khan
7857e5946f New azdata graph layout (#20451)
* Updated contracts

* Adding latest azdataGraph update

* Updating graph lib
2022-08-24 12:09:17 -07:00
Lewis Sanchez
7de5ee0427 Adds functionality to open execution plans from DB tables and DMVs. (#20377)
* Adds functionality to open execution plans from DB tables and DMVs.

* Code review changes

* Renames method to getProviderFromUri
2022-08-17 19:24:23 -07:00
Aasim Khan
a7a337f063 Adding properties grid enhancements in execution plan (#20208)
* init push

* Fixing properties in plan comparison

* Add long Text Cell viewer

* Disabling auto edit by default

* Removing text editor
2022-08-11 11:22:12 -07:00
Lewis Sanchez
9fc251259c Adds Ability to Search for Nodes in Compared Execution Plans (#20168)
* Adds find node button to comparison plans.

* Can search multiple nodes (improve widget UI and initialization)

* Adjusts how second plan is added to the node search widget

* Adds styling to the find node action bar

* Removes unused code

* Minor clean up

* Cleans up CSS redundancy

* Adjusts property names according to access specifiers

* Corrects find node behavior to match SSMS

* Dependency injects instantiation service

* Adds additional property to telemetry event.

* Adds undefined to getter return signatures for plans

* Adds checks around active execution plan properties

* Code review change

* Code review changes
2022-07-28 14:14:32 -07:00
Aasim Khan
518bb33a2f Adding plan tree to execution plan (#20158)
* Adding plan tree

* Fixing localization keys

* Removed whitespace
2022-07-26 14:30:46 -07:00
Lewis Sanchez
43e7e35df5 Update azdataGraph version to 0.0.37 (#20140)
* Updates azdataGraph version to 0.0.37

* Enables collapse/expand node with highlight resize
2022-07-21 16:15:54 -07:00
Aasim Khan
67637a41f5 Making better ep highlights (#20055) 2022-07-15 15:31:01 -07:00
Lewis Sanchez
e5b0e0255c Updates azdataGraph version to 0.0.33 (#20028) 2022-07-13 18:59:22 -07:00
Aasim Khan
980a233aad Sorting top by cost initially (#19998) 2022-07-11 21:34:38 -07:00
Lewis Sanchez
e25a9574a7 Bump azdataGraph version to 0.0.32 (#19954)
* Update azdataGraph version to 0.0.31

* Adds icons

* Bumps azdataGraph version to 0.0.32

* Removes whitespace

* Uses icon that better adapts to color theme changes.

* Disables collapse for execution plans in plan comparison editor view
2022-07-11 21:26:34 -07:00
Lewis Sanchez
5fbea7a39c Property view labels update when execution plan orientation changes (#19924)
* Updates properties view title when the orientation changes

* Property orientation labels change when the plan orientation changes.

* Renames top and bottom containers to secondary and primary

* Minor clean up

* Removes unnecessary class members

* Promotes constants to module level

* Moves function to module level

* Renames value1 and value2 to primary and secondary

* Replaces orientation string literal type with enum

* Resolves undefined orientation bug

* Removes unused orientation getter

* Updates property table columns only

* Uses orientation enum in editor view and properties view

* Clean up
2022-07-07 13:26:08 -07:00
Aasim Khan
9cfa1436d9 Adding top operations to execution plans (#19902)
* Adding top operations to execution plans

* Adding title to links

* Fixing pr comments

* Hiding top operations icon in execution plan editor

* Reducing outline width, adding separator and removing placeholder text

* Registering TopOperationsTabView
2022-07-07 12:50:52 -07:00
Lewis Sanchez
811aa18862 Centralizes localized category string (#19857) 2022-06-28 16:58:09 -07:00
Lewis Sanchez
b01642aec1 Adds "Execution Plan" prefix to Execution Plan commands (#19842)
* Prefixes execution plan commands, so they are easier to find

* Provides category argument to categorize commands.
2022-06-28 11:42:25 -07:00
Aasim Khan
489259d364 Fixing graph root padding and truncating long queries in execution plan (#19703)
* Fixing graph root padding
Truncating queries to one line

* Updating remote package
2022-06-09 17:05:35 -07:00
Aasim Khan
b1d8e43569 Changing plan comparison properties table logic and icons (#19700)
* Changing plan comparison logic and icons

* Removing empty class ref
2022-06-09 14:15:35 -07:00
Aasim Khan
b63fd59372 Adding plan properties comparison, fixed dark icons, fixed dropdown text. (#19601)
* Adding prop compare logic

* Fixed using semaphore

* Adding dark icons
Adding dropdown prefix
Adding all visible plans from plan comparison

* Reverting mssql vbump

* Fixing icon name

* executionPlanComparisonPropertiesView

* Fixing icon paths and adding preselect model

* Fixed icon spacing

* Removing styling in formatter

* Adding tooltip to plugs
switching to plugins

* Removing unecessary calls to getSkeletonNodes()

* Renaming variable

* Fixed column value formatting

* Undoing formatter change
2022-06-03 16:31:03 -07:00
Lewis Sanchez
b52386a36a Execution Plan Telemetry for Plan Comparisons (#19610)
* Adds telemetry when plan comparison is invoked

* Small formatting change.

* Adds telemetry to add execution plan button

* Removes unused ExecutionPlanComparisonEditorView constructor parameters

* Small formatting adjustment

* Adds telemetry to ExecutionPlanComparisonEditorView properties

* Code review changes
2022-06-03 13:56:32 -07:00
Aasim Khan
6282958bd1 scoping css (#19520) 2022-05-25 10:31:29 -07:00