Commit Graph

35 Commits

Author SHA1 Message Date
Charles Gagnon
1c9ba64ee0 check-param-names (#18189) 2022-01-31 12:39:22 -08:00
Charles Gagnon
51b0e9feee Fix saved queries opening in plain text editor (#18096) 2022-01-18 12:03:54 -08:00
Aasim Khan
ea2860eb33 Pushing initial work for done in Query plan feature to main (#17986)
* Adding initial boilerplate for qp2

* Adding feature flag in query plan 2

* Clearing show plan 2 after every run

* Adding sub tree cost

* removing unused method.

* WIP 2

* Adding properties view and relative cost to query plan

* WIP

* Add icons to ads

* Assing relative costs and prop windows

* Enabling older query plan again

* Making some PR fixes

* Some more PR related fixes

* Use MS org azdataGraph module

* Moving new properties to azdata proposed.

* Moving new class properties to proposed

* added missing doc component.

* Changing how azdatagraph package is referenced

* Removing empty lines, fixing localization keys

* Removing empty line, localizing some string

* making css classes more specific

* making some logic concise

* localizing some more strings

* Making more css classes specific

* Removing important tag from css props

* Checking if sum is greater than 0 to prevent divide by zero exceptions

* Fixed loader error in bootstrap

* Fixing query index

* -fixing image paths
-making css class more class specific by using nested selectors

Co-authored-by: kburtram <karlb@microsoft.com>
2022-01-13 09:32:13 -08:00
Charles Gagnon
77e4fdd407 Fix open external not working (#17717) 2021-11-19 11:25:23 -08:00
Alan Ren
458c4cff39 improvement for the editor crash issue (#17278)
* handle the query editor crash issue

* update message
2021-10-06 09:45:53 -07:00
Alex Ma
107b0ae683 replace empty string with space (#17216) 2021-10-01 13:06:16 -07:00
Hai Cao
0e4c67dc0c Add AAD token expiration handling for query runner (#17117)
* Add AAD token refresh for notebook

* move token refresh to query management and remove previous refresh calls
2021-09-21 18:57:54 -07:00
Alex Ma
8c2cea4ea6 Added saving query (#16883)
* removed clear results and results visible.

* revert changes, still work in progress

* added small debug message

* added flag for state

* removed clear in queryResultsView

* moved carbon edit message

* simplifcation

* fixed spacing

* added clarifying message

* added clarifying comment

* added original tab clear line for future things

* added support for regular saves

* removed vscode changes

* added queryEditorTextInput to other versions

* added stuff

* reverted changes to queryTextEditorInput

* deleted duplicates

* moved untitledQueryEditorInput

* added FileQueryEditorInput constructor

* added instantiation

* added queryEditorTest

* added temporary state for save editor input

* added back in FileQueryEditorInput

* added example of both to test

* restored input.

* Added current results processing

* removed queryeditor import

* added disable dispose, WIP

* added small change to dispose

* added oldUri

* added small changes for adding renameQuery

* added first parts of renameQuery, need to add more in other parts. (Place next to disposeQuery).

* moved rename around in queryModel

* added rename to testQueryManagementServices, now need to add to queryrunner.

* added to queryRunner, need to test

* added renameQuery calls

* added renameQuery to extensions

* moved untitledQueryEditorInput to its old location

* removed duplicate untitledQueryEditorInput

* test import

* test blah

* moved fileQueryEditorInput to services

* deleted original fileQueryEditorInput

* Moved fileQueryEditorInput to new location

* added workbenchinstantiationservice

* added titledQueryEditorInput

* restored untitledQueryEditorInput.ts

* removed instantiation service

* made changes to titledQueryEditorInput

* Revert "deleted original fileQueryEditorInput"

This reverts commit dd5eb19ea1489d9c0dda159e6a798975240dab65.

* reverted back to pre move

* added altered untitledQueryEditorInput

* temporarily using old version of save until determining point where new URI is assigned.

* renamed oldUri to newUri to better reflect its actual use.

* added some debug messages for examining how uris work

* made small changes to untitledQueryEditorInput

* restored save to have actual code.

* moved renameQuery to proposed.

* added partially working save as for results (Pressing run breaks query)

* removed instantiationservice

* added newUri for dataservice

* added queryRunner.uri for queryModelService

* moved untitledQueryEditorInput to old location

* changed todomessage

* added explanation messages

* fixed spaces and added description

* moved untitledQueryEditorInput to new location

* added rename for connectionmanagementservice

* added carbon edit message

* removed carbon edit to editorservice

* removed another space

* added get and set for isSaving value

* removed accessor

* Update azdata.proposed.d.ts

added space

* fixed azdata.proposed

* added changeConnectionUriForQuery

* restored request

* replaced changeconnectionuri to changeuri

* Revert "replaced changeconnectionuri to changeuri"

This reverts commit eed8e518dee69cf2922ff86dc1763e6fb7715a71.

* made required changes

* fixed exclamation mark

* removed error on queryRunner changeconnection

* added save connect button status

* added additional state properties to save

* added wip setstate

* added changes for better naming

* added changes in preparation for vscode merge

* take screenshot of failed test before close editor (#16876)

* Add setting for enabling using new markdown renderer (#16864)

* Add setting for enabling using new markdown renderer

* Use const

* Fix circular dependency

* Default setting to false

* fix refresh node and add sample (#16888)

* Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569)

* Bump VS Code version to latest sync point (#16891)

* Fix duplicate editor windows on reload (#16893)

* reset the icon before use (#16896)

* Undo merge icon change (#16894)

* disable cancel button after clicked once (#16783)

* disable cancel button after clicked once

* remove enabling of cancel button when cancelling

* Update sqlite version for smoke tests (#16903)

* update sqlite

* bump distro

Co-authored-by: chgagnon <chgagnon@microsoft.com>

* add autoCutoverConfiguration to getMigrationStatus (#16803)

* Enable scripting for triggers and other objects (#16885)

* WIP 1

* Add parentName to azdata

* Add some additional types for scripting

* Add parent type name to support view subobjects

* bump dependencies and address review comments

* Modify treeDataChange event (#125214) (#16907)

Modify treeDataChange event to support firing arrays.

* Move create new option for publish to top and filter out system dbs (#16908)

* Move create new option for publish to top

* Move New tag to description

* fix

* Open project to default location (#16910)

* Have create proj from database show default save location as option (#16909)

* Default create proj location to setting

* update icons

* undo

* Put search/ status/refresh in single line (#16898)

* add horizontal scroll bar to output (#16918)

* Fix extension linting warnings and enable extension linting in pipelines (#16922)

* Fix extension linting errors

* fix test

* Update public preview readme for sql migration extension (#16920)

* Add sql bindings package reference to project (#16912)

* list packages and add packages working

* cleanup and remove list packages

* cleanup

* change to pull in latest package version

* Add STS root folder override (#16927)

* Add STS root folder override

* Display message to user

* Show once for any service

* Fix some unhandled promise lint errors (#16924)

* Moved items around to handle new untitledQueryEditorInput location (#16914)

* moved items around to handle new untitledQueryEditorInput location

* added editor inputs to constants.

* added interface for untitledQueryEditorInput

* added IUntitledQueryEditorInput

* Revert "added IUntitledQueryEditorInput"

This reverts commit 67955eb289458e7ac4e7e5ce0ee077f38ed82a2c.

* Revert "added interface for untitledQueryEditorInput"

This reverts commit 88552dbd811b643fd51d5d21f4571b677d7bfc73.

* Revert "Revert "added interface for untitledQueryEditorInput""

This reverts commit 13a89c40e4cb0a3fa495f5b150c066892387e509.

* Revert "Revert "added IUntitledQueryEditorInput""

This reverts commit 8b2258ab49275a271a39036ea1734feca98ee753.

* added extends for IUntitledQueryEditorInput

* added casting in editorGroupView

* Revert "added casting in editorGroupView"

This reverts commit 61500ea43690b08ba2393808a8d118abc60da4ac.

* Revert "Moved items around to handle new untitledQueryEditorInput location (#16914)"

This reverts commit 87a663ee6b7cc3330c0528b20fb74f557451f911.

* Revert "Fix some unhandled promise lint errors (#16924)"

This reverts commit 73218a840df188f1ae26ff1c2e1aa5b85b9cfcb0.

* Revert "Add STS root folder override (#16927)"

This reverts commit 35936d464f2e452cd29659fffef20018ac6ffdd4.

* Revert "Add sql bindings package reference to project (#16912)"

This reverts commit 72d29ed7a7d298716ba159548af1f08adc82db25.

* Revert "Update public preview readme for sql migration extension (#16920)"

This reverts commit 3b3c3921557aabe86c927e6a833c0c41b48f7e23.

* Revert "Fix extension linting warnings and enable extension linting in pipelines (#16922)"

This reverts commit f5ea3e69ae5132c09eba699e8c25d1a1a66e0914.

* Revert "add horizontal scroll bar to output (#16918)"

This reverts commit 76bf86a2536edfe84b0f323571e489d69fe9fe00.

* Revert "Put search/ status/refresh in single line (#16898)"

This reverts commit d9553d09141c159e8b1cc27f6422e51b68800c7c.

* Revert "Have create proj from database show default save location as option (#16909)"

This reverts commit 88b9b7734b467a2552dfeea9c844b90361a660de.

* Revert "Open project to default location (#16910)"

This reverts commit a46170b347a28ff77f40883b055153823a86308e.

* Revert "Move create new option for publish to top and filter out system dbs (#16908)"

This reverts commit 4be47daf63771b6c3b12b786ba687dfc6ca0e3c6.

* Revert "Modify treeDataChange event (#125214) (#16907)"

This reverts commit 4161c21abcc78a9b5a65e52ae7d7f960ea71219b.

* Revert "Enable scripting for triggers and other objects (#16885)"

This reverts commit 2ece3ffb12478faf0f49df1e66bcc7acc0631500.

* Revert "add autoCutoverConfiguration to getMigrationStatus (#16803)"

This reverts commit 366633e7247d508138b45e902d7e034c79763dec.

* Revert "Update sqlite version for smoke tests (#16903)"

This reverts commit 64f66d7b18418b028cfa56b984d6f9979f65cc50.

* Revert "disable cancel button after clicked once (#16783)"

This reverts commit 12044e30746f44188d46a781f582781bf3638762.

* Revert "Undo merge icon change (#16894)"

This reverts commit 0801d14267a9980a2c29374666ad7fee14dfcafb.

* Revert "reset the icon before use (#16896)"

This reverts commit 971c39e8bc5c774fb49d81c5c36617ec45b4078c.

* Revert "Fix duplicate editor windows on reload (#16893)"

This reverts commit 4df3085b09b645a3ef2728c3ab3778fb7a63f2ba.

* Revert "Bump VS Code version to latest sync point (#16891)"

This reverts commit c1bc6639efcdf69d9b9c57cc44af3a1d19514f83.

* Revert "Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569)"

This reverts commit c92da9c02ee221ca69813af69b039d3f3846aa42.

* Revert "fix refresh node and add sample (#16888)"

This reverts commit df820f6c03d167d933d089bfadf5296a7dcaf834.

* Revert "Add setting for enabling using new markdown renderer (#16864)"

This reverts commit e3c036dfbaa0a1e1588f348eb9eb4a7edb4f9bda.

* Revert "take screenshot of failed test before close editor (#16876)"

This reverts commit d466b19a6e56a43654c779c1dab60724b1f0c3db.

* fix spaces

* changed uri to public

* fixed formatting on azdata.proposed

* added queryprovider at the end

* changed already in connections list message.

* added notifyconnectionurichanged

* added changes to fix

* fixed testQueryModelService

* fixed leftover stuff

* more renames

* Added small changes

* added messages to untitledQueryEditorInput

* added work in progress fileQueryEditorInput save as

* fixed space

* removed changeUri

* remove saveAs from queryEditorInput

* removed undefined from createFileQueryEditorInput in untitled.

* changed saveAs for fileQueryEditorInput

* changed saveAs to use createInstance

* bumped version of STS in config.json

* bump version of dataprotocol-client

* update to yarn.lock

* more changes

* removed space for untitledQueryEditorInput

* some refactoring done

* removed already has provider check due to existing provider still existing

* added a comment

* fixed typo

* change results order around

* added already existing connection message

* restored untitledQueryEditorInput

* removed message

* added existing connection

* Revert "added existing connection"

This reverts commit 3cc34f6b1e670bb7b257e046f53560471badfd34.

* add try catch to restore older overwrite file behavior

* added types and error handling

* added error comments.

* changed message of both files

* fixed formatting for azdata.proposed.d.ts

Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: stuti149 <87131830+stuti149@users.noreply.github.com>
Co-authored-by: Rachel Kim <rackim@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
2021-09-03 09:45:32 -07:00
Cory Rivera
0082031f97 Replace deprecated assert functions in test files. (#16945) 2021-08-31 09:04:17 -07:00
Cory Rivera
cb7b7da0a4 Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569) 2021-08-25 16:28:29 -07:00
Alex Ma
bbe77d6823 added queryRunner.uri to queryModelService (#16835) 2021-08-19 13:41:15 -07:00
Charles Gagnon
3cb2f552a6 Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>
2021-06-17 08:17:11 -07:00
Alan Ren
5bd1552a59 add null check for errors in the console while using query editor (#15711)
* add null check

* another null check

* pr comments

* update typing
2021-06-15 16:05:38 -07:00
Alan Ren
eea8c61b6e add config for open after save behavior (#15675) 2021-06-10 13:32:05 -07:00
Alan Ren
7dca953660 fix line number display issue (#15368) 2021-05-07 18:57:22 -07:00
Alan Ren
0ed2a5d431 fix result selection summary issues (#15245) 2021-04-26 23:07:55 -07:00
Alan Ren
6c54059f89 query results filtering and sorting (#14833)
* query results filtering and sorting (#14589)

* enable filter

* attach button style

* add hybrid data provider

* make filter and sort work

* fix editor switch issue

* configuration

* fix sort and filter

* add more specific selector

* fix hidden items issue

* update text

* revert text change

* fix copy results issue

* put feature behind preview flag

* comments

* fix tslint error
2021-03-23 11:30:41 -07:00
Charles Gagnon
31ce58a8fc Cleanup telemetry keys (#14795)
* Add event for connection error

* Cleanup telemetry keys

* Fix missed keys
2021-03-18 15:52:57 -07:00
Alan Ren
83da03a728 selected cell summary for status bar (#14358) 2021-02-19 11:29:04 -08:00
Alan Ren
756454efa9 add support to accept visualization options (#14254)
* allow query provider to specify visual options

* make it reusable

* add comment

* fix error

* null check
2021-02-11 15:40:45 -08:00
Christopher Suh
6ff1e3866b Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3 (#12295)
* Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3

* Fix test build break

* Update distro

* Fix build errors

* Update distro

* Update REH build file

* Update build task names for REL

* Fix product build yaml

* Fix product REH task name

* Fix type in task name

* Update linux build step

* Update windows build tasks

* Turn off server publish

* Disable REH

* Fix typo

* Bump distro

* Update vscode tests

* Bump distro

* Fix type in disto

* Bump distro

* Turn off docker build

* Remove docker step from release

Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
2020-10-03 11:42:05 -07:00
Lucy Zhang
e3ec6bf9c5 Add grid streaming support for notebooks (#12175)
* add onResultUpdate handler in gridoutput

* convert rows to mimetype and html

* wait for data conversion to finish before saving

* detach changeRef after output is created

* fix save grid action

* move data conversion check to each cell

* move conversion logic to dataprovider

* notify data converting when user saves

* add comments and remove unused methods

* fix method return type

* fix tests

* fix convertData method header

* move azdata changes to azdata proposed

* address PR comments

* display top rows message

* fix messages/table ordering and query 100 rows

* add missing escape import

* set default max rows to 5000

* add undefined check to updateResultSet

* change gridDataConversionComplete return type
2020-09-10 13:31:40 -07:00
Anthony Dresser
9327624930 Add more to strict nulls (#11871)
* add more to strict nulls

* maintain error handling properly

* fix lint
2020-08-19 18:38:34 -07:00
Anthony Dresser
9744d7796c fix array access issues with map iterators 2020-07-16 11:48:51 -07:00
ADS Merger
9d3f12d0b7 Merge from vscode 1b314ab317fbff7d799b21754326b7d849889ceb 2020-07-15 23:51:18 +00:00
Anthony Dresser
aae013d498 add option to open excel file externally (#11324) 2020-07-15 15:06:46 -07:00
Anthony Dresser
286c021df9 Fix access to query editor configuration (#11321)
* fix access to query editor configuration

* fix configuration type

* fix setting type
2020-07-13 13:05:36 -07:00
Anthony Dresser
381a747b62 fix export for remote (#10934) 2020-06-16 12:10:05 -07:00
Anthony Dresser
72b2d9ef72 rework some of some, add query to smoke (#10591) 2020-06-05 17:25:24 -07:00
Anthony Dresser
df5df38a55 Query Runner Tests (#10252)
* rework some code and write an inital test

* fix strict

* add more to standard test

* add to existing workflow test

* fix tests

* simplify the code

* add more tests

* remove bad import

* fix compile

* fix timestampiong
2020-05-06 13:38:12 -07:00
Amir Omidi
592801d74c Create a progress notification for saving files (#9875)
* Create a progress notification for saving files

* Remove unused import
2020-04-07 11:12:51 -07:00
Anthony Dresser
4c54b5dbac Batch messages on the exthost to not freeze ads (#8949)
* batch messages on the exthost to not freeze ads

* clear out messages on query complete
2020-02-20 14:50:13 -08:00
Anthony Dresser
506c6a5e5f More Layering (#9139)
* move handling generated files to the serilization classes

* remove unneeded methods

* add more folders to strictire compile, add more strict compile options

* update ci

* wip

* add more layering and fix issues

* add more strictness

* remove unnecessary assertion

* add missing checks

* fix indentation

* wip

* remove jsdoc

* fix layering

* fix compile

* fix compile errors

* wip

* wip

* finish layering

* fix css

* more layering

* rip

* reworking results serializer

* move some files around

* move capabilities to platform wip

* implement capabilities register provider

* fix capabilities service

* fix usage of the regist4ry

* add contribution

* wip

* wip

* wip

* remove no longer good parts

* fix strict-nulls

* fix issues with startup

* another try

* fix startup

* fix imports

* fix tests

* fix tests

* fix more tests

* fix tests

* fix more tests

* fix broken test

* fix tabbing

* fix naming

* wip

* finished layering

* fix imports

* fix valid layers

* fix layers
2020-02-15 01:54:23 -06:00
Anthony Dresser
9af1f3b0eb More layering (#9111)
* move handling generated files to the serilization classes

* remove unneeded methods

* add more folders to strictire compile, add more strict compile options

* update ci

* wip

* add more layering and fix issues

* add more strictness

* remove unnecessary assertion

* add missing checks

* fix indentation

* wip

* remove jsdoc

* fix layering

* fix compile

* fix compile errors

* wip

* wip

* finish layering

* fix css

* more layering

* rip

* reworking results serializer

* move some files around

* move capabilities to platform wip

* implement capabilities register provider

* fix capabilities service

* fix usage of the regist4ry

* add contribution

* remove no longer good parts

* fix issues with startup

* another try

* fix startup

* fix imports

* fix tests

* fix tests

* fix more tests

* fix tests

* fix more tests

* fix broken test

* fix tabbing

* fix naming
2020-02-12 18:24:08 -06:00
Anthony Dresser
56695be14a More layering and compile strictness (#8973)
* add more folders to strictire compile, add more strict compile options

* update ci

* wip

* add more layering and fix issues

* add more strictness

* remove unnecessary assertion

* add missing checks

* fix indentation

* remove jsdoc
2020-01-29 20:35:11 -08:00