Chris LaFreniere
1fb3faeda1
Notebooks: Fix Internal Links on Windows ( #9513 )
...
* Improve workbench file path detection
* Use fspath instead
2020-03-09 18:10:24 -07:00
Chris LaFreniere
0a9a0d3f46
Ensure Active File is Highlighted in Books Viewlet ( #9338 )
...
* Add Reveal in Books editor tab context option
* Select item in books viewlet automatically
* changes
* easier than i thought it'd be
* Merge from Feat/create book
* Undo Merge from Feat/create book
* Use fsPath instead of path
* PR comments
* Fix tests
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com >
2020-03-05 23:43:22 -08:00
Chris LaFreniere
0f9d98730e
Improve find by tracking actual rendered text ( #9419 )
...
* Improve find by tracking actual rendered text
* Fix tests, add notebook md render
2020-03-03 16:56:11 -08:00
Cory Rivera
73d9b7f22a
Check if notebook model is undefined in setTrustForNewEditor. ( #9312 )
2020-02-26 11:17:56 -08:00
Cory Rivera
412214e193
Add charting functionality to SQL notebooks. ( #9306 )
2020-02-26 10:52:19 -08:00
Anthony Dresser
ab6fb810f8
move update model for notebook save to the input ( #8995 )
2020-02-19 22:01:07 -08:00
Anthony Dresser
1d0f76d26a
Setup files for workbench/services to be strict compiled ( #9168 )
...
* setup services to be strict compiled. fix some of the issues
* fix compile
* fix compile
* revert some undefined changes
2020-02-19 16:07:57 -08:00
Anthony Dresser
cec7753e3d
Final layering ( #9164 )
...
* move handling generated files to the serilization classes
* remove unneeded methods
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* wip
* remove jsdoc
* fix layering
* fix compile
* fix compile errors
* wip
* wip
* finish layering
* fix css
* more layering
* rip
* reworking results serializer
* move some files around
* move capabilities to platform wip
* implement capabilities register provider
* fix capabilities service
* fix usage of the regist4ry
* add contribution
* wip
* wip
* wip
* remove no longer good parts
* fix strict-nulls
* fix issues with startup
* another try
* fix startup
* fix imports
* fix tests
* fix tests
* fix more tests
* fix tests
* fix more tests
* fix broken test
* fix tabbing
* fix naming
* wip
* finished layering
* fix imports
* fix valid layers
* fix layers
* wip
* finish layering
* final layering
* finish layering
* fix spacing
2020-02-19 14:43:16 -08:00
ADS Merger
1e308639e5
Merge from vscode 9bc92b48d945144abb405b9e8df05e18accb9148
2020-02-19 03:11:35 +00:00
Anthony Dresser
506c6a5e5f
More Layering ( #9139 )
...
* move handling generated files to the serilization classes
* remove unneeded methods
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* wip
* remove jsdoc
* fix layering
* fix compile
* fix compile errors
* wip
* wip
* finish layering
* fix css
* more layering
* rip
* reworking results serializer
* move some files around
* move capabilities to platform wip
* implement capabilities register provider
* fix capabilities service
* fix usage of the regist4ry
* add contribution
* wip
* wip
* wip
* remove no longer good parts
* fix strict-nulls
* fix issues with startup
* another try
* fix startup
* fix imports
* fix tests
* fix tests
* fix more tests
* fix tests
* fix more tests
* fix broken test
* fix tabbing
* fix naming
* wip
* finished layering
* fix imports
* fix valid layers
* fix layers
2020-02-15 01:54:23 -06:00
Anthony Dresser
74b89a0a85
No console linting ( #9156 )
...
* add no-console linting and change to just using overrides for sql files
* whitespace
* fix tests
2020-02-14 21:13:16 -06:00
Cory Rivera
dd5c0ce08f
Maintain notebook trust status after saving. ( #9127 )
2020-02-14 10:07:02 -08:00
ADS Merger
73ea8b79b2
Merge from vscode 1fbacccbc900bb59ba8a8f26a4128d48a1c97842
2020-02-13 02:56:02 +00:00
Anthony Dresser
9af1f3b0eb
More layering ( #9111 )
...
* move handling generated files to the serilization classes
* remove unneeded methods
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* wip
* remove jsdoc
* fix layering
* fix compile
* fix compile errors
* wip
* wip
* finish layering
* fix css
* more layering
* rip
* reworking results serializer
* move some files around
* move capabilities to platform wip
* implement capabilities register provider
* fix capabilities service
* fix usage of the regist4ry
* add contribution
* remove no longer good parts
* fix issues with startup
* another try
* fix startup
* fix imports
* fix tests
* fix tests
* fix more tests
* fix tests
* fix more tests
* fix broken test
* fix tabbing
* fix naming
2020-02-12 18:24:08 -06:00
ADS Merger
085752f111
Merge from vscode 8a997f7321ae6612fc0e6eb3eac4f358a6233bfb
2020-02-11 07:08:19 +00:00
Anthony Dresser
0f934081e1
More layering and strictness ( #9004 )
...
* move handling generated files to the serilization classes
* remove unneeded methods
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* wip
* remove jsdoc
* fix layering
* fix compile
* fix compile errors
* wip
* wip
* finish layering
* fix css
* more layering
* remove no longer good parts
* fix issues with startup
* another try
* fix startup
2020-02-11 00:47:17 -06:00
Cory Rivera
3a8b74a311
Set notebook as trusted after executing a cell. ( #9108 )
...
* Also set trusted by default when opening a notebook without any code cells.
2020-02-10 17:03:57 -08:00
Chris LaFreniere
b4e30e17af
Remove unnecessary code to sql-vnext extension ( #9027 )
2020-02-06 17:37:46 -08:00
Chris LaFreniere
343daf58fe
Notebooks: Fix Padding on Mac SelectContainers in Toolbar ( #9021 )
...
* fix css on mac
* change to monaco workbench mac
2020-02-05 16:06:55 -08:00
Anthony Dresser
56695be14a
More layering and compile strictness ( #8973 )
...
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* remove jsdoc
2020-01-29 20:35:11 -08:00
Maddy
648287fa85
listen to command a and select the active element. ( #8969 )
...
* listen to command a and select the active element.
* type fix
2020-01-29 16:55:59 -08:00
Chris LaFreniere
de27f2c2a5
stop firing active cell change events unnecessary ( #8983 )
2020-01-29 13:54:48 -08:00
Anthony Dresser
fefe1454de
Merge from vscode 3c6f6af7347d38e87bc6406024e8dcf9e9bce229 ( #8962 )
...
* Merge from vscode 3c6f6af7347d38e87bc6406024e8dcf9e9bce229
* skip failing tests
* update mac build image
2020-01-27 15:28:17 -08:00
Cory Rivera
2eebcab74a
Make notebook cells selectable for tab navigation. ( #8946 )
2020-01-23 15:39:27 -08:00
Maddy
5ccc0fd97b
Implemented match case and whole wrd ( #8904 )
...
* Implemented match case and whole wrd
* removed unused ref
* renamed test method
* escape \
* refactored search
* added more tests
* updated tests appying match case and whole word to spcl characters
* regex update
* spcl to special
* non-capturing group added to the regex
* test
2020-01-23 07:28:12 -08:00
Anthony Dresser
bd7aac8ee0
Merge from vscode a234f13c45b40a0929777cb440ee011b7549eed2 ( #8911 )
...
* Merge from vscode a234f13c45b40a0929777cb440ee011b7549eed2
* update distro
* fix layering
* update distro
* fix tests
2020-01-22 13:42:37 -08:00
Cory Rivera
52e3c2f9c7
Clear cell execution count when clearing output. ( #8908 )
2020-01-21 13:56:38 -08:00
Maddy
74c2d16660
getter for markdown editor on edit mode ( #8871 )
...
* getter for markdown editor on edit mode
* use first and find to work-around the code editor changes
2020-01-14 15:29:55 -08:00
Anthony Dresser
2f6c944317
Add editor contribution tests ( #8784 )
...
* wip
* rewrite association
* fix tests
* add more tests
* fix tests
* fix more tests
* fix tests
2020-01-10 18:57:47 -08:00
Maddy
b1526603cc
Tests/notebook find tests ( #8827 )
...
* updates to existing book tests
* notebookFindModal tests
* remove commented code
* undo book test changes
* undo book test changes
* resolve the find array
* additional tests
2020-01-07 16:35:28 -08:00
Cory Rivera
d2e367c139
Use a single button for expanding and collapsing a notebook cell. ( #8797 )
2020-01-03 10:34:45 -08:00
Maddy
c3ddbba997
Only show find when modal is loaded and expand the collapsed cell on find. ( #8790 )
2020-01-01 20:17:50 -08:00
Anthony Dresser
4293d53e79
Merge from vscode d06f0e877ceaf3a35a283f1bfdc50927ec8dfd1e ( #8767 )
2019-12-22 08:53:45 -08:00
Maddy
778a34a9d2
Books/search within notebook ( #8426 )
...
* initial commit
* get notebook content
* skeleton for find in notebookModel
* add search function and keyboard shortcut
* add command for hiding find widget
* started on search logic
* continue search logic
* continue search logic
* add findcountchange listener
* notebook find position
* added css class
* hide find widget
* focus find input
* search for multiple occurrences in one line
* start notebook find decorations
* start adding decorations to notebook model
* added editor_model_defaults
* added cursor position
* merged master and resolved husky erros
* initial changes added to Lucyls base implementation
* pass NotebbokRange instead of Range to decorations
* changes after merging master
* temp changes for testing
* style updates from vscode merge
* implemented the empty methods and added supporting functionality from textModel
* just a little error checking
* It gets more and more yellow
* making highlight work between code cells
* highlight only word
* remove highlight on close and maintain the position
* cleanup of unused references
* clean up
* find between code cells refactored
* highlight markdown line and scroll to it
* find index fix
* find index fix
* code clean up
* remove commented code
* tslint fix for: Cannot use global 'NodeJS'
* linting rule fixes
* deltaDecoration base implementation on the base class
* moced class defnitions from interface fikle
* updated action names
* DOM.addClass instead of overwriting
* resooved conflicts
* moved 'find' code away from notebookmodel to sep class
* moved find realted code to seperate folder
* created notebookFindModel
* clean up
* highlight color changes
* spacing and typo fixes
* highlight correct element for nested elements
* do not iterate through paragraphs and li
* find accross notebooks
* keep track of index
* clear decorations on close
* floating promises
* maintain search context
Co-authored-by: Lucy Zhang <lucyzhang929@gmail.com >
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com >
2019-12-19 17:21:03 -08:00
Anthony Dresser
30d9e9c141
Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1 ( #8722 )
...
* Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1
* remove tests that aren't working
2019-12-18 00:14:28 -08:00
rajeshka
73b9849dd5
Toggle Trusted Button ( #8569 )
...
* Toggle Trusted Button
* Persist Trusted information to Cache
* Trusted toggle unit test fixed
* Updated test comment
2019-12-16 13:32:56 -08:00
Chris LaFreniere
826e069b63
Fix passing in connection profile ( #8689 )
2019-12-16 13:20:43 -08:00
Anthony Dresser
4ba6a979ba
Merge from vscode a4177f50c475fc0fa278a78235e3bee9ffdec781 ( #8649 )
...
* Merge from vscode a4177f50c475fc0fa278a78235e3bee9ffdec781
* distro
* fix tests
2019-12-11 22:42:23 -08:00
Chris LaFreniere
302e8305ef
add titles to collapse expand button ( #8607 )
2019-12-10 21:08:28 -08:00
Anthony Dresser
659f392196
add readonly method to editors ( #8630 )
2019-12-10 18:16:16 -08:00
Chris LaFreniere
bceb766d28
Notebooks: Fix Cancel for Connection Dialog to Actually Close Window ( #8626 )
...
* Fix connection dialog not going away on cancel
* Remove unnecessary change
2019-12-10 16:59:15 -08:00
Cory Rivera
184d4bbe27
Add units tests for Notebook Actions ( #8595 )
2019-12-09 15:37:40 -08:00
Chris LaFreniere
62565e0577
Notebooks: Only have One Connection in Attach To Dropdown ( #8582 )
...
* Have only one connection in attach to dropdown
* LGTM fixes
* Test fixes not unnecessarily changing context 2x
* PR Feedback
2019-12-08 11:03:51 -08:00
Anthony Dresser
4787d7ba5c
fix notebookinput matches function to work with replacement ( #8585 )
2019-12-05 16:53:36 -08:00
Anthony Dresser
f5ce7fb2a5
Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c ( #8525 )
...
* Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c
* remove files we don't want
* fix hygiene
* update distro
* update distro
* fix hygiene
* fix strict nulls
* distro
* distro
* fix tests
* fix tests
* add another edit
* fix viewlet icon
* fix azure dialog
* fix some padding
* fix more padding issues
2019-12-04 19:28:22 -08:00
Cory Rivera
9691fab917
Add code coverage tests for cell.ts ( #8564 )
2019-12-04 14:45:48 -08:00
Cory Rivera
8cc60fde90
Add code coverage tests for notebookUtils ( #8524 )
2019-12-02 14:19:37 -08:00
Anthony Dresser
43387f0d0b
Rework how we handle custom editors ( #5696 )
...
* update how we handle editors
* small edit
* handle changing languages
* implement generic language association
* implement notebook serializers
* fix tests
* formatting
* update how we handle editors
* small edit
* handle changing languages
* implement generic language association
* implement notebook serializers
* fix tests
* formatting
* fix broken
* fix compile
* fix tests
* add back in removed note book contributions
* fix layering
* fix compile errors
* fix workbench
* fix hanging promises
* idk why these changed
* fix change
* add comments to language change code
* fix a few bugs
* add query plan association
2019-11-24 19:22:11 -08:00
Maddy
66e1c01793
regex to encode & correctly ( #8441 )
2019-11-22 17:20:41 -08:00
Cory Rivera
632ca0685e
Add code coverage tests for notebookContexts.ts ( #8430 )
2019-11-22 11:23:34 -08:00
