ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-17 17:22:42 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,855 Commits 1 Branch 152 Tags
22a427f9347ef95045139b8a916ff48beaa51c4a
Commit Graph

1638 Commits

Author SHA1 Message Date
Anthony Dresser
22a427f934 Remove typings and replace missing methods with vscodes (#8217) 
* remove typings and replace missing methods with vscodes

* fix strict-null-checks

* fix tests
 2019-11-05 13:03:20 -08:00
Amir Omidi
1b88c10197 Some promise fixes (#8216) 
* Some promise fixes

* changes to how we're logging errors

* Fix the tests

* Fix a few other issues
 2019-11-05 11:50:39 -08:00
Charles Gagnon
399788ccc1 Fix row/column count and table aria label (#8219) 2019-11-05 09:52:59 -08:00
Charles Gagnon
08fde8719d Make declarative table read blank for empty text cells (#8215) 2019-11-05 08:02:37 -08:00
Anthony Dresser
ade68b184d Move code around for more linting (#8190) 
* testing

* moving around all the code

* fix strict nulls
 2019-11-04 10:41:28 -08:00
Cory Rivera
3c702c15e2 Initialize cell source to empty array if notebook file's source is undefined. (#8189) 2019-11-04 10:38:14 -08:00
Anthony Dresser
76e8805a6b Remove should (#8196) 
* remove should

* fix a few tests
 2019-11-04 09:59:18 -08:00
Charles Gagnon
5dc7049f8c Fix floating promises in connection widget (#8198) 
* Fix floating promises in connection widget

* PR feedback

* More feedback changes

* Couple missed promises
 2019-11-04 07:24:38 -08:00
Maddy
c2c64293f5 missed insiders-only check removal (#8184) 2019-11-01 17:06:38 -07:00
Amir Omidi
b62c0cf2ab More promise cleanup (#8100) 
* Some promise cleanup

* Handle more promise issues

* Remove changes that aren't needed anymore

* Use log service

* another one

* Be more explicit

* Some more promises cleaned up

* Handle promises here too

* Strings for errors

* Some more cleanup

* Remove unused imports
 2019-10-31 14:30:08 -07:00
BranislavGrbicMDCS
572a83dac7 Hidding error message for sql on demand on server dashboard (#8146) 
* Hidding error message for sql on demand

* Using constant instead of hardcoded value
 2019-10-31 21:25:39 +01:00
Alan Ren
23da6155dd fix the missing icon issue of expand/collapse btn (#8132) 2019-10-30 20:10:34 -07:00
Charles Gagnon
ef9321ef2c Add error messages to BDC dashboard page (#8103) 
* Add error messages to BDC dashboard page

* Remove testing code

* PR fixes
 2019-10-30 15:23:34 -07:00
Alex Ma
9eb319f392 ImageInsight Image Error Notification (#8086) 
* image visualization printout (needs localization)

* Add error image and log error

* "added alert error for invalid image"

* removed unnecessary spaces

* removed spaces on 61 and 66

* Added image and used notification service

* Removed unused import

* Changed wording for error
 2019-10-30 14:48:12 -07:00
Chris LaFreniere
dd270a78fc Notebooks: Improvements to Connection Profile Passing (#8105) 
* Fix relative images on notebook markdown pc

* PR feedback around replace ordering

* update databaseName when it's set to master

* usinng query as example
 2019-10-30 13:22:17 -07:00
Anthony Dresser
827e6162c7 fix import (#8116) 2019-10-30 13:11:29 -07:00
Alan Ren
9f54fbc8cc profiler icon issue (#8115) 2019-10-30 12:32:37 -07:00
Shafiq Ur Rahman
f8858a3511 Tab trap for modal (closes #5930) (#8043) 
* Tab trap for modal (closes #5930)

* Addressing PR comments

* Fixed formatting.
 2019-10-30 11:38:11 -07:00
Charles Gagnon
82e5221024 Fix modal event propagation (#8050) 
* Fix event propagation

* Remove unneeded onkeyup method

* Move event handling code into SQL classes
 2019-10-30 11:29:01 -07:00
Anthony Dresser
f7b8a019cd Remove references to noderequire (#8101) 
* remove references to nodequire

* change promise handling
 2019-10-30 10:04:52 -07:00
BranislavGrbicMDCS
a89788a020 Adjusting OE and hiding nodes for sql on demand (#8087) 2019-10-30 18:02:12 +01:00
Chris LaFreniere
62af81e88c Notebooks: Fix relative images not rendering on PC for Markdown Cells (#8091) 
* Fix relative images on notebook markdown pc

* PR feedback around replace ordering
 2019-10-29 19:48:57 -07:00
Amir Omidi
ab736466cd Some promise cleanup (#8092) 
* Some promise cleanup

* Handle more promise issues

* Remove changes that aren't needed anymore

* Use log service

* another one

* Be more explicit
 2019-10-29 17:04:46 -07:00
Kim Santiago
ce5eb00177 Fix schema compare include/exclude behavior (#8042) 
* don't uncheck difference if unsuccessful

* changes after rebasing to get schema compare fix

* First cut of column checkbox checking reactive to include opteration

* handle blocking dependencies and affected dependencies

* Changing the checked property of table to be list

* Addressing comments

* add map to keep row number of diff entries

* remove findDifferenceRow() since it isn't needed anymore

* fix scrolling to the top when checking/unchecking and add info message

* change checked to updateCells

* improve warning cannot include/exclude message
 2019-10-29 11:55:31 -07:00
Amir Omidi
428745e929 Cleanup the copy output (#8072) 
* Cleanup the copy output

* Use helper functions and cleanup promise handling
 2019-10-28 16:13:34 -07:00
Charles Gagnon
fa79e5b016 Fix for propagating aria-label title of form components to loading component (#8051) 2019-10-28 14:48:47 -07:00
Charles Gagnon
bd15a96b83 Make form components use title as aria-label (#8040) 2019-10-27 14:37:34 -07:00
Chris LaFreniere
3b1c9e910d serverManager to decide if server start needed (#8017) 2019-10-25 11:11:54 -07:00
Chris LaFreniere
5b29aef5f3 fix stdin cancel breaks notebook (#8012) 2019-10-25 10:52:18 -07:00
BranislavGrbicMDCS
c6a78456b8 Adjusting context menu for SqlOnDemand (#8018) 2019-10-25 17:33:17 +02:00
Chris LaFreniere
f7059a2365 Fix Issue when Saving Wrong Kernel (#7974) 
* Only fire kernelChangeEmitter after lang set

* Fix unused import found by lgtm

* Fix comment
 2019-10-24 22:13:18 -07:00
Chris LaFreniere
a33820ecdd Fix starting and separators in a row (#7861) 2019-10-24 15:20:58 -07:00
Alan Ren
34fe2b44cc remove insider build check (#7926) 
* remove insider build check

* fix welcome page not load issue
 2019-10-23 21:53:42 -07:00
Aditya Bist
a16bfbfedd Fix node infinitely loading when a firewall dialog is cancelled (#7970) 
* add back icons for azure actions

* fix firewall infinite loop

* formatting

* change message to firewall canceled

* fix tests
 2019-10-23 21:37:21 -07:00
Chris LaFreniere
a431ca7ef2 check for ownerDocument focus for focus (#7964) 2019-10-23 18:56:43 -07:00
Chris LaFreniere
c2022cac57 Fix for relative links not being resolved in notebook outputs (#7966) 
* Fix for relative links not being resolved

* Add comment
 2019-10-23 18:49:52 -07:00
Charles Gagnon
4a68ab4659 Hygiene linting for extensions + new rule (#7843) 
* linting for extensions + new rule

* Remove unneeded array

* Fix spelling mistake

* Fix bad merge
 2019-10-22 18:56:31 -07:00
Chris LaFreniere
4c24043cc8 Add Option to Halt Notebook when Error Occurs in SQL Kernel (#7884) 
* Add Option to Halt Nb when Error Occurs

* PR comments
 2019-10-22 18:19:36 -07:00
Kim Santiago
37426b0794 don't allow tabbing into table (#7769) 2019-10-22 16:25:37 -07:00
BranislavGrbicMDCS
397f6afaf1 ADS changes for new engine edition (#7695) 
* Sql on demand changes

* Formating files

* Removing features for new Engine Edition

* Fixing Restore & Backup issue. Adding support for multiple conditions per flavor

* tabifying

* Formating documents

* Work in progress

* Resolving comments

* Resolving comments.

* Fixing typo
 2019-10-22 12:50:15 +02:00
Anthony Dresser
1e22f47304 Merge from vscode c58aaab8a1cc22a7139b761166a0d4f37d41e998 (#7880) 
* Merge from vscode c58aaab8a1cc22a7139b761166a0d4f37d41e998

* fix pipelines

* fix strict-null-checks

* add missing files
 2019-10-21 22:12:22 -07:00
Anthony Dresser
06e86e57e7 Strict null on some query and connection (#7300) 
* wip

* make connection work with strict-nulls

* change comments

* fix tests; remove unneeded type forcing

* address feedback

* adjust the logic of query editor

* clean up typing
 2019-10-21 15:50:12 -07:00
Maddy
b8ad7e3072 Updates to package.json to show books on stable (#7836) 
* Updates to package.json to show books on stable

* remove notebookQuality context key

* renamed untitiled to unsaved
 2019-10-21 14:26:59 -07:00
Chris LaFreniere
597a0cad6b Add (dummy) IPyWidgets Renderer (#7849) 2019-10-21 14:22:44 -07:00
Kevin Cunnane
c1e95a2246 Fix errors due to icon to codicon rename in VSCode (#7837) 
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
  - acounts view
  - new tab view in dashboard
 - many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.

Fixes #7827
 2019-10-21 12:02:30 -07:00
Charles Gagnon
0246c3f895 Fix ModelView tree A11y issue (#7835) 
* Fix tree A11y issue

* Toggle expanded state on enter

* Move onkeydown method to base class
 2019-10-20 21:42:55 -07:00
Chris LaFreniere
e3ae5263c6 Starting Fewer Jupyter Servers for Notebooks (#7744) 
* Start fewer Jupyter servers

* Windows fix for drive casing

* PR Feedback

* Quick fix

* Fixing bug

* Ensure environment variables set 4 session startup

* test fix

* Dummy commit to update comment
 2019-10-20 21:38:58 -07:00
Chris LaFreniere
2ee3840650 First improvements for SQL Cell Looping (#7733) 
* First improvements

* clear results

* cleanup

* error handling
 2019-10-18 17:12:10 -07:00
Amir Omidi
2237d286b6 XML output is truncated (#7748) 
* QueryExecutionOptions change

* add config points

* Change api type used

* Revert "QueryExecutionOptions change"

This reverts commit 7adc3b032b5e4bc92234d337f0a145f0963c2d34.

Let's not change the azdata file.

* Change the signature of this api

* Change the event

* Change SqlCMD to use the API properly

* Add type

* Change type to interface - handle existing files

* Remove unused import

* Delete useless code

* Remove unnecessary code

* Fix the interface

* remove whitespace
 2019-10-18 16:35:45 -07:00
Anthony Dresser
4c8f3ddfd3 Add scripting contributions for explorer widget (#7830) 
* add scripting contributions for explorer widget

* utilize or
 2019-10-18 14:26:43 -07:00