ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-28 09:35:38 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,057 Commits 1 Branch 152 Tags
27823e99000093dfa20d6747b68ac69f268f06bb
Commit Graph

308 Commits

Author SHA1 Message Date
Vasu Bhog
27823e9900 Fix CalloutDialog not opening after bad link (#16051) 
* fix null parentNode
 2021-07-09 09:01:48 -07:00
Charles Gagnon
8f202d91b6 editorReplacer -> editorOverride (#16041) 
* editorReplacer -> editorOverride

* Update lifecycle phsae

* add back input factories

* Add comment

* add back tests

* comments

* fix log

* comments
 2021-07-09 08:46:50 -07:00
Alan Ren
c5893a488f toolbar separator overlapping with other items (#16012) 
* separator overlapping with other items

* Update notebook.css
 2021-07-07 14:44:41 -07:00
Lucy Zhang
f8c4d332bb add height css (#16026) 2021-07-07 13:49:33 -07:00
Lucy Zhang
9ba4057a3c fix notebook icon highlights (#16009) 2021-07-06 17:50:54 -07:00
Lucy Zhang
9ac1f16cea Fix notebook toolbar when ADS screen width is decreased (#15987) 
* fix toolbar when width is decreased

* remove height css
 2021-07-06 11:45:46 -07:00
Barbara Valdez
0e10e3e3ca fix WYSIWYG toolbar (#15901) 
* fix WYSIWYG toolbar

* add height

* remove new rule and specify css selectors
 2021-06-30 17:28:11 -07:00
Lucy Zhang
189fe762a9 remove layout call in output component init (#15905) 2021-06-28 14:48:44 -07:00
Chris LaFreniere
f7a723d98d Notebooks A11Y: Add button role for Placeholder Links (#15851) 
* Add button role

* Add aria-label

* localize aria label
 2021-06-23 16:48:01 -07:00
Maddy
90b90afeab remove images from metadata on source update (#15640) 
* remove images from metadata on update

* update comment

* reset only on html update

* add comment

* fixes

Co-authored-by: chgagnon <chgagnon@microsoft.com>
 2021-06-21 13:55:37 -07:00
Alan Ren
03f31a865a use more specific css selectors (#15826) 2021-06-18 18:33:25 -07:00
Cory Rivera
d92c1d5ca8 Add max size setting for Rich Text undo history in notebooks. (#15793) 2021-06-18 16:04:45 -07:00
Chris LaFreniere
06e7d4d489 Let parent control width for text cell preview (#15800) 2021-06-18 12:51:58 -07:00
Charles Gagnon
d96835c083 Fix secondary actions for Notebook editor toolbar (#15788) 2021-06-17 14:52:36 -07:00
Charles Gagnon
3cb2f552a6 Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681) 
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>
 2021-06-17 08:17:11 -07:00
Charles Gagnon
db3a0ef7ac Trim pathname for link callout file paths (#15716) 
* Don't use pathname for link URLs

* Trim pathname instead
 2021-06-15 09:52:27 -07:00
Cory Rivera
a61462a2c0 Improve Undo and Redo functionality for notebook Rich Text editors (#15627) 2021-06-08 13:24:58 -07:00
Maddy
d04451985c Highlight all matches in Notebook on Find (#15562) 
* iterate over every cell and highlight ranges.

* fix yellow for all matches and orange for current

* fix

* avoid duplicate deltaDecorations call

* initialize on declare
 2021-06-04 15:45:51 -07:00
Maddy
b490d53284 Add image as attachment on copy/paste into cell (#15602) 
* add pasted image as attachment

* handle duplicate image logic

* replace with regex

* address PR comments
 2021-06-04 15:20:18 -07:00
Maddy
ed7521e846 flex style in split mode (#15612) 2021-06-03 11:27:48 -07:00
Vasu Bhog
1de05a2339 Fix WYWIWYG Table cell adding new line in table cell (#15594) 
* fixes new line in table cell

* add test and fix for table head
 2021-05-28 13:47:50 -07:00
Daniel Grajeda
bf21db99c4 Fix Gridstack DD import (#15573) 
* Gridstack dd native import fix

* Add gridstack package to remote

* Include gridstack to workbench.html and workbench-dev.html
 2021-05-27 14:14:32 -07:00
Maddy
7f6ddc897b fix css to contain image (#15574) 2021-05-26 12:25:13 -07:00
Vasu Bhog
730367494b Run with Parameters learn more link to use correct format and kernels (#15547) 
* indicate to users correct format and kernels

* add test for unsupported kernel

* replace with enum
 2021-05-25 17:39:19 -07:00
Charles Gagnon
399406b732 Update action run return type (#15568) 
* Update action run return type

* fix tests

* Update rest

* Add back null checks
 2021-05-25 14:52:39 -07:00
Cory Rivera
d582a955dd Add Markdown as a default editing option for text cells (#15540) 2021-05-21 10:05:55 -07:00
Lucy Zhang
43e8fde775 Update Python to 3.8.8 (#15278) 
* update python fwlinks and remove bundle ver

* start fixing path for users with python 36

* prompt user for python version upgrade

* update python path after removing 3.6

* prompt users to upgrade and show pkg warning

* make prompt async

* remove python bundle ver from ML extension

* shutdown python 3.6 before deleting

* check useExistingPython before update prompt

* add dont ask again option

* remove 3.6 after installing 3.8

fix merge conflict

* give option to remove python36

* list user installed pip packages in warning

* create notebook to install pip packages

* update getPythonExePath method and add comments

* clean up code

* add comments

* pr comments

* add comment

* remove option to keep python36

* shutdown active servers before removing python36

* fix error removing old python w/ path change

* update to 3.8.10

* restart sessions for mac/linux
 2021-05-19 15:15:07 -07:00
Alan Ren
d36918081a Inform the user about the config for filtering (#15510) 
* Inform the user about the config for filtering

* comments
 2021-05-19 13:03:15 -07:00
Daniel Grajeda
2781279644 Notebook views UI (#13914) 
* Add notebook editor

Introduce notebook editor component to allow for separate notebook displays in order to accomodate notebook views

* Localize notebook views configuration title

* Refactor view mode and remove the views configuration while it is unused

* Only fire view mode changed event when the value has been changed

* Remove notebook views contribution

* Add metadata capabilities

* Notebook views definitions

* Add notebook views models

* Views test

* Rename type arguments

* Additional tests

* Fix unused import

* Notebook views changes

* Add notebookviews.css

* Update notebookViewModel.ts

* Add cell toolbar styles

* Upgrade gridstack

* Add gridstack styles

* Remove ununsed references

These are part of the next PR and not available yet

* Remove gridstack static file

* Add gridstack as a module in the electron unit tests

* Spacing fixes

* Add copyright notice

* Remove commented code

* Spacing fixes in notebook styles

* Move handle svg to image

* Add typing for gridstack

* Move notebook styles to file

* Rename selector constant

* Rename grid css file

* Add nb-grid-stack class to views grid

* Cell toolbar style adjustments

* Remove unused imports

* Update .eslintrc.json

* Fix outdated instantiation of LabeledMenuItemActionItem

* Address feedback

* Fix from update to main
 2021-05-17 10:16:43 -07:00
Charles Gagnon
c54f991e60 Fix actionbar trigger key handling (#15488) 
* Fix actionbar trigger key handling

* fix compile error
 2021-05-14 16:31:15 -07:00
Chris LaFreniere
af96cb92db Handle key_up in callout dialog (#15472) 2021-05-14 11:40:21 -07:00
Chris LaFreniere
624c07947c Notebooks: Fix Table Generation into Pure Markdown When No thead Exists (#15423) 
* works without alignment

* Alignment working

* Add comment

* Remove outdated comment
 2021-05-12 16:28:23 -07:00
Charles Gagnon
c015338ed4 Fix dashboard icons (#15400) 
* Fix dashboard icons

* Split out custom SQL menu items

* Put on same line
 2021-05-11 12:41:45 -07:00
Lucy Zhang
2a354aef09 basic text cell functionality smoke test (#15195) 2021-05-06 15:53:20 -07:00
Vasu Bhog
cb06ca07c0 Fixes the empty parameter cell and multi parameters on one line (#15234) 
* fix two bugs

* work on empty parameter cell and format properly

* add empty cell tests
 2021-05-06 14:48:38 -07:00
Maddy
ef8b26b7ae Insert local/online images using image call out (#15238) 
* changes from Chris's branch and cell model updates

* get base64 value

* handle spaces in image names

* add comments

* add tests for imageCallOut dialog

* format document for hygiene errors

* address comments

* check base64 validity using regex

* replace space with regex

* add parameter and return type

* split into two functions

* move functions to fileUtilities

* correct import

* fix for layering issue

* revert file function changes
 2021-04-30 19:43:55 -07:00
Charles Gagnon
be8a55cef0 Add back open view keybindings (#15264) 2021-04-28 12:17:36 -07:00
Karl Burtram
867a963882 Merge from vscode bead496a613e475819f89f08e9e882b841bc1fe8 (#14883) 
* Merge from vscode bead496a613e475819f89f08e9e882b841bc1fe8

* Bump distro

* Upgrade GCC to 4.9 due to yarn install errors

* Update build image

* Fix bootstrap base url

* Bump distro

* Fix build errors

* Update source map file

* Disable checkbox for blocking migration issues (#15131)

* disable checkbox for blocking issues

* wip

* disable checkbox fixes

* fix strings

* Remove duplicate tsec command

* Default to off for tab color if settings not present

* re-skip failing tests

* Fix mocha error

* Bump sqlite version & fix notebooks search view

* Turn off esbuild warnings

* Update esbuild log level

* Fix overflowactionbar tests

* Fix ts-ignore in dropdown tests

* cleanup/fixes

* Fix hygiene

* Bundle in entire zone.js module

* Remove extra constructor param

* bump distro for web compile break

* bump distro for web compile break v2

* Undo log level change

* New distro

* Fix integration test scripts

* remove the "no yarn.lock changes" workflow

* fix scripts v2

* Update unit test scripts

* Ensure ads-kerberos2 updates in .vscodeignore

* Try fix unit tests

* Upload crash reports

* remove nogpu

* always upload crashes

* Use bash script

* Consolidate data/ext dir names

* Create in tmp directory

Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Christopher Suh <chsuh@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
 2021-04-27 14:01:59 -07:00
Vasu Bhog
c66a8ca171 fix parameterized notebook output (#15233) 2021-04-27 12:40:49 -07:00
Maddy
fcaaf1cb29 fix the find highlight issues (#15149) 
* register mode changes, remove cleanMarkdownLinks

* fixes

* test fixes and scroll to center change
 2021-04-22 10:13:30 -07:00
Vasu Bhog
6951bf3b90 Ability to see and edit links in split view/markdown mode (#15150) 
* callout dialog selects link properly in split/markdown mode

* use regex for links
 2021-04-20 23:33:14 -07:00
Charles Gagnon
e7e4828703 Fix 'nodebookInputFactory' name (#15188) 2021-04-19 15:18:26 -07:00
Vasu Bhog
3a1885491f Update run w/parameters icon and increment parameterized notebook (#15127) 
* update icon and increment parameterized notebook
 2021-04-14 15:28:27 -07:00
Aditya Bist
e151668c81 Links handling in commands (#15118) 
* format

* update external options type

* add command flag for command

* Allow commands in Notebooks

Co-authored-by: chgagnon <chgagnon@microsoft.com>
 2021-04-14 13:06:45 -07:00
Alan Ren
8d098c227d use context view provider to show the filter (#15106) 
* use context view provider

* handle promise

* replace .then with .catch
 2021-04-13 11:34:26 -07:00
Barbara Valdez
f712c14b93 fix search loading animation (#15063) 2021-04-08 15:29:40 -07:00
Vasu Bhog
d76a6698a9 [Notebook] Run Parameters Action openNotebook Functionality in Core (#14978) 
* NotebookService update

* openNotebook functionality in NbService

* Add tests for RunParametersAction
 2021-04-08 14:48:37 -07:00
Barbara Valdez
4f67f32262 fix anchor links in wysiwyg (#14950) 
* fix anchor links in wysiwyg
 2021-04-08 10:56:11 -07:00
Vasu Bhog
04af3e161a See and Edit Selected Links in Callout Dialog (#14987) 
* Add URL label to linkCallout

* add test for file link
 2021-04-06 11:51:53 -07:00
Maddy
43db30d1da Add more Notebook telemetry events (#14755) 
* initial checkin

* telemetry for search in notebooks

* telemetry for move notebook

* address comments

* feedback changes

* fix tests paasing NullAdsTelemetryService

* move changeKernel telemetry higher up

* remove telemetry service

* Fix new Notebook events (#14982)

* Notebook telemetry fixes

* update2

* Move event location

* remove service

* remove unused

Co-authored-by: chgagnon <chgagnon@microsoft.com>
 2021-04-05 16:08:39 -07:00