Alex Ma
298402647d
Added error handling service for providers ( #21627 )
...
* added prototype errorHandlerService
* added initial contracts
* Added WIP client sent request function
* added WIP signature for handleOtherError to resourceProviderService
* made some small fixes
* removed unnecessary resourceProviderId
* added updates to contracts and resourceProvider
* moved error codes to azdata proposed
* added connection type instead of profile
* added WIP handleOtherError code
* added fix for send
* added WIP change password function in resource provider
* added work in progress error handling thread
* added errorHandler interface
* added result error check
* renamed errorHandling namespace to diagnostics
* WIP rename of errorhandler
* light cleanup
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/machine-learning (#21514 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Stops second invocation of createNewSession while expanding OE tree items on disconnected servers (#21437 )
* Debounces second invocation while expanding OE tree items
* Minor clean up
* Adjusts debounce time
* Adding temp trace comments
* Adds missing semicolon
* Removes debouncer to stop 2nd newSession calls
* Removes temp trace comments
* Updates comment
Co-authored-by: Alan Ren <alanren@microsoft.com >
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/admin-tool-ext-win (#21546 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix resource endpoints to end with slash (#21540 )
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/azcli (#21543 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/arc (#21544 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* renamed diagnostics service slightly
* registered service
* added work in progress diagnostics implementation
* small changes
* added new diagnostics exe
* Changes for Diagnostics Service (#21583 )
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com >
* WIP provider changes
* added changes for errorDiagnosticsService
* removed stuff from mssql.
* made fix to connectionManagementService
* added error catch
* added small changes
* more small changes made
* added small changes to handleOtherError
* moved changePassword to CMS
* added testErrorDiagnosticsService
* Added provider-based handling for change password/generic error handling. (#21662 )
* WIP rework for error connection change
* added connectionProfileDuringError
* added working password reset
* added comments
* consolidated connection profile conversion
* added additionalObjects parameter.
* removed unnecessary error profile grab
* added comments
* added changes to parameters and comments
* added changes and params
* added handleConnectionErrorParam
* added more changes
* added async
* added params and more
* added many fixes
* added updated documentation
* added WIP password change dialog with await
* added error handling
* added comment
* added options as parameters
* cleaned up parameters
* added async
* added check fixes
* Added username to title
* added server name to dialog
* Added dialog changes
* Revert "Added dialog changes"
This reverts commit c2bdcd16f4a0dffdc643ef9cae1c1a20642ac512.
* Revert "added server name to dialog"
This reverts commit dbd22e80461b5a068643f0c2d6728adce4010978.
* Revert "Added username to title"
This reverts commit 6d936b4d5f97f9345f8ec2fdbbcf6b52df18820a.
* Revert "added check fixes"
This reverts commit f58081a5af3276766e2042b4d671455b18add9a7.
* Revert "added async"
This reverts commit dd1198e26ec7542ec51add0628f588361d674299.
* Revert "cleaned up parameters"
This reverts commit 51135c9f9db452104697483779d8df15b6430717.
* Revert "added options as parameters"
This reverts commit b167804a2410558bbe60042e017ae2c77af7697f.
* Revert "added comment"
This reverts commit 0ad37326a3e025e88f715e3f2547be6825597a8d.
* Revert "added error handling"
This reverts commit 69340980d2c84056a2bcf126ea77f4b5ed4cddf3.
* Revert "added WIP password change dialog with await"
This reverts commit 9e43113e07b10421b39575f6c7dd14287662b90d.
* added a fix to check
* added fixes
* added back in change password changes
* added in comment
* added suggested changes
* removed param colons
* Update extensions/mssql/src/errorDiagnostics/errorDiagnosticsProvider.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* fixed conversion and provider dialog
* altered comments
* Update src/sql/platform/connection/common/utils.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* renamed Id
* Update src/sql/platform/connection/common/utils.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Improvements for Change password dialog + logs added (#21794 )
* Improvements for Change password dialog + logs added
* Include server
* fixed tab space
* added comment
---------
Co-authored-by: Alex Ma <alma1@microsoft.com >
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* added fix to id to extHostErrorDiagnostics
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com >
Co-authored-by: Alan Ren <alanren@microsoft.com >
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com >
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com >
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
2023-01-31 14:31:12 -08:00
Karl Burtram
ac4afbec6c
Add allow list of valid notebook command uris ( #163322 ) ( #21701 )
...
* Add allow list of valid notebook command uris (#163322 )
This restricts notebooks to run three command uris. These 3 commands should all be safe to run, even with untrusted inputs
* Fix incorrectly resolved merge conflict
Co-authored-by: Matt Bierner <matb@microsoft.com >
2023-01-23 12:01:53 -08:00
Karl Burtram
cabe158f07
Normalize resources when checking valid roots ( #163327 ) ( #21700 )
...
Fix MSCR 74267
Fix https://github.com/microsoft/vscode-internalbacklog/issues/3140
Remove extra indexOf check
This could cause failures for files such as `img..png`
Co-authored-by: Matt Bierner <matb@microsoft.com >
2023-01-23 12:01:36 -08:00
Karl Burtram
ce0710a4b4
Safer construction of notebook html ( #170987 ) ( #21699 )
...
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com >
2023-01-23 12:00:33 -08:00
Hai Cao
29c8d4bd3d
port fix for vscode issue 160827 ( #21457 )
2022-12-21 10:37:55 -08:00
Kim Santiago
a4db7309af
Fix schema compare not always showing diff color highlighting ( #21413 )
...
* Fix schema compare not always showing diff color highlighting
* move helper functions into diffEditorWidget.ts
2022-12-14 17:24:10 -08:00
Charles Gagnon
62d5c1f2d6
Fix action dropdowns focusing hidden button & fix ext action button ( #21326 )
2022-11-29 22:41:48 -08:00
Karl Burtram
6b9d5db145
Update Electron to 19.1.3 ( #21244 )
...
* chore: bump electron@18.0.0-beta.4
* Merge commit
* chore: update electron@19.0.17 (#161027 )
* chore: update electron@19.0.17
* chore: update API typings
* fix: compilation errors
* build: add libcups dependency
* chore: update electron@19.1.3 (#164864 )
* Update yarn
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2022-11-16 13:52:02 -08:00
Cory Rivera
a37d6230f9
Remove API compatibility layer for VS Code notebook extensions ( #21225 )
2022-11-15 10:38:41 -08:00
Aasim Khan
c8a80a5270
Adding SQL Carbon edit comment ( #21202 )
2022-11-10 15:46:05 -08:00
Aasim Khan
298cc4676b
Updating id generation logic to avoid substring overlaps ( #21181 )
2022-11-09 15:40:20 -08:00
Karl Burtram
f1cb925543
Fix open file on drop-n-drop ( #21006 )
2022-11-03 13:40:42 -07:00
Charles Gagnon
fb05c4304e
Switch to 1DS endpoint ( #20769 )
...
* Update to 1DS client
* remove product config
* Update ai keys
* use our own event prefix
* re-enable telemetry
* Update distro and remove default enableTelemetry
* distro
* Remove asimovKey references
* add comment
* distro
* distro
* distro
* add files that break precommit hook
* cleanup/fixes
* distro
* distro + event prefix update
* distro
* more
2022-11-03 08:45:06 -07:00
Hai Cao
7ee9a22f03
add Encryption related welcome msg ( #21048 )
2022-11-01 09:42:16 -07:00
Karl Burtram
e0e333c35f
Fix lost results on query editor save ( #21043 )
...
* Fix lost results on query editor save
* Fix typos
2022-10-31 14:51:12 -07:00
Barbara Valdez
275a772496
Reimplement drag and drop with the new interface ( #21037 )
...
* re enable drag and drop in book tree view
2022-10-31 10:12:23 -07:00
Hai Cao
e28c3894f6
Fix settings referring to VS Code ( #21019 )
...
* update VS Code to ADS in settings
* update github extension setting from VS Code to ADS
* update description of github extension
2022-10-28 13:01:58 -07:00
Charles Gagnon
9ea5a66c52
Fix embedded images not rendering ( #21021 )
2022-10-27 22:59:03 -07:00
Cory Rivera
5f6eed12c2
Re-enable .NET Interactive in Ipynb notebooks ( #21002 )
2022-10-27 13:49:37 -07:00
Hai Cao
540ebd6f7f
remove "New File..." from File menu ( #20999 )
...
* remove New File... from File menu
* doc
2022-10-27 09:45:37 -07:00
Charles Gagnon
8534b12ee5
Fix extension gallery engine version check ( #21000 )
...
* Fix extension gallery engine version check
* disable extension scanner tests
* edit tag
2022-10-26 22:46:03 -07:00
Alan Ren
e691263956
fix the contrast rate issue of couple view icons in activity bar ( #21003 )
...
* fix connections and notebooks view icon issue
* update name
* remove css reference
2022-10-26 19:27:42 -07:00
Alan Ren
c811303570
bring back welcome page ( #20969 )
2022-10-25 12:35:32 -07:00
Christopher Suh
ab958a2724
quick draft PR for not throwing when looking for a chunked password ( #150402 ) ( #20956 )
...
* quick draft PR for not throwing when looking for a chunked password
* update comment with more info
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local >
Co-authored-by: Ian Huff <ianhu@microsoft.com >
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local >
2022-10-24 17:48:06 -07:00
Alan Ren
42d2c6d656
Fix disabled state for debug toolbar icons ( #149172 ) ( #20942 )
...
* Use opacity for disable debug toolbar icons
* Update action bar disabled foreground styles
Co-authored-by: David Dossett <ddossett@microsoft.com >
2022-10-24 12:19:19 -07:00
Karl Burtram
7f0dd5ac1d
Load angular prior to loader.js ( #20934 )
...
* Load angular prior to loader.js
* Bump distro
2022-10-24 09:00:55 -07:00
Karl Burtram
daf81cc9e7
Fix extension load issues on insider build ( #20920 )
2022-10-21 14:07:22 -07:00
Karl Burtram
8a3d08f0de
Merge vscode 1.67 ( #20883 )
...
* Fix initial build breaks from 1.67 merge (#2514 )
* Update yarn lock files
* Update build scripts
* Fix tsconfig
* Build breaks
* WIP
* Update yarn lock files
* Misc breaks
* Updates to package.json
* Breaks
* Update yarn
* Fix breaks
* Breaks
* Build breaks
* Breaks
* Breaks
* Breaks
* Breaks
* Breaks
* Missing file
* Breaks
* Breaks
* Breaks
* Breaks
* Breaks
* Fix several runtime breaks (#2515 )
* Missing files
* Runtime breaks
* Fix proxy ordering issue
* Remove commented code
* Fix breaks with opening query editor
* Fix post merge break
* Updates related to setup build and other breaks (#2516 )
* Fix bundle build issues
* Update distro
* Fix distro merge and update build JS files
* Disable pipeline steps
* Remove stats call
* Update license name
* Make new RPM dependencies a warning
* Fix extension manager version checks
* Update JS file
* Fix a few runtime breaks
* Fixes
* Fix runtime issues
* Fix build breaks
* Update notebook tests (part 1)
* Fix broken tests
* Linting errors
* Fix hygiene
* Disable lint rules
* Bump distro
* Turn off smoke tests
* Disable integration tests
* Remove failing "activate" test
* Remove failed test assertion
* Disable other broken test
* Disable query history tests
* Disable extension unit tests
* Disable failing tasks
2022-10-19 19:13:18 -07:00
Charles Gagnon
3005d5435f
Add preview features enabled flag to issue reporter info ( #20808 )
...
* Add preview features enabled flag to issue reporter info
* fix tests
* fix key
2022-10-11 15:46:32 -07:00
Charles Gagnon
7b05194e77
Add app quality to extension API ( #20731 )
...
* Add app quality to extension API
* Comment
* Special case rc1 to stable
2022-10-05 14:42:23 -07:00
Charles Gagnon
4bd2befefe
Use ADS name for telemetry log ( #20713 )
2022-10-03 14:07:46 -07:00
Charles Gagnon
c7eefb28cb
Fix null ref error in terminal service ( #20656 )
2022-09-23 12:22:13 -07:00
Charles Gagnon
509e4b0509
Move legacy tree from vs to sql ( #20622 )
...
* Move legacy tree from vs to sql
* fix tests
* exemption
* Fix lint
2022-09-19 15:19:40 -07:00
Charles Gagnon
a78a158acd
Add saved files to recently opened ( #20470 )
2022-08-29 09:04:59 -07:00
Alan Ren
a39d73da24
install another version is not supported ( #20300 )
2022-08-10 15:36:59 -07:00
Kim Santiago
3196e99bd6
fix diff editor colors not getting reversed after vscode merge ( #20118 )
2022-07-20 14:00:01 -07:00
Charles Gagnon
ba1f4db745
Make createEditorInput async ( #20038 )
2022-07-14 19:39:52 -07:00
Charles Gagnon
050cb16619
Fix error when installing extensions from gallery ( #20012 )
...
* Fix error when installing extensions from gallery
* update
2022-07-12 10:36:08 -07:00
Karl Burtram
e75beacb6d
Fix button links on welcome page ( #20006 )
...
* Fix button links on welcome page
* Fix spelling typo
2022-07-12 08:13:29 -07:00
Karl Burtram
6eda44f828
Fix errors in 'build' script directory ( #20004 )
...
* Update build scripts
* Update build files
* fix build errors
2022-07-11 23:23:24 -07:00
Aasim Khan
53a0388858
Deleting old query plan code ( #19996 )
2022-07-11 19:14:47 -07:00
Karl Burtram
26455e9113
Merge vscode source through 1.62 release ( #19981 )
...
* Build breaks 1
* Build breaks
* Build breaks
* Build breaks
* More build breaks
* Build breaks (#2512 )
* Runtime breaks
* Build breaks
* Fix dialog location break
* Update typescript
* Fix ASAR break issue
* Unit test breaks
* Update distro
* Fix breaks in ADO builds (#2513 )
* Bump to node 16
* Fix hygiene errors
* Bump distro
* Remove reference to node type
* Delete vscode specific extension
* Bump to node 16 in CI yaml
* Skip integration tests in CI builds (while fixing)
* yarn.lock update
* Bump moment dependency in remote yarn
* Fix drop-down chevron style
* Bump to node 16
* Remove playwrite from ci.yaml
* Skip building build scripts in hygine check
2022-07-11 14:09:32 -07:00
Charles Gagnon
ebb1dcdfba
Update telemetry endpoints ( #19841 )
...
* Update telemetry endpoints
* Bump sql-assessment package
2022-06-28 09:16:29 -07:00
Charles Gagnon
c24305f9d8
Move query history into extension ( #19794 )
...
* initial
* more
* Remove connectionId
* cleanup
* cleanup
* Remove core contributions, add to panel by default
* Add enabled state
* Update config
* cleanup
* Move
* Remove newlines
* update README
2022-06-22 12:37:32 -07:00
Alan Ren
31dea2f5ee
port vscode changes ( #19754 )
...
* add aria-description support for selectbox
* type check
2022-06-16 13:24:35 -07:00
Alan Ren
e24f316ab7
fix selected state of select boxes ( #19743 )
...
* fix the selected state
* add comments
* validate parameters
2022-06-15 20:41:07 -07:00
Alan Ren
c75e95599f
add aria description ( #19734 )
...
* add aria description
* type check
2022-06-15 14:46:49 -07:00
Alan Ren
ba82444229
additional data property to error object and use it for table designer scenarios ( #19713 )
...
* add data property to error object
* vbump sts
2022-06-13 16:18:27 -07:00
Aasim Khan
36c480699f
Surfacing extension install errors ( #19613 )
...
* Surfacing extension install error
* Fixing error property
* removing unncessary await
* Fixing error type and message
* Fixing some more strings
* Adding missing period
* Consolidating some strings
* consolidating strings
* revert vbump
* Switching to ExtensionManagementError
2022-06-03 19:41:09 -07:00
Nemanja Milovančević
65ef41d53d
UI for the Backup/Restore Managed Instance Feature ( #19244 )
...
* Rebase from main branch
* Made mssql a module
* remove rpc specific stuff
* Added create sas RPC call
* Backup to url works now
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* After rebase
* Removed duplicate symbol
* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension
* Removed AzureBlobProvider, removed AzureBlobService feature
* renamed blob to azureblob, converted thenable to promise
* Simplify API
* fixes
* docs update, blob to azureblob update
* UI design first commit
* Detected Managed Instance, trying to script backup to url
* azure subscription api added, but ADS crashes
* Created url dialog component and added link account
* Changed backup component UI logic
* Changed b/r UI, added restore from URL, detected MI from restore component
* Removed mocked and added real Azure API, changed RestoreDialog UI
* Added file fetching API
* added create sas RPC call
* Backup to url works now
* Fixed some bugs
* Moved createSas RPC to the BlobService
* Relocated createSas RPC from sql-dataprotocolclient to the mssql
* Rebase createSas changed to the backupRestoreManagedInstance
* PR comments fix
* Enabled backup to url for gov clouds
* Replaced anchor element with Link class
* Fixed pick azure account logic
* Removed duplicates from eslintrc
* Fixed url browser dialog
* Fixed restore UI, disabled url empty url browser dropdowns, fixed backup OK button
* bumped sts version
* bumped sts version
* Fix config
* Fixed URL browser dialog UX
* Backup and restore dialog fix
* Referencing azure resource types directly
* Scoped url browser dialog css classes
* Made the url browser dialog field a local variable
* moved url browser files from fileBrowser to the urlBrowser folder
* Changed deviceType from number to enum
* Added all device type options
* Moved mssql
* Added MI backup button comment
* Removed unhelpful comment
* Revert differential copy only backup mistake
* Renamed azurebrowser to urlBrowserDialog
* Localize create sas button label
* Removed unnecessary spinner
* Use UTC date instead of locale date
* Removed * and added required flag
* Use async instead of nested thens
* Added target database tooltip
* Using deferred promise instead of event emitter
* Added error handling to the url browser dialog
* Registered backup component elements
* Register backup component listeners
* Removed redundant setDefaultBackupPaths call
* Added setBackupPathList docs
* Add return types
* Remove code from comment
* Register restore dialog elements
* Register restore dialog listeners
* Pass engine edition enum instead of boolean
* Capitalize enum values
* DatabaseEngineEdition fix
* Use DeviceType instead of number
* Use deferred pointer
* Add new ModalDialogName
* Use constructor fields
* Register URL browser dialog components
* Remove unnecessary helper function
* nextYear function doc and move
* split registerListeners method
* showDialog returns promise
* Backup device type comment
* Pass aria label through constructor
* Fix backup button
* Remove comment
* Comment unsupported MI backup options
* Remove one liner helper function
* Restore dialog methods return types
* Remove comment
* JS doc format
* Renamed UrlBrowserDialog to BackupRestoreUrlBrowserDialog
* Moved MediaDeviceType, added PhisicalDeviceType
* Reorder and rename physical device type
* remove extra spaces
Co-authored-by: chgagnon <chgagnon@microsoft.com >
2022-05-11 11:01:06 -07:00