Alex Ma
298402647d
Added error handling service for providers ( #21627 )
...
* added prototype errorHandlerService
* added initial contracts
* Added WIP client sent request function
* added WIP signature for handleOtherError to resourceProviderService
* made some small fixes
* removed unnecessary resourceProviderId
* added updates to contracts and resourceProvider
* moved error codes to azdata proposed
* added connection type instead of profile
* added WIP handleOtherError code
* added fix for send
* added WIP change password function in resource provider
* added work in progress error handling thread
* added errorHandler interface
* added result error check
* renamed errorHandling namespace to diagnostics
* WIP rename of errorhandler
* light cleanup
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/machine-learning (#21514 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Stops second invocation of createNewSession while expanding OE tree items on disconnected servers (#21437 )
* Debounces second invocation while expanding OE tree items
* Minor clean up
* Adjusts debounce time
* Adding temp trace comments
* Adds missing semicolon
* Removes debouncer to stop 2nd newSession calls
* Removes temp trace comments
* Updates comment
Co-authored-by: Alan Ren <alanren@microsoft.com >
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/admin-tool-ext-win (#21546 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix resource endpoints to end with slash (#21540 )
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/azcli (#21543 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump json5 from 2.1.3 to 2.2.3 in /extensions/arc (#21544 )
Bumps [json5](https://github.com/json5/json5 ) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases )
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md )
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3 )
---
updated-dependencies:
- dependency-name: json5
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* renamed diagnostics service slightly
* registered service
* added work in progress diagnostics implementation
* small changes
* added new diagnostics exe
* Changes for Diagnostics Service (#21583 )
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com >
* WIP provider changes
* added changes for errorDiagnosticsService
* removed stuff from mssql.
* made fix to connectionManagementService
* added error catch
* added small changes
* more small changes made
* added small changes to handleOtherError
* moved changePassword to CMS
* added testErrorDiagnosticsService
* Added provider-based handling for change password/generic error handling. (#21662 )
* WIP rework for error connection change
* added connectionProfileDuringError
* added working password reset
* added comments
* consolidated connection profile conversion
* added additionalObjects parameter.
* removed unnecessary error profile grab
* added comments
* added changes to parameters and comments
* added changes and params
* added handleConnectionErrorParam
* added more changes
* added async
* added params and more
* added many fixes
* added updated documentation
* added WIP password change dialog with await
* added error handling
* added comment
* added options as parameters
* cleaned up parameters
* added async
* added check fixes
* Added username to title
* added server name to dialog
* Added dialog changes
* Revert "Added dialog changes"
This reverts commit c2bdcd16f4a0dffdc643ef9cae1c1a20642ac512.
* Revert "added server name to dialog"
This reverts commit dbd22e80461b5a068643f0c2d6728adce4010978.
* Revert "Added username to title"
This reverts commit 6d936b4d5f97f9345f8ec2fdbbcf6b52df18820a.
* Revert "added check fixes"
This reverts commit f58081a5af3276766e2042b4d671455b18add9a7.
* Revert "added async"
This reverts commit dd1198e26ec7542ec51add0628f588361d674299.
* Revert "cleaned up parameters"
This reverts commit 51135c9f9db452104697483779d8df15b6430717.
* Revert "added options as parameters"
This reverts commit b167804a2410558bbe60042e017ae2c77af7697f.
* Revert "added comment"
This reverts commit 0ad37326a3e025e88f715e3f2547be6825597a8d.
* Revert "added error handling"
This reverts commit 69340980d2c84056a2bcf126ea77f4b5ed4cddf3.
* Revert "added WIP password change dialog with await"
This reverts commit 9e43113e07b10421b39575f6c7dd14287662b90d.
* added a fix to check
* added fixes
* added back in change password changes
* added in comment
* added suggested changes
* removed param colons
* Update extensions/mssql/src/errorDiagnostics/errorDiagnosticsProvider.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* fixed conversion and provider dialog
* altered comments
* Update src/sql/platform/connection/common/utils.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* renamed Id
* Update src/sql/platform/connection/common/utils.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Improvements for Change password dialog + logs added (#21794 )
* Improvements for Change password dialog + logs added
* Include server
* fixed tab space
* added comment
---------
Co-authored-by: Alex Ma <alma1@microsoft.com >
* Update src/sql/azdata.proposed.d.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* added fix to id to extHostErrorDiagnostics
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com >
Co-authored-by: Alan Ren <alanren@microsoft.com >
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com >
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com >
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
2023-01-31 14:31:12 -08:00
Maddy
a38e8a74c3
fix file relative path issue on mac ( #21438 )
...
* use pathname vs nodeValue
* add test
* add comment
* only when editing in rich text
* refactor
* fix build errors
* fix hygiene errors
* remove fs check
* compare decodedUri to get correct relative paths
* Add Azure Resource 'Sql' to MSSQL extension. (#21600 )
* [Loc] added sql.xlf schema (#21687 )
* vbump profiler extension (#21685 )
* Fix connect icon for Arc extension (#21659 )
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230121171613142. (#21690 )
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230122164538349. (#21693 )
Co-authored-by: Alex Ma <alma1@microsoft.com >
* Juno: check in to lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230123164122334. (#21697 )
Co-authored-by: Alex Ma <alma1@microsoft.com >
* use normalize to get the path correctly
* add comment
* refactor
* more tests
* typo fix
---------
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com >
Co-authored-by: Alex Ma <alma1@microsoft.com >
Co-authored-by: Alan Ren <alanren@microsoft.com >
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
Co-authored-by: Alex Hsu <csigs@users.noreply.github.com >
2023-01-30 13:56:55 -08:00
Cheena Malhotra
f43afff8d1
Show tenant dropdown when selecting 'AzureMFA' for first time ( #21763 )
2023-01-27 16:08:11 -08:00
Cheena Malhotra
895b43f36a
Fix account and tenant selection behavior ( #21749 )
2023-01-27 11:47:24 -08:00
Aasim Khan
ccc8df31c7
Adding prompt for delete connection ( #21624 )
...
* Adding prompt for disconnect
* changing to Idialog service
* Code cleanup and fixing comments
* Adding comments and making a test async
* removing then and awaiting for function
2023-01-23 22:56:09 -08:00
Cheena Malhotra
b3acef3124
Add Azure Resource 'Sql' to MSSQL extension. ( #21600 )
2023-01-20 13:08:38 -08:00
Cory Rivera
ee1ec8e759
Build vertical actionbar before results table so that it shows above the table. ( #21668 )
2023-01-19 16:19:24 -08:00
Lewis Sanchez
f74d6f6d9b
Copy Headers for Selected Columns ( #21622 )
...
* Adds copy header delimiter setting
* Copies all table headers or selected headers only
* Adds missing comments
* Update src/sql/workbench/contrib/query/browser/query.contribution.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/workbench/contrib/query/browser/query.contribution.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Creates sort map entries function
* Removes CSV formatting and setting.
* Add colons before error message
* Renames table column sorting method
* Removes extra unnecessary function call
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
2023-01-18 13:20:27 -08:00
Aasim Khan
3b31d1018f
Adding better handling for checkbox column based row selection ( #21553 )
...
* Adding better handling for checkbox column based row selection
* Replacing any with proper typings
2023-01-18 01:20:26 -08:00
Charles Gagnon
85eb7b8824
Add trace debug logging to OE service ( #21617 )
...
* Add trace debug logging to OE service
* cleanup
2023-01-17 17:00:21 -08:00
Cheena Malhotra
3239bb429f
Null Check for errorNumber ( #21586 )
2023-01-12 18:27:10 -08:00
Christopher Suh
90ef8e4907
Remove duplicate account entries ( #21575 )
2023-01-12 12:35:16 -08:00
Lewis Sanchez
7683259097
Add option to show and hide the action bar in the query results view ( #21560 )
...
* Show and hide action bar in results view
* Updates show action bar setting description
* Removes excess padding
* Code review change
2023-01-11 16:16:08 -08:00
Cheena Malhotra
9708b470c7
Azure core | Include alternate library accounts if found ( #21565 )
2023-01-11 16:05:20 -08:00
Lewis Sanchez
16740ba61f
Adds functionality to copy table column headers ( #21564 )
...
* Adds functionality to copy table column headers
* Minor clean up
* Code review changes
* Removes unneeded comma
2023-01-11 09:17:05 -08:00
Lewis Sanchez
a400ff2f43
Save sql plan no longer uses the exact same name as the default ( #21563 )
...
* Save sql plan no longer uses the same name
* Minor clean up
2023-01-10 16:59:37 -08:00
Cheena Malhotra
fd2ced449b
Skip fetching access token when opening context menu in OE ( #21557 )
2023-01-09 21:22:02 -08:00
Lewis Sanchez
8c8a7859a0
Stops second invocation of createNewSession while expanding OE tree items on disconnected servers ( #21437 )
...
* Debounces second invocation while expanding OE tree items
* Minor clean up
* Adjusts debounce time
* Adding temp trace comments
* Adds missing semicolon
* Removes debouncer to stop 2nd newSession calls
* Removes temp trace comments
* Updates comment
Co-authored-by: Alan Ren <alanren@microsoft.com >
2023-01-06 16:10:19 -08:00
Alan Ren
88ab7947a4
fix issue caused by execution plan provider ( #21533 )
2023-01-05 21:12:49 -08:00
Cheena Malhotra
ec7e754009
Handle default tenant to be set when only 1 tenant exists ( #21532 )
2023-01-05 16:40:16 -08:00
Cheena Malhotra
e7fcda7351
Filter accounts based on Auth library in accounts management service ( #21501 )
2023-01-03 20:16:08 -08:00
Charles Gagnon
29c88923f5
Fix Firewall Rule dialog dropdowns ( #21499 )
...
* Fix Firewall Rule dialog dropdowns
* Fix tenant dropdown
2023-01-03 16:24:59 -08:00
Josh Parnham
7d11b88b43
Change execution plan default save location when not in a workspace ( #21461 )
2023-01-03 14:51:30 -08:00
Lewis Sanchez
4a1e5001f0
Fixes object explorer's manage keybinding shortcut ( #21459 )
...
* Fixes object explorer's manage keybinding shortcut
* Update src/sql/workbench/contrib/dashboard/browser/dashboardActions.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/workbench/contrib/dashboard/browser/dashboardActions.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/workbench/contrib/dashboard/browser/dashboardActions.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Fixes OEManageConnectionAction ctor missing argument
* Updates no connection profile comment
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
2022-12-22 10:49:18 -08:00
Cheena Malhotra
87f1d14357
Reset expiresOn property for non-Azure connections ( #21452 )
2022-12-19 13:04:39 -08:00
Cheena Malhotra
ca22686061
Add support for firewall rule name ( #21430 )
2022-12-16 18:29:44 -08:00
Cheena Malhotra
112de46723
Fix ADAL to MSAL transition of connections and account list ( #21425 )
2022-12-15 16:38:45 -08:00
Alan Ren
3aab4fd115
fix regex perf issue ( #21421 )
2022-12-15 10:43:17 -08:00
Cheena Malhotra
234c3debaa
Fix issues when setting azureTenantId ( #21412 )
2022-12-14 12:03:11 -08:00
Cory Rivera
c1e97cd9ff
Check current notebook cell when refreshing intellisense cache ( #21394 )
2022-12-12 10:50:54 -08:00
Alan Ren
6cfa0910b6
fix h-scrollbar cutoff issue ( #21396 )
2022-12-12 09:39:33 -08:00
Alan Ren
8d3b7ee205
enhance the selection summary ( #21392 )
...
* enhance the selection summary
* update comment
2022-12-09 14:07:47 -08:00
Alan Ren
17b41ae3d7
fix link cell style issue ( #21389 )
2022-12-08 21:53:52 -08:00
Cory Rivera
272e748424
Show a message if kernel is not supported when first opening a notebook. ( #21376 )
2022-12-08 10:27:57 -08:00
Alex Ma
fb6e221fff
[Loc] added small change to password change dialog localization ( #21377 )
2022-12-07 15:03:45 -08:00
Alex Ma
cffba368a9
Added reset password dialog upon SQL Server expired password error ( #21295 )
...
* Added initial password connection dialog box
* made small changes
* more preliminary work
* more WIP changes
* more cleanup done
* added dialog instantiation
* added placeholder dialog window
* added changePasswordController
* made some changes to changePasswordController
* some changes made
* added more changes
* more changes made to dialogue
* added password confirm box
* added WIP change password function
* small changes made to API
* small changes for test
* added uri
* added valid password
* added TODO comments
* added small change to connectionManagementService
* added connectionManagementService password change
* added comment on what to do next
* made some simplification of change password
* added response callback
* added fixes to protocol
* added throw error for passwordChangeResult
* WIP added call to self after password change
* WIP changes to implementing new password change dialog
* added changes to passwordChangeDialog
* added launchChangePasswordDialog
* remove erroneous css
* added working dialog
* removed old password change dialog
* fixed space
* added checkbox option to passwordChangeDialog
* added test signatures
* added error handling
* added some changes
* added changes to HTML for passwordChangeDialog
* added CSS to passwordChangeDialog
* added display none for matching passwords
* added documentation changes
* small cleanup
* added working error catch and retry
* added await
* added recovery instructions
* Added ok button hide for button click.
* added loading spinner
* fixed for semicolon
* added updated message
* Added message change
* added minor fixes
* added small fixes
* made more changes
* renamed messages to errorDetails
* added styling to passwordChangeDialog
* simplified error message
* changed comment
* modified azdata to be consistent
* small changes
* change to azdata for consistency
* added clarification for provider
* removed additional instructions
* Added new dialog title
* addressed feedback
* added comments
* added changes
2022-12-07 14:27:01 -08:00
Cory Rivera
e2327c393a
Remove all Big Data Cluster features ( #21369 )
2022-12-07 12:28:17 -08:00
Karl Burtram
05eb8dd448
Add PowerBI PPE URI to domain list ( #21357 )
2022-12-05 15:03:01 -08:00
Cheena Malhotra
e89341f6bd
Set both label and values to custom options select Boxes ( #21354 )
2022-12-02 13:48:23 -08:00
Cheena Malhotra
02e9f8d3ef
Rename to security token to match STS ( #21338 )
2022-11-30 15:02:08 -08:00
Aasim Khan
c0a194df4a
Adding wizard and dialog footer loading spinner ( #21230 )
...
* Adding wizard and dialog loading
* Moving apis to proposed
* fixing namespace
* Only firing event when the value changes
* Only firing when value is changed
* Adding loading complete message to dialog and wizard
* Registering listeners and making a new base interface for loading components
* Fixing api comment
* Renaming prop to loadingCompleted
* old loading icon
2022-11-30 12:18:34 -08:00
Cheena Malhotra
23dfd690a6
Refresh token with SqlToolService session update ( #21308 )
2022-11-29 15:26:15 -08:00
Cory Rivera
4dfedabbc6
Dispose underlying text input in notebook input to clear editor service references correctly. ( #21318 )
2022-11-29 10:06:52 -08:00
Maddy
815310f52a
check for file protocol of vscode-file ( #21302 )
...
* check for file protocol vscode-file:
* use vscode constants
2022-11-28 15:19:02 -08:00
Cheena Malhotra
405b3bbfdb
Fix default auth and 'AzureTenantId' to persist and not reset on selection event ( #21289 )
2022-11-23 17:39:03 -08:00
Christopher Suh
86c3f315f2
Add MSAL Authentication Library support ( #21024 )
2022-11-23 14:06:44 -08:00
Cheena Malhotra
62b123624d
Fix icon foreground ( #21287 )
2022-11-22 18:03:51 -08:00
Cheena Malhotra
3b6ce47acc
Fix access token refresh design (ADS only) ( #21206 )
2022-11-21 19:35:00 -08:00
Cory Rivera
728a90cd53
Move New Notebook command to core ( #21247 )
2022-11-18 14:54:58 -08:00
Cory Rivera
a37d6230f9
Remove API compatibility layer for VS Code notebook extensions ( #21225 )
2022-11-15 10:38:41 -08:00