* Removing canary host
* Rebranding extension name to Azure SQL Migration
* stopping instance table overflow in assessment dialog
* Added info message for details copied
* Limiting storage account and DMS to the same subscription as target
* making accounts page look like figma mockups
* converting error messages to warnings in cutover dialog
* making source config page look like figma mockups
* adding more filters for storage account and dms
* Adding validations for target database names.
* Fixing branding in other strings
* Adding types for SQL Managed Instance
* Fixing Database backup page target layout
* Filtering out Azure sql db issues from assessment results
Correcting the database count for issued databases in sku rec page.
* Adding copy migration details button to migration status
* Adding start migration button to toolbar
* Fixing a syntax error in package.json
* Adding rg and location to target selection page
Filtering storage account by target location.
* Fixing dashboard title to azure sql migration
* Not making assessment targets selected by default.
* Adding tooltip for database and instance table items.
* Fixing duplicate task widget
* Some fixes mentioned in the PR
Localizing button text
renaming a var
changing null to undefined.
* Adding enum for Migration target types
* Fixing a critical multi db migration bug because of unhandled race condition
* Adding Azure location api to azure core
* Adding source database info in status
* New feature for Notebooks - callout. This utilizes a modifed modal.ts that renders a small modal set to appear at the trigger event and disappear when user clicks off of it. This is intended only for micro-interactions such as inserting links, tables and images into Notebooks. Error dialogs dependent on modal have been updated to implement the modified width property correctlty.
* Modified dialogStyle names in interface. Applied updates to files dependent on this. Wired up disposable listener for browsing local files in image select callout. Renamed callout to calloutDialog.
* Converted double quotes in CSS to single quotes. Revised run method, removing the promise wrapping from the conditional.
* Passing click target to modal for positioning. Created custom buttons and click event handlers for Insert image and Insert link. Set feature behind preview flag.
* Revised structure and styles.
* Updated component for use with ML extension. Updated ML extension code with changes for custom dialog creation.
* Fixed async context for handleBrowse. Passing the new modal properties into Dialog implementation for ML.
* Added option to suppress callout dialog header and footer from the machine learning view file. Added a compact variant of callout. Corrected Dialog tab initialization.
* Maddy/callout modifications (#13586)
* initial changes
* canSelectFolders false
* change label, placeholder text on radiobtn click
* Added support for custom XY offset to account for modal size and to provide for fine-tuning of unique modal instances.
* Updated Image icon with latest from Design.
* Replaced node process with IPathService for retreiving image file.
* Added theme color lookups to provide default colors when none are provided.
* Added async/await to tests calling transformText.
* textCell, modal - swapped out HostListener for a member method which listens for the Esc keyup. Updated templates with method call on keyup. This cleaned up the double event call whenever the Esc key was pressed. Added property to modal Cancel button call to make it a secondary button.
* Cleaned up callout styles.
* Removed color use for input fields because component code delivers theme-specific values.
* Added check for CSS class `mac` on the body tag. Added conditionals to supply alternate dialogXYOffset in the case of non-Mac environment.
* Cleanup: Simplified DialogPosition. Renamed telemtry references and dialog related methods. Corrected spelling. Added missing signatures and types. Updated warning callout link URLs.
* Removed async and await as there are no promise dependencies. Added a signature.
* Revert "Fix windows insiders icons (#13579)" (#13630)
This reverts commit a0ef594792.
* Changed cores validation message (#13617)
* Changed cores validation message
* Missed validation
* Remove cores validation message
* Applied verification for cores change to miaa c+s page
* WYSIWYG Improvements to highlight (#13032)
* Improvements to highlight
* wip
* Tests pass
* Leverage escaping mechanism
* Tweak highlight logic
* PR comments
* add await to thenable method (#13635)
* Delete ConnectionDialogue.ipynb (#13634)
this nb was an attempt at creating a connection dialog. removing
not found in toc
* Added engine version argument to edit command. (#13610)
* Added engine version argument to edit command. Neccessary for not using pg12
* Included for changing password in overview page
* Updated fakeazdataapi test
* Fix empty column issue (#13641)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* add right padding to notebook toolbar action item (#13640)
* add right padding to action item
* remove extra line and add space
* Adding SQL Edge project template (#13558)
* Checkpoint
* removing flag for not creating subfolder
* Adding Edge template
* Removing janky map function
* Adding templates for additional objects
* Updating tests, fixing bug
* Added Edge project icon
* Updating strings to Drew-approved text
* Cleaning up template scripts and Edge project template names
* Update package.json (#13626)
* Update Import UI to match other UIs (#13637)
* Update Import UI to match other UIs
* Fixed another bug
* Fix notebook unordered grid values after papermill execution (#13614)
* Fix unordered table
* check entire first row schema:
* SQL Notebooks should not get affected
* delete unused variable and edit comments
* refactor for efficient table ordering
* nit naming
* Normalize path to change (#13660)
* vbump asde deployment extension (#13662)
do a patch version update, will adjust if the next change is a major one.
* Add test for dynamic enablement (#13602)
* Add test for dynamic enablement
* update names
* Remove debug console log (#13669)
* Remove placeholder on deployment wizards when field is disabled dynamically (#13658)
* Bump highlight.js in /extensions/markdown-language-features (#13675)
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.15.10 to 10.4.1.
- [Release notes](https://github.com/highlightjs/highlight.js/releases)
- [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md)
- [Commits](https://github.com/highlightjs/highlight.js/compare/9.15.10...10.4.1)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add ability to control the enabled state of checkbox cells (#13644)
* control enabled state of checkbox cells
* add more check
* Prevent Table from Disappearing due to exception when looking for tHead (#13680)
* Prevent exception when tHead doesn't exist at node
* Add test for no thead
* Fix issue with pasting results in Teams (#13673)
* Fix issue with pasting results in Teams
* Addressed comment to change header tag to th
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Add descriptions and validation to connected mode (#13676)
* Add dependent field provider to resource deployment (#13664)
* Add dependent field provider to resource deployment
* Change name to value provider service
* Add error handling
* providerId -> id
* Set dropdown value correctly
* missed id
* back to providerId
* fix updating missed id
* remove placeholder
* Have resource deployment providers return disposables (#13690)
* Add dependent field provider to resource deployment
* Change name to value provider service
* Add error handling
* providerId -> id
* Set dropdown value correctly
* missed id
* back to providerId
* fix updating missed id
* Make resource deployment providers disposable
* Retry publish and always try adding asset (#13700)
* Retry publish and always try adding asset
* Undo asset upload change
* Add logging
* Notebooks: Remove result set summary from saved metadata (#13616)
* remove result set summary from metadata
* remove batchId and id from celloutputmetadata
* remove extra line
* Add scan suppressions (#13705)
* Add action for responding to Needs Logs label (#13707)
* Fix action name (#13708)
* Add action for responding to Needs Logs label
* Fix action name
* Rename action config file (#13709)
* Add action for responding to Needs Logs label
* Fix action name
* Rename config file
* remove quotes
* Adding unit tests for schema compare service (#13642)
* Retry getConfig (#13712)
* Retry getConfig
* Add logging
* vBump Arc and Azdata (#13717)
* switch schema compare to use inputbox instead of table headers (#13715)
* Added Accounts and Database Backup Page to Migration wizard (#13548)
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Use console.log for retry logging (#13722)
* Fixed Schema compare integration tests by adding retry (#13649)
* Add workspace information in Import UI (#13648)
* Add workspace information in Import UI
* Addressed comments
* Reduced space between Workspace heading and the label
* Lint azdata.d.ts (#13728)
* Added developer name to the list of developers. (#13725)
onboarding commit: Added developer name to the list.
* Fix environment variables for controller create (#13732)
* vbump schema compare and sql database projects (#13730)
* December release readme (#13733)
* Change server group look (#13608)
* change server group look
* remove dead code
* add top padding
* add bot padding as well
* fix heights to account for padding
* fix arrow alignment
* fix ellipses and node length parity
* fix alignment
* Make loading components not valid and improve RD radio group (#13738)
* Revert "Added Accounts and Database Backup Page to Migration wizard (#13548)" (#13742)
This reverts commit e169005571.
* Add loading text properties for option sources (#13743)
* Add loading text to deployment radio options
* Fix loading race condition
* Update text
* Add kube config and kube cluster to arc data controller screens (#13551)
* Un-skip and fix a few of the db projects tests (#13726)
* Un-skip and fix a few of the db projects tests
* Addressed comments
* Fix one test failure on Linux/Mac
* Update STS to revert SqlClient update (#13758)
* Update required azdata versions (#13762)
* fix the recent list (#13770)
* Adding base classes for data dev extension telemetry (#13763)
* adding telemetry dependencies for data-workspaces and sql-database-projects
* Adding telemetry dependencies for dacpac extension
* Adding telemetry base to data workspaces and projects
* Adding telemetry base code to the dacpac extension
Co-authored-by: Benjin Dubishar <benjin@Largo.local>
Co-authored-by: Sai Avishkar Sreerama <ssreerama@microsoft.com>
* Update changelog (#13773)
* Notebook Extension: First logging improvements (#13729)
* First logging improvements
* PR feedback for err output
* Add BEGIN/END to snippet (#13784)
* Adding database backup and accounts page to migration wizard (#13764)
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Using older storage package
* Update typings/namings (#13767)
* Update typings
* more typings fixes
* switched fileshares and blobcontainers api to http requests
* removed the extra line
* Adding resource graph documentation link as a comment
* remove makeHttpRequest api from azurecore
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* change afterClean to beforeBuild for removing the generated assests.json (#13736)
* change afterClean to beforeBuild for removing the generated assests.json
* fix merge conflict
* rename files
* Clean up Loading Component typings (#13785)
* Clean up Loading Component typings
* add properties to impl
* Log active element when notebook smoke test fails (#13724)
* add error log for active element
* fix active element selector
* await isActiveElement call
* call waitforactiveleement
* Bump ini from 1.3.5 to 1.3.7 in /samples/sqlservices (#13776)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ini from 1.3.5 to 1.3.7 in /build (#13765)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ini from 1.3.4 to 1.3.8 (#13792)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.4 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.4...v1.3.8)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ini from 1.3.5 to 1.3.8 in /extensions/markdown-language-features (#13791)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* renable kernels dropdown test (#13727)
Verify no skipped core tests
* Remove redundant parameter in test scripts (#13755)
* Fire onDidSelect event when selecting event from code (#13691)
* Fire onDidSelect event when selecting event from code
* Fix import tests
* fix typo
* Use correct Azure graph endpoint & cleanup (#13786)
* Use correct Azure graph endpoint
* Add enum
* Update CODEOWNERS (#13798)
* Make project workspace selectable if no workspace is open yet (#13508)
* allow new workspace location to be editable
* fix workspace inputbox not showing up after toggling open workspace radio buttons
* add a few tests
* cleanup
* fix errors
* addressing comments
* fix filter for windows
* add error message if existing workspace file is selected and change picker to be folder only
* address comments
* fix typos and update tests
* vbump 2018 -> 2019 (#13800)
* Fix "not externalized correctly" warnings (#13806)
* Notebook Deep Link to Section (#13795)
* Notebook deep link to section
* fragment wip
* table component improvement (#13801)
* hyperlink column
* fixed width for image only button - old behavior
* Server Reports extension: fix for start and stop xevent sessions (#13565)
* fix for start and stop xevent sessions
* vscode.open for help URL
* setup info messages for localization
@kburtram - I could use an assist on updating the v# and publishing the vsix, but there's no rush this can wait until after the holidays
* Arc - Update Postgres name length limit (#13807)
Arc - Update Postgres name length limit. It was recently reduced from 12 to 11.
* Fix whitespace differences in sqlproj (#13805)
* add whiteSpaceAtEndOfSelfclosingTag
* update test baselines
* Fix paths for tests (#13816)
* Fixed the stray validation error message in Resource Deployment wizard (#13747)
* Fixed the stray validation error message
* Removed not working ' with validation
Adding back cancel button disabling
* mark a couple data workspace tests as unstable (#13822)
* cosmetic changes (#13820)
* cosmetic changes
* moved limitLongName function to the utils
* add . as trigger character (#13811)
* Remove hardcoded search box height (#13823)
* Use azdata-test modelview stubs (#13818)
* Filter vscode delegate command events (#13832)
* Fix duplicate SVG rendering (#13828)
* Fix select box event ordering (#13831)
* Fix select box event ordering
* more fixes
* Fix page
* Revert typing change
* Undo param
* Fix compile error
* Completely remove typings
* Dacpac - Showing error message to user if operation fails (#13830)
* Showing error message to user if operation fails.
* Added more tests
* Fix unstable data-workspace tests (#13824)
* stub file existing validation
* add error message
* change back to calling dialog.validate()
* move tests to separate dialogbase file and add more error message validation
* comment out the unstable unit test step (#13834)
* remove --build flag
* comment out unstable test
* add build tag back
* Removed padding-top / bottom declarations for text cell notebook-preview. This compacts the text cell by 14px on top and bottom. (#13815)
* Stop forcing left text align on tables (#13840)
* Have same connection logic for all nb int tests (#13844)
* Added fix for the infinite page refresh in resource Deployment tools page (#13813)
* Added fixed for the infinite loop in resource Deployment tools page
Generating events for select boxes only when the select box value is changed.
* Fixed the check logic in select method
* Reverted to old code and fixed some bugs
* Fixed event generation check logic
* Make new workspace inputbox editable in Create project from database dialog (#13842)
* update create project from database dialog to have editable new workspace
* add validation
* add test
* add error message
* Remove test for now
* cleanup
* add periods
* throw errors
* change return type to void
* Removal of Components folder, moving ADP notebook to its own notebook. (#13848)
* adp folder removed, notebook moved.
* moved ADP notebook to own folder.
* Passing click target to modal for positioning. Created custom buttons and click event handlers for Insert image and Insert link. Set feature behind preview flag.
* Revert "Revert "Fix windows insiders icons (#13579)" (#13630)"
This reverts commit 111dcb4c6885d9ab1a24398b13f103835789e6e0.
* Corrected button style and declared dialogStyle for ManageModelsDialog. This fixes broken layout see when user clicks: Import or view models.
* Revised suppressHeader/Footer to renderHeader/Footer and fixed logic. Code cleanup. Changed how calloutType: IMAGE and LINK are implemented. Added comments where neeed.
* Fixed callout separator: Swapped out transparent for notebookToolbarLines
* Removed promise context from image callout logic.
* Moved calloutDialog into modal folder.
* Code and style adjustments per feedback. Removed dependency on mac body class. Cleaned up dialog theme. Revsied modal callout logic.
* Corrected CSS for notebook toolbar. Removed unused code. Added code to ensure that renderFooter would occur whether true or undefined.
* Code cleanup. Clarified more details in my code comments. Added comments to values that needed identification. Escaping user-supplied text before it is rendered.
* Renamed TriggerProperties interface and implementations to DialogProperties. Added default value for DialogStyle to sqlExtHost.api.impl so existing dialogs take flyout by default.
* Replaced null value with undefined. Revised theme logic to account for undefined color value.
* Fixed top 30px offset rule so callout dialogs do not get this added.
* Revised undefined check for modal theme color. Removed calloutCompact. Moved callout dialog widths into DialogWidth property when calling methods to create callout or dialog. Added comments. Revised CSS.
* Providing fallback value in the case of null. Hex: FFFFFF00 is white with no transparency.
* Removed fallback hex color for foreground. Added check for foregroundRgb before attempting to grab rgba values. Added footer top border color.
* Added formatting after resolving conflicts.
* Corrected implementation after taking changes from main.
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Christopher C <37060219+cavonac@users.noreply.github.com>
Co-authored-by: Monica Gupta <scorpio90m@gmail.com>
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Sakshi Sharma <57200045+SakshiS-harma@users.noreply.github.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
Co-authored-by: Benjin Dubishar <benjin@Largo.local>
Co-authored-by: Sai Avishkar Sreerama <ssreerama@microsoft.com>
Co-authored-by: Drew Skwiers-Koballa <dzsquared@users.noreply.github.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Vladimir Chernov <v-chvlad@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Exposing azure HTTP request in azurecore
Moving migration specific request from azurecore to migration
Created a migrations typing file
* Deleting the typings file in sql migration
* Fixed typos in comments
* Adding default host for azure https requests
* Fixed operator in service url modification
* Changed path and host logic
* Made chagned requested in the PR
* Fixed variable names
* Adding / check for path.
* Changing error code check
* Fixed status logic in azure rest request
Fixed comment logic
Converting error array to string while throwing
* Fixed status check
* Fixed typos and cleaning up
* - Fixed GetMigrationController
- Added createMigrationController and getControllerAuthKeys API in azure core.
- Added typings for Migration Controller
- Fixed database backup page validation logic
- Added IR page with create controller
* Fixing all the comments from the PR
* Fixed typings
* - Adding null checks for onValueChanged
- Adding new event for radiobuttons onDIdChangeCheckedState
* Adding get MigrationController API to azure core.
* string templating
fixed typings
* Fixed typing and sorting logic
* Made the undefined check logic concise.
* Fixing the checked variable in radio buttons
* Emitting the checked state of radio button.
* Adding onChanged event to radioButtons (exposing it)
Deprecating onClick event for radioButtons
Fixing radio button stubs
* Made some type fixes
* Firing event in checked event setter
* updating azdata-test to 1.1 in arc extension
* Some logic fixes in checked setter
* added proper typings and updated package version for azdata-data
* Renamed the event to onDidChangeCheckedState
* Fixed deprecation message
* Fixed broken Schema compare stubs
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Using older storage package
* Update typings/namings (#13767)
* Update typings
* more typings fixes
* switched fileshares and blobcontainers api to http requests
* removed the extra line
* Adding resource graph documentation link as a comment
* remove makeHttpRequest api from azurecore
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Added new warning icon for model input mapping view. Adjusted padding between it and the input field beside it.
* Added new warning icon for model input mapping view. Adjusted padding between it and the input field beside it.
* Modified icon fill colors for better presentation in dark/HC themes. Modified font sizes and padding in various places. Increased input field widths. Removed unnecessary width properties.
* Revised styles and added elements to view models stage of the View and import models.
* Implemented Leilas DataInfoComponent, replacing my use of icon and title, description fields. Corrected some styles.
* Fixed the issue with icon title and description
* Fixed severla issues
* Added method to output localized text for number of models shown. Added component to display models shown text.
* Fixed the issues with order of components
* Fixed showing number of models
Co-authored-by: llali <llali@microsoft.com>
* added filtering to the resource type along with a new component.
* -Added caching of cards
-Removed unused component props
-localized tags
-limited the scope of list items
* Made some changes in the PR
* - Added Iot Category to SQL edge
- Moved category names to constants
- Moved localization strings to localized constants
- Made filtering logic more concise
- Changed how category list is generated
--Category list can now be ordered
-Added back event generation for selectedCard
* Fixed bugs, and some additional changes
-Fixed radiogroup height to avoid the movement of options below it
-Restoring the focus back to the search and listview components
- Added focus behaviour for listview
- Fixed a typo in comment
* Made categories an Enum
* Added localized string
* localized category string
converted categories to enum.
* made the filtering logic more concise.
* returning string if no localized string formed
removed unnecessary returns
* fixed the filtering tag logic
resetting search when category is changed
* removing the iot tag from sql edge deployment
* made filtering logic more concise
made enum const
* added vscode list
* some cleanup
* Some PR changes
- Made PR camelcase
- added comments to SQL
- removed unnecessary export
* -Some PR related changes
-Removing unsupported style property
-scoping down css and removing unused ones.
* Fixed a comment text
* Fixed typings for listview event
* dashboardWidget to use updated button component - added an enum for buttonType.
* Code fixes.
* Casting ButtonType to string
* Leaving default description value as empty string. Testing logic for buttonType.
* Moved ifFile check into buttonType getter. Hard coded button type returns to test on the front end.
* revised buttonType getter to return Normal by default if not specified in properties.
* Extended sql Button as InfoButton for use in dashboardWidget.
* Added InfoButton to ngAfterViewInit
* Upadted how infoButton element is built. Exposed properties for use in button.component.
* Experiment: Added interface and imported iconUtils for getting iconClass.
* infoButton updates
* Some modifications
* Defined HTMLElements and populated each with properties from dashboardWidget.
* Rewrote elements and passed in properties from dashboardWidget to define button contents and layout.
* Added missing delineator.
* Correctd width getter.
* Code cleanup
* Styled header and button copy. Corrected button and header dimensions.
* Button and welcome page background style adjustments.
* infoButton: Added element reference for container coming in via super so I could apply styles to it. Corrected how button renders.
* Addressed PR feedback - removed async functionality where not needed. Modified syntax that is being deprecated. Made extended IButtonOptions all optional.
* Formatted azdata.proposed. Hygiene check flagged it.
* Removing ? and undefined from button properties as all are being passed from dashboard Widget
* Initialized private vars representing options from custom interface IInfoButtonOptions.
* Addressed PR feedback - added stylesheet for infoButton. Removed iconPath from infoButton context. Cleaned up overall implementation.
* Simplified linear-gradient behind main image so it works across all three themes.
* Style cleanup.
* Removed block notation from element creation in constructor.
* Fixed type signature of IInfoButtonOptions.
* Removed comments. Shifted infoButton style properties into stylesheet.
* Set background color for infoButton when active. This fixes issue where is becomes invisible while selected.
* Corrected styles. Removed hard-coded font-colors. Removed unnecessary styles.
* CSS - added hover styles to side panel items per Figma comps. Cleaned up CSS and removed code comments.
* remove unused splash screen and fix issue reporter path (#12218)
* data workspace extension batch 2 (#12208)
* work in progress
* load projects in view and test cases
* update scope
* make the sql proj menu available in workspace view
* add extension unit test
* address comments
* fix errors
* Add reference to another sql project (#12186)
* add projects to add database reference dialog
* able to add project references
* check for circular dependency
* only allow adding reference to project in the same workspace
* fix location dropdown when project reference is enabled
* add tests
* more tests
* cleanup
* fix flakey test
* addressing comments
* fix focus order (#12233)
* Notebook Text Cell Highlight Improvements (#12197)
* 1st iteration
* works but multiple highlights
* remove comment
* Works but multiple selects
* wip
* cleanup
* cleanup
* Update TPN
* Add mark.js to remote + web
* PR feedback
* Tweak workbench html files
* Add vcore limit support (#12212)
* Quick tweaks to resource viewer (v1) (#12210)
* Hackathon - Better Markdown Editor (#11540)
* Hackathon - better markdown editor - modified Bold to wrap selection in HTML. Split Image button into two new options: embed and link. Made preview container contentEditable.
* Removed the new dropdown from Image button -- it is not necessary since we are adding a context panel instead.
* Modified preview icons
* Set code-component dimensions so it is not visible. It is still being used to pass markdown changes to however.
* add turndown and save markdown
* update model on UI when source changes
* Added conditional that sets element attribute contentEditable when it is in edit mode.
* Added textView component that can be used for editing.
* update source on MD view not on every keystroke
* Added markdown editor buttons that allow user to swap editor, preview views.
* Cleaning up implementation
* Setting base value of _showPreview to false.
* don't allow html edit on split view
* Update editor automagically
* Add an image picking dialog to notebook toolbar.
* Await transformText()
* revert pushEditOperations to fix cursor issue
* Implemented radio buttons for three view toggles.
* Added new, optional properties to radioButton: name, icon class and tooltip. This allows for display as toggleable icon. Updated styles and theme accordingly.
* Style tweaks.
* Added new ViewAction file where the RadioButton action will reside.
* Removed radio button implementation in exchange for native button instantiation. Adjusted CSS and theme accordingly.
* Styles, component and template changes to handle view toggle between text, markdownn an splitview. Includes reverting of radioButton as this is no longer used.
* WYSIWYG 3 Modes
* Ensure one action active at a time
* Setting Text View button active by default. Cleaned up styles. Moved toolbar element to prevent code cell layout overflow.
* Ensure we respect editMode, add showMarkdown
* hiding overflow on code-cell
* Empty text container needs 100% width. Eliminates weird selection border too.
* Initialize _previewMode
* Actions Compatibility
* Further toolbar enhancements
* Update yarn lock after merge
* Slim down changes
* Remove commented out code
* Added margins around notebook-preview container for more visual space for text
* Add turndown to workbench html
* Tweak import
* Add types/turndown
* Remove workbench.html fix
* Import cjs modules directly for turndown
* Leverage solution from github
* browser umd
* non browser umd
* welp dependency
* Modified updatePreview to insert a p tag only when text cell is empty.
* add listener for undo
* add turndown to remote and web
* Fix workbench, check in plugin
* PR comment
Co-authored-by: maddydev <makoripa@microsoft.com>
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
* Update external repo links (#12226)
* Update external repo links
* Update yarn files
* make schema compare test unstable (#12234)
* make schema compare test unstable
* also make Standalone database context menu test unstable
* Fix missing package update (#12235)
* Resource Deployment UX Refresh (#12173)
* adding new card to styles
* renamed property, removed unnecessary css
* Fixed to match new props
* added horizontal class
* merged from master
* Make SandDance work generically for Kusto (#12229)
* Make SandDance work generically for Kusto and Postgres
* Addressed comments
* removed param
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Set items in cell model (#12237)
* Change tables to make them work for our scenario (#12193)
* Change tables to make them work for our scenario
* Comments & deprecate API
* Disable selections by default
* Have default values in add database dialog input boxes (#12155)
* show default values in text boxes
* add sqlcmd formatting
* add tests
* Add some sqlcmd variable name validation
* Addressing comments
* fixes after merge
* fix test
* don't localize OtherServer
* fix for windows
* one more fix
* fix test
* fix bug that doesn't register double click enabled on new notebook contexts (#12239)
* Notebooks: Hide link and image buttons in text cell toolbar in WYSIWYG mode (#12240)
* hide link and image buttons in WYSIWYG mode
* defined taskbar actions
* rename arrays
* Notebooks: Add setting for default text cell edit behavior (#12245)
* Add setting for default text cell edit behavior
* string updates
* Fix pinned notebooks navigator (#12246)
* Added loading to dropdowns (#12214)
* Added loading prop to dropdowns
* Added property for setting loading text message
* removed unnecessary sets
* changed code to match new changes
* Changed the dropdown loader to use select component instead of edit.
Added missing props in dropdown loader
* Address comments jupyter create book notebook (#12250)
* Remove toc file link and add warning for windows users
* Bump node-fetch from 2.6.0 to 2.6.1 in /build/actions (#12219)
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump node-fetch from 2.6.0 to 2.6.1 in /build (#12220)
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix Notebook Kusto Kernel Consistency (#12256)
* fix kusto notebook consistency
* Address undefined
* add existing project to workspace feature (#12249)
* add existing project to workspace feature
* update file name
* new test and use URI
* handle workspace with no folder
* add more validation
* and more tests
* use forward slash
* Use correct resource name (#12288)
* Add heasdingStyle atx option (#12286)
* Disable resource viewer (#12291)
* Disable resource viewer
* comment
* Remove unused
* adding icon for add new and open project (#12265)
* remove project feature (#12297)
* remove project feature
* update test
* Fix notebook cancel query bug (#12300)
* fix undefined query runner error
* store connection id
* revert sqlSessionManager change
* Update PG Deployment with new fields (#12187)
* Added 5 missing field options
* Missing apostrophe
* Change extensions label
* Update volume size descriptions
* Change volume size labels
* Reorder required tools
* Reorder required tools
* Argument fixes
* Removed tabs
* Rearrange option order
* Rearrange option order
* Rearrange option order VS
* Added validation to fields. VS accepts only integer and appends Gi
* Changed Dusky deployment title
* Removed text validation for VS and Mem. Changed to Number field type
* Min set to 1 for VS and Mem
* Min set to 1 for Cores
* Memory limit must be at least 256Mi
* the casing of 'preview' should remain consistent
* Removed empty line
* Portal links for main branch (#12319)
* first commit
* json field added
* message genericized
* order changed
* removed summary page text
* fixed url
* controller dropdown field to SQL MIAA and Postgres deployment. (#12217)
* saving first draft
* throw if no controllers
* cleanup
* bug fixes
* bug fixes and caching controller access
* pr comments and bug fixes.
* fixes
* fixes
* comment fix
* remove debug prints
* comment fixes
* remove debug logs
* inputValueTransformer returns string|Promise
* PR feedback
* pr fixes
* remove _ from protected fields
* anonymous to full methods
* small fixes
* new postgres model (#12305)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Nasc/delete instance code removal (#12307)
* Formatted page
* Removed ResourceHealthPage from the dashboard
* Deleted files that no longer applies to the public preview backend
* shouldn't be able to open the postgres dashboard
* Add new deployment options for MIAA (#12325)
* Use custom dialog for prompting MIAA connection info (#12316)
* Use custom dialog for prompting MIAA connection info
* disable inputs
* Update strings
* remove data-workspace dependency (#12321)
* Arc public preview updates (#12329)
* Arc public preview updates
* disable PG dashboards again
* Stop watching for sqlproj updates after the file is closed (#12311)
* stop watching for sqlproj updates after the file is closed
* remove watcher if project is closed
* Fix component items in declarative table not showing (#12330)
* fix maximize bug (#12334)
* 12284 Removed custom CSS that positioned editor text beneath overlapping layers. Text is now selectable. (#12312)
* Add newline after caption (#12276)
* Watch for on load event (#12309)
* Update deletion strings to refer to instances instead of resources (#12332)
* Update deletion strings to refer to instances instead of resources
* one more
* Remove unused
* More
* Fix DT linting issues (#12290)
* vbump sql-db-proj extension (#12336)
* update sqlproj dependency version (#12359)
* Fix highlight issue (#12278)
* Fix highlight issue
* Address PR comments
* remove a import unit test (#12358)
* SQL VM deployments (#12144)
* Added sql vm deployment option
* Added more fields for sql vm deployments
* created basic sqlvm deployment. Mostly hardcoded
* added string to package.nls
* added poc deployments for sql vm
* Made some changes in the notebook that was mentioned in PR
* Added scaffolding for azure sql vm wizard.
* code cleanups
* added some async logic
* added loading component
* fixed loader code
* completed page2 of wizard
* added some more required fields.
* added some more fields
* added network settings page
* added sql server settings page
* added azure signin support and sql server settings page
* added some helper methods in wizard code
* added some fixes
* fixed azure and vm setting page
added validation in azure setting page
* added changes for the notebook variable
* validations and other bug fixes
* commenting sql storage optimization dropdown
* cleanedup wizard base page
* reversing vm image list to display newer images first
* cleaning model code
* added validations for network setting
* Completed summary page
fixed the code poisition
some additional field validations
* fixed networking page
* - fixed an error with vm size model variable
- removed byol images because it was not working with az sql vm
- Fixed vm size display names in dropdown
* added double quotes to some localized strings
* added some space inside strings
* -Added live validations
-Restyled network component
-Added required to regions
-Some bug fixes
* -redesigned summary page
-localized some strings
* Fixed summary page section titles
* -Fixed validations on sql server settings page
-Fixed some fields on Summary Page
* corrected onleave validation
using array for error messages
using Promises.all
* Fixed bug on network settings dropdowns when user does not have existing resource to populate them
* Change resource deployment display name
Added Ninar's iteration of the notebook
Changed RDP check box label
Surfacing API errors to user
Filtering regions based on Azure VM regions and user's subscription region
Made form validation async
Displaying new checkbox on network page when dropdowns empty
Fixed a small bug in SQL auth form validation
Made summary single item per row and fixed the gaps in spacing
Fixed validations in vm page
Checking if vm name already exists on azure
* Fixed sql vm eula
Fixed sql vm description
Added hyperlink for more info on vm sizes
* Replaced loading component with dropdown loaders.
* localized string
Fixed a bug in network settings page
* Added additonal filtering
* added reverse to image images
* Fixing some merge related issues
* Update arc regions for public preview (#12366)
* Fix duplicate arc instance nodes (#12381)
* Add "No instances available" node for empty arc controllers (#12374)
* Remove MIAA Port Deploy Option (#12388)
* fix option sources (#12387)
* Fix manage action for arc view (#12389)
* 12360 Notebook UI - Mac/Win fix for Select all. (#12383)
* 12360 Notebook UI - Mac/Win fix for Select all.
* Fix for ctrl key selecting all in windows
* Fix undo as well
* preventDefault to prevent confusing behavior
Co-authored-by: chlafreniere <hichise@gmail.com>
* Fix notebook table rendering with multiple code cells (#12363)
* create unique query runner for each cell
* use cellUri instead of cellId to identify runner
* disconnect each query runner connection
* remove queryrunners size check
* Remove azdata eula acceptance from arc deployments (#12292)
* saving to switch tasks
* activate to exports in extApi
* working version - cleanup pending
* improve messages
* apply pr feedback from a different review
* remove unneeded strings
* redo apiService
* remove async from getVersionFromOutput
* remove _ prefix from protected fields
* error message fix
* throw specif errors from azdata extension
* arrow methods to regular methods
* pr feedback
* expand azdata extension api
* pr feedback
* remove unused var
* pr feedback
* Notebooks: Fast update WYSIWYG support for source update (#12289)
* Fast update WYSIWYG support for source update
* Do bracket matching over hardcoding line offsets
* Update Windows command and minor update to installation cell (#12361)
* Fix windows command and minor update to installation cell
* Add expand_section field on the first section of the book
* marking intermittent test failure as unstable (#12402)
* Fix connection dialog indentation (#12401)
* fix connection dialog indentation
* indent tab body
* Remove container registry from arc control deploy (#12392)
* Fix error when clicking on header for tables with no rows (#12408)
* Change default Select query label to "Take 10" for Kusto tables (#12396)
* Change default label to "Take 10" for Kusto tables
* Addressed comments
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Fix resource deployment text field validation (#12421)
* Fix arc deployment regions and remove docker summary (#12430)
* start with eulaCheckButton hidden (#12427)
* start with eulaCheckButton hidden
* reset buttons on card select
* remove testcode
* fix the legacy card style issue (#12428)
* fix the legacy card style issue
* replace the card class
* Fix Spark kernel connections and switch from Kusto to Spark kernels (#12436)
* Fix connection dialog for Spark and issue when switching from Kusto to Spark
* Address comments
* Add Arc MIAA username configuration (#12429)
* Add Arc MIAA username configuration
* username -> userName
* fix postgres product name (#12443)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* vBump azdata extension (#12452)
* Arc - Enable Postgres dashboard (#12439)
* get overview, conn strings, properties pages working
* hook up password reset, azure link, scale configuration
* fix comments
* enable opening postgres dashboard from controller dashboard
* minor fixes
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Remove ItemGroup from sqlproj if node being removed is the last one (#12398)
* remove ItemGroup if node being removed is the only one
* fix for if ItemGroup has elements with different tag names
* fix for ItemGroups not at the end of the sqlproj
* fix the extension dependency issue (#12347)
* Bump arc/azdata extension versions (#12463)
* Add preview to Arc controller deployment (#12465)
* Update azdata extension icon (#12469)
* small optimization for select (#12419)
* Revert BDC deployment back to using old azdata check (#12470)
* remove/use unused strings (#12460)
* Activate arc extension with resource deployment command (#12472)
* change to allow refresh and delete correctly (#12477)
* update resultSet in data provider (#12478)
* Add SQL instance name validation (#12480)
* Add SQL instance name validation
* Move -
* Update PG validation
* Fix regex
* simplify
* add table name to models that are imported (#12445)
* add table name to models
* adding null check for safety
* As per PR comment
* Arc/Azdata string updates (#12485)
* Arc/Azdata string updates
* more updates
(cherry picked from commit 2c6f7ac4472e0197650be299ec899388bb495fd8)
* couple more fixes
* more
* update sql database projects readme (#12481)
* remove option to add reference to same database (#12495)
* Update default values and example text when dropdown value changes (#12493)
* Fix PySpark kernel connection change (#12494)
* Notebooks: Fix Grids Not Rendering when Unsaved Notebook Reloaded (#12483)
* Clear Output and fix output change
* Fix tests after forced clear + append output
* Add warning message for users using the new version of jupyter book (#12496)
* Add warning message for users
* Address pr comments
* Arc Postgres - Add Azure params to overview page, update notebook (#12482)
* add azure params to pg overview page, update troubelshooting notebook, string changes
* no default pg version for notebook
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Arc good ARC bad (#12499)
* default to 0 workers (#12506)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Add progress indicator for arc instance deletion (#12510)
* Fix core and memory request MIAA deploy (#12505)
* Fix core and memory request MIAA deploy
* Memory request/limit as 2Gi for MIAA
* In-Viewlet Notebooks Search (#12455)
* fix search
* Add sql carbon tags to vs files
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: abist <adbist@microsoft.com>
* Replace vCores property with state for arc controller dashboard (#12512)
* Bump extensions (#12516)
* fix the reference error due to extra $ in default variable (#12523)
* use GB instead of MB for postgres memory (#12528)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* data workspace review feedback implementation (#12489)
* add a view to handle no workspace scenario
* text update
* project type filter improvement
* fix the project level context menu issue
* update strings
* Add timestamps to azdata output channel output (#12530)
* Fix arc controller ns/name validation (#12525)
* Fix arc controller ns/name validation
* Rename control plane references
* Fix validation
* new download location of azdata.msi (#12466)
* new download location of azdata.msi
* refactor
* Disable tests
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* move eula prompt post azdata discovery (#12532)
* new download location of azdata.msi
* move eula prompt post azdata discovery
* unacceptEula - test change
* Revert "unacceptEula - test change"
This reverts commit f84a3f5e41797de25b38f87143d66f7041b5c4ec.
* Remove Direct connectivity mode option (#12533)
* Remove Direct connectivity mode option
* remove option completely
* fix string
* Arc - Update Postgres deployment field labels and descriptions (#12537)
* update help text strings
* update field descriptions to match help text
* update cpu/memory field descriptions
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Add troubleshoot button to arc controller/MIAA dashboard (#12534)
* Add troubleshoot button to arc controller dashboard
* Add MIAA button
* Fix links
* Change azdata output channel to Azure Data CLI (#12545)
(cherry picked from commit cdd80c66764bddb2f5ed79045fbd8a0606d1d084)
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Fix windows azdata install (#12542)
* Fix windows azdata install
* skip failing tests
* Update/release docs (#12544)
* update changelog for 1.22
* update fwlinks
* fix format
* escape the value for display (#12547)
* Add new profile (#12556)
* Add new profile
* version
* move
* fix readonly summary page field widths (#12558)
* Arc - Enable Postgres support request link (#12560)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* Add test for notebook result grid streaming (#12539)
* start testing convertAllData
* add test for convertAllData method
* clean up code
* bump ads and extensions (#12550)
* bump ads and extensions
* bump azdata
* bump asde deploy
* Remove command link from deployment error (#12573)
* [Kusto extension] Updated links (#12569)
* Add CodeQL Analysis workflow (#10195)
* Add CodeQL Analysis workflow
* Fix path
* updated links
* edit line 31
* edit lines 11 and 31
* edit line 11 again
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
* Don't use deprecated param (#12574)
* add event.preventDefault() (#12564)
* strict compile for sql/workbench/contrib/queryHistory (#12579)
* clone the object to be modified (#12583)
* Strict compile for sql/workbench/services/dialog (#12578)
* Strict compile for sql/workbench/services/dialog
* fix errors
* strict compile for queryResultsView (#12581)
* Add telemetry for ModelView wizards (#12596)
* Add telemetry for ModelView wizards
* Remove unnecessary params
* Fix compile error
* Improved behavior for accepting EULA. (#12453)
* working version of overloading "select" button
* promptForEula to use showErrorMessage
* make parameter optional in promptForEula
* remove test code
* PR feedback
* eula to EULA
* minor fix
* Remove arc deployment extension check (#12598)
* add role for history tab (#12608)
* add title and tab-index for X button (#12605)
* set aria-hidden for a non-visible control (#12607)
* Convert MIAA and Postgres deploy from Dialog to NotebookWizard (#12609)
* dialog to NotebookWizard
* move fields
* fix 12599
* pr feedback
* add missing page titles
* Fix undefined error in server tree data source (#12616)
* Fix undefined error in server tree data source
* Add comment
* Add ModelViewEditorOpened event (#12597)
* Add ModelViewEditorOpened event
* fix
* Fix compile
* Update sqltoolservice release for kusto extension (#12622)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Delete database reference (#12531)
* remove ItemGroup if node being removed is the only one
* fix for if ItemGroup has elements with different tag names
* fix for ItemGroups not at the end of the sqlproj
* add delete for db references
* fix failing tests
* add test
* cleanup
* Addressing comments and fixing a string
* simplify the preview information feature (#12606)
* dashboardWidget to use updated button component - added an enum for buttonType.
* Code fixes.
* Leaving default description value as empty string. Testing logic for buttonType.
* revised buttonType getter to return Normal by default if not specified in properties.
* Extended sql Button as InfoButton for use in dashboardWidget.
* Some modifications
* Rewrote elements and passed in properties from dashboardWidget to define button contents and layout.
* Styled header and button copy. Corrected button and header dimensions.
* Merged latest from main. Resolve conflicts.
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Co-authored-by: maddydev <makoripa@microsoft.com>
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Monica Gupta <scorpio90m@gmail.com>
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Kartik Arora <33497301+ktech99@users.noreply.github.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: Mark Ghanayem <22989000+markingmyname@users.noreply.github.com>
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>