Commit Graph

258 Commits

Author SHA1 Message Date
Karl Burtram
867a963882 Merge from vscode bead496a613e475819f89f08e9e882b841bc1fe8 (#14883)
* Merge from vscode bead496a613e475819f89f08e9e882b841bc1fe8

* Bump distro

* Upgrade GCC to 4.9 due to yarn install errors

* Update build image

* Fix bootstrap base url

* Bump distro

* Fix build errors

* Update source map file

* Disable checkbox for blocking migration issues (#15131)

* disable checkbox for blocking issues

* wip

* disable checkbox fixes

* fix strings

* Remove duplicate tsec command

* Default to off for tab color if settings not present

* re-skip failing tests

* Fix mocha error

* Bump sqlite version & fix notebooks search view

* Turn off esbuild warnings

* Update esbuild log level

* Fix overflowactionbar tests

* Fix ts-ignore in dropdown tests

* cleanup/fixes

* Fix hygiene

* Bundle in entire zone.js module

* Remove extra constructor param

* bump distro for web compile break

* bump distro for web compile break v2

* Undo log level change

* New distro

* Fix integration test scripts

* remove the "no yarn.lock changes" workflow

* fix scripts v2

* Update unit test scripts

* Ensure ads-kerberos2 updates in .vscodeignore

* Try fix unit tests

* Upload crash reports

* remove nogpu

* always upload crashes

* Use bash script

* Consolidate data/ext dir names

* Create in tmp directory

Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Christopher Suh <chsuh@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2021-04-27 14:01:59 -07:00
Christopher Suh
fe9d3bc63b Disable checkbox for blocking migration issues (#15131)
* disable checkbox for blocking issues

* wip

* disable checkbox fixes

* fix strings
2021-04-17 09:03:46 -07:00
Aasim Khan
339d908d1d Adding windows auth support to sql-migration and misc bug fixes. (#14816)
* - Added coming soon message for learn more.
- Potential fix for learn more message

* Renaming of controller to sqlMigrationService

* Surfacing some errors
-Azure account is stale error
-Migration Service creation error.

* Adding refresh azure token validation.

* Fixing some errors pointed during PR
-Fixing property names
-Fixing count

* Fixing migration status
- Adding special error handling for resource not found error
- Deleting unfound migrations from local cache
- Using prefetched migration status for view all

Misc fixes:
- Using SQL server version name instead of number
- Fixing Icons on sku recommendation page
- Fixing table column width in cutover dialog
- Adding spinner button to refresh.

* Fixing all strings in migration service page and dialog

* fixed a string error in create service dialog

* Adding source config page to migration to support windows auth
Some refactorings for sqlDatabaseTree (still WIP)

* refactoring assessments code 1
introducing new interface for server assessments

* Filtering out non windows sql vms
Retaining selections made by user on assessments dialog

* Fix compile errors on sqlDatabaseTree

* Exposing migration status errors in cutover dialog

* Updating extension verion

* Correcting typos
Fixing compilation erros
Removing en-us from url
Fixing function names
Make UI calls unblocking

* Unblocking dialog in case of failed assessments
Localizing string
removing blocking code from UI
Fixing comments

* Fixed broken assessment page logic
2021-03-23 07:48:26 -07:00
Charles Gagnon
0906030aa2 Expose AzureAccount typings to other extensions (#14604) 2021-03-09 10:16:52 -08:00
Jeff Trimmer
0bea923c0a Change tenant to tenant.id when passing to azdata.accounts.getAccountSecurityToken() method. (#14588) 2021-03-08 15:58:04 -08:00
Alan Ren
a3cddbc8aa align with portal button style (#14187)
* align with portal button style

* fix welcome page

* image button

* more fixes

* use withProperties

* add comment back

* add border radius
2021-02-08 15:12:54 -08:00
Charles Gagnon
49fa56369c Fixes for HDFS node expansion on BDC connections (#14174)
* Change cluster test connect to use endpoints route

* Add more logging

* More logging

* Only connect to controller if needed

* Add comments
2021-02-05 10:12:15 -08:00
Benjin Dubishar
661e7c361d Adding schema compare UX support for external streams/streaming jobs (#14134) 2021-02-01 21:57:46 -08:00
Kim Santiago
ddc8c00090 Data workspace projects changes (#13466)
* Fix project context menu actions (#12541)

* delete works again

* make fewer changes

* update all sql db project commands

* cleanup

* Remove old projects view (#12563)

* remove old projects view from file explorer view

* fix tests failing

* remove projects in open folder opening up in old view

* Update db reference dialog to show projects in the workspace (#12580)

* update database reference dialog to show projects in the workspace in the project dropdown

* remove workspace stuff from sql projects extension

* undo change

* add class that implements IExtension

* undo a change

* update DataWorkspaceExtension to take workspaceService as a parameter

* add type

* Update sql database project commands (#12595)

* remove sql proj's open and create new project from comman palette

* hook up create project from database to data workspace

* rename the remaining import databases to create project from database

* remove open, new, and close commands

* expose addProjectsToWorkspace() in IExtension instead of calling command

* Addressing comments

* fix failing sql project tests (#12651)

* update SSDT projects opened in projects viewlet (#12669)

* fix action not refreshing the tree issue (#12692)

* fix adding project references in new projects viewlet (#12688)

* Remove old projects tree provider (#12702)

* Remove old projects tree provider and fix tests

* formatting

* update refreshProjectsTree() to accept workspaceTreeItem()

* Cleanup ProjectsController (#12718)

* remove openProject from ProjectController and some cleanup

* rename

* add project and open project dialogs (#12729)

* empty dialogs

* wip

* new project dialog implementation

* revert gitattributes

* open project dialog

* implement add project

* remove icon helper

* refactor

* revert script change

* adjust views

* more updates

* make data-workspace a builtin extension

* show the view only when project provider is detected (#12819)

* only show the view when proj provider is available

* update

* fix sql project tests after merge (#12793)

* Update dialogs to be closer to mockups (#12879)

* small UI changes to dialogs

* center radio card group text

* Create workspace if needed when opening/new project (#12930)

* empty dialogs

* wip

* new project dialog implementation

* revert gitattributes

* open project dialog

* implement add project

* remove icon helper

* refactor

* revert script change

* create workspace

* initial changes

* create new workspace working

* fix tests

* cleanup

* remove showWorkspaceRequiredNotification()

* Add test for no workspace open

* update blue buttons

* move loading temp project to activate() instead of workspaceService constructor

* move workspace creation warning message to before project is created

* pass uri to createWorkspace

* add tests

Co-authored-by: Alan Ren <alanren@microsoft.com>

* Additional create workspace changes (#13004)

* Dialogs workspace updates (#13010)

* adding workspace text boxes

* match new project dialog to mockups

* Add validation error message for workspace file

* add enterWorkspace api

* add warning message for opening workspace

* cleanup

* update commands to remove project so they're more generic

* remove 'empty' from string

* Move default project location setting to data workspace extension (#13022)

* remove project location setting and notification from sql database projects extension

* add default project location setting to data workspace extension

* fix typo

* Add back project name incrementing

* other merge fixes

* fix strings from other PR

* default to last opened directory instead of home directory if no specified default location

* A few small updates (#13092)

* fix build error

* update title for inputboxes

* add missing file

* Add tests for data workspace dialogs (#13324)

* add tests for dialogs

* create helper functions

* New project dialog workspace inputbox fixes (#13407)

* workspace inputbox fixes

* fix folder icons

* Update package.jsons and readme (#13451)

* update package.jsons

* update readme

* add workspace information to open existing dialog (#13455)

Co-authored-by: Alan Ren <alanren@microsoft.com>
2020-11-18 16:13:43 -08:00
Charles Gagnon
472c9decfa Display error when doing notebook convert (#13438)
* Display error when doing notebook convert

* Update STS
2020-11-17 10:03:33 -08:00
Charles Gagnon
c699179e15 Re-register contributed book commands when new extension loaded (#13403) 2020-11-16 10:47:27 -08:00
Charles Gagnon
d1f26844ef Remove hardcoded colors for HDFS access dialog (#13240) 2020-11-04 15:16:08 -08:00
Benjin Dubishar
342ff47e51 Adding External Streaming Job I/O validation (#13195)
* Added Tools Service call for ValidateStreamingJob

* Partial addition of ESJ

* adding test mocks

* Validation working

* Modifying command visibility logic to submatch ESJs in addition to files

* Changed string literal to constant, corrected attribute order

* Added tests

* correcting casing that's causing test failures on linux

* Swapping Thenable for Promise

* excluded validate from command palette
2020-11-02 19:02:20 -08:00
BranislavGrbicMDCS
9fcd85e640 Adjusting ADS to support new changes for CloudServerType for SQLOD (#12824)
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* Adjusting ADS to support new changes for CloudServerType for SQLOD

* Using existing constants instead of hardcoded values

* Updating STS version

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-10-29 01:37:42 +01:00
Charles Gagnon
35e79f7173 Clean up sqlClusterLookup (#12910) 2020-10-13 16:22:32 -07:00
Charles Gagnon
3251b26317 Fix HDFS node for Integrated auth (#12906)
* Fix some HDFS issues

* Undo other changes
2020-10-13 14:35:22 -07:00
Charles Gagnon
f633e07ed1 Add more advanced properties for spark job submission dialog (#12732)
* Add more advanced properties for spark job submission dialog

* Add queue
2020-10-06 09:50:32 -07:00
Charles Gagnon
572310b906 Fix HDFS node to only show up for BDC connections (#12714) 2020-10-02 11:42:56 -07:00
Charles Gagnon
1df74e8c4a Add additional logging to spark command failures (#12706) 2020-10-01 17:13:20 -07:00
Charles Gagnon
b3578d058f Save username/password for BDC HDFS connections (#12667)
* Save username/password for BDC HDFS connections

* comment
2020-09-30 08:40:20 -07:00
Charles Gagnon
a91b965a33 Allow non-admin BDC connections to see BDC features (#12663)
* Add handling for non-admin BDC users

* Bump STS

* Fix HDFS root node commands

* remove nested awaits

* colon
2020-09-29 14:02:01 -07:00
Karl Burtram
c5e90d0236 Add migration service calls to migration wizard (#12090)
* Hook up migration apis WIP

* WIP 2

* WIP 3

* Fix build breaks

* Break 2

* WIP 4

* SKU recommendation page work

* WIP 5

* A few minor fixes

* Merge main

* Add back assessment dialog

* Address feedback

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
2020-09-02 16:15:39 -07:00
David Shiflet
94958236cd redo profiler feature move from protocolclient (#12000)
* redo profiler feature move from protocolclient

* remove commented code
2020-08-28 14:50:32 -04:00
Charles Gagnon
694f34a4cd Add Notebook <-> SQL convert (#11590)
* Add Notebook <-> SQL convert

* Update STS
2020-08-03 14:50:24 -07:00
Kim Santiago
c06bd0821b Add deploy options support (#11567)
* add getOptionsFromProfile request

* update deploy and generate script to accept options

* fix tests

* update message

* update message to say what isn't supported

* bump sqltoolsservice version
2020-07-29 17:52:21 -07:00
Amir Omidi
587abd43c2 Large cleanup of AzureCore - Introduction of getAccountSecurityToken and deprecation of getSecurityToken (#11446)
* do a large cleanup of azurecore

* Fix tests

* Rework Device Code

* Fix tests

* Fix AE scenario

* Fix firewall rule - clenaup logging

* Shorthand syntax

* Fix firewall tests

* Start on tests for azureAuth

* Add more tests

* Address comments

* Add a few more important tests

* Don't throw error on old code

* Fill in todo
2020-07-22 15:03:42 -07:00
Amir Omidi
5613a97fae Use a unique key for the accounts (#11380)
* Use a unique key for the accounts

* Fix some tests

* Simplify display name

* Change to a random UUID
2020-07-17 13:39:53 -07:00
Charles Gagnon
1b616acfdb Remove ApiWrapper from mssql extension (#11336) 2020-07-14 10:59:55 -07:00
Vladimir Chernov
8288360cc4 Assessment core extension (#10154) 2020-05-29 01:17:41 +03:00
Charles Gagnon
f568ff82d8 Fix HDFS support for CU5+ BDC instances (#10577)
* Fix HDFS node auth for non-root username

* more changes
2020-05-27 10:17:28 -07:00
Sakshi Sharma
9a55b0275d Import project from database (#10326)
* Initial changes for Import database as new project

* Functionally complete code

* Initial changes for Import database as new project

* Functionally complete code

* Resolved conflicts with latest changes. Also did some code refactoring.

* Addressed comments. Added unit tests.

* Addressed comments

* Moved ExtractTarget enum from azdata to mssql

* Addressed comments

* Fixed indentation in project templates
2020-05-26 16:08:24 -07:00
Benjin Dubishar
f0d86f8acb Database projects deploy (#10417)
* Hooking up deployment of SQL projects to the project build functionality and database selection UI
* Adding ADS-side plumbing for sqlcmdvars
2020-05-26 14:28:09 -07:00
Anthony Dresser
ff848b5903 Remove request promise for request-light (#10346)
* remove request promise for request-light

* make sure data is a string not a json

* add configure call

* remove unused reference

* more fixes

* Move configure calls

* clean up

* fix name

* move test deps as dev

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-05-12 10:27:11 -07:00
Charles Gagnon
eda25f72c1 Improve logging for MSSQL errors to handle HTTP request errors (#10348)
* Improve logging for MSSQL errors to handle HTTP request errors

* stringify
2020-05-12 09:03:39 -07:00
Vladimir Chernov
57d2ceec9d mssql sqlAssessmentService (#10299)
mssql sqlAssessmentService
2020-05-07 21:35:44 +03:00
Anthony Dresser
08bb6414b1 Use custom kerberos to reduce size (#9910)
* add custom kerberos

* fix kerberos and consolidate ignores
2020-04-17 15:15:06 -07:00
Charles Gagnon
30607ec61b Update to latest vscodetestcover (#9909)
* Update to latest vscodetestcover

* Undo ci disable

* Add mssql to coverage upload

* Also update sh script

* Add mocha reporters

* Update yarn.lock

* Fix merge conflict

* Update

* Update yarn.lock again

* Fix compile errors

* Try disabling test

* Disable another test

* Try disabling all tests

* Leave one test...

* Skip msssql tests again

* Remove mssql coverage merge

* re-disable CI
2020-04-14 21:32:17 -07:00
Jeff Trimmer
e149c0580c Add Simple Account Picker for use with Always Encrypted (#9707)
Adds the ability for the user to select from two or more linked azure accounts, using an integrated UI dialog, when executing a query that requires a Always Encrypted column master key located in Azure Key Vault.
2020-03-31 09:46:08 -07:00
Anthony Dresser
586ec50916 fix code to properly handle relative paths (#9777) 2020-03-28 14:59:19 -07:00
Jeff Trimmer
35b27f1304 Add akv token request logic (#9556)
Add support for running queries that require a decryption key from Azure Key Vault when using Always Encrypted.
2020-03-19 12:49:05 -07:00
Charles Gagnon
9f62e2bf22 Bump Service Downloader (#9254)
* bump service-downloader

* handle new event

* Add output logging for servicedownloading events (#9277)

* bump service-downloader to 0.2.0

* bump service-downloader 0.2.1

* Retry github checks

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2020-03-04 15:24:46 -08:00
Chris LaFreniere
2503b18d4b Fix for manage access dialog focus (#9114)
* Fix for manage access dialog focus

* Leverage eventuallyRunOnInitialized
2020-02-13 16:40:23 -08:00
ADS Merger
73ea8b79b2 Merge from vscode 1fbacccbc900bb59ba8a8f26a4128d48a1c97842 2020-02-13 02:56:02 +00:00
Leila Lali
ac6a27b9c2 Machine Learning Services Extension - External Languages (#9043)
* Added external language list, edit and delete UIs to Machine Learning extension
2020-02-10 08:58:46 -08:00
Anthony Dresser
bd7aac8ee0 Merge from vscode a234f13c45b40a0929777cb440ee011b7549eed2 (#8911)
* Merge from vscode a234f13c45b40a0929777cb440ee011b7549eed2

* update distro

* fix layering

* update distro

* fix tests
2020-01-22 13:42:37 -08:00
Alan Ren
c5d3251bb5 remove sql ops (#8805) 2020-01-06 15:37:09 -08:00
Charles Gagnon
856fec4243 Remove preview tags (#8653) 2019-12-12 11:24:05 -08:00
Charles Gagnon
6e8cc3aaca Fix accessibility issues with Manage Access dialog (#8586)
* Fix accessibility issues with Manage Access dialog

* implement more property interfaces

* Fix lgtm errors

* Simplify condition
2019-12-06 15:09:42 -08:00
Rich Smith
b631530753 Modify connection management to support Active Directory authType for non-SQL DBs (#8434)
* First attempt to add Azure MFA login for PostgreSQL

* Finish merge with master

* Fix auth type default selection

* Add AzureMFAAndUser auth type for Orcas

* Fix formatting

* Update change log

* Incorporate some review comments

* Missed an occurrence of AzureResource

* Try to move all changes out of azdata.d.ts and sqlops.d.ts

* Concrete implementation of ConnectionProfile in azdata no longer has azureAccount

* Use enum names instead of numbers in config files
2019-11-26 10:32:59 -08:00
Charles Gagnon
55059907a3 Fix a couple a11y issues with manage access (#8386)
* Fix a couple a11y issues with manage access

* Fix strict null check

* Fix another strict null check
2019-11-19 13:42:53 -08:00