* Changes to 1. Enable Icon for Schema Compare model view editor 2. Set context setting in editable drop down 3. Fix a console error
* new icons
* Changes as per PR comments
* Adding PR comments
* Fixing a spelling mistake
Opening connection dialog was broken if you have a postgres connection
listed in the Connections view and the extension isn't installed.
The capabilities service breaks as it returns an undefined object.
Added handling, so now it does show as "loading..." forever
but doesn't crash
* made all jobs get focus and keyboard friendly
* added tooltip for steps image
* made operator dialog accessible
* change job name as soon as job name changes in text box
* Log telemetry when all markdown cells rendered
* Enable referencing previous telemetry timestamps
* Fix broken unit test to do a null check
* Undo loading icon changes in textcelll
* Addressing PR comments
* PR comments II
* Fix New Notebook issues
- Fix#5338 New Notebook menu item should be next to New Query
- Fix#4936 Add a shortcut to create a notebook in the document well
Created a built-in New Notebook command
that routes to the existing extension-based command.
This avoided a rearchitecture that was more complex that seemed worth it.
Per VSCode patterns, used a _ modifier for the existing command so it's "private"
* fix accessbility issue where tabbing would get wrong focus
* dialogs open one at a time
* get focus on filter headers
* added tool tips to proxy dialog
* added labels to step dialog
- Updated the notebook API to add a change kind, and support saved, executed and other simplified status
- Plumbed this through to the main thread classes
- Support sending the events from cell / input to the notebook model so they loop over the extension host as a content changed event
- Add executed event from the cell
- Azure token wasn't being copied into profile so expand didn't work, it spun forever
- Fixed this by saving in password/token after the connection profile copy, & refactored to be cleaner
- We should ideally ensure session notifies resolves even on fail so if there's a different error it'll break, not spin forever. Punting this part of the fix for now
- Also doesn't solve issue where we always try to connect even if user + password combo isn't saved. Will investigate / work in a separate PR on this.
