Commit Graph

42 Commits

Author SHA1 Message Date
Barbara Valdez
69d937f8f9 More server properties fixes (#24366) (#24384)
* fix locks min value

* disable login auditing in linux

* disable some properties from advanced tab
2023-09-12 11:01:10 -10:00
Sai Avishkar Sreerama
4499f04660 Cherry Pick - Database properties fixes (#24383)
* fix for File size input in DB properties can be decremented into the negative #24307

* Some DB Scoped Config options are sentence cased #24196

* cannot add a file with filestream data filegroup type #24359

* DB Scoped Secondary values aren't updated when hidden #24197

* DB Scoped Config shows secondary values for non-secondary options #24192

* Query store capture policy section is enabling on non-custom capture mode #24371

* queryStore WaitStatistics options should be a dropdown #24372
2023-09-12 10:04:34 -10:00
Sai Avishkar Sreerama
aa006b9da7 Enabling QueryStore options to the database properties (#24255)
* Initial commit

* updated query capture policy props

* all done except, querydiskSpaceSection

* disabling capture policy options on off mode but with custom mode enabled

* adding query disk usage section with purge button

* fg table replace

* STS vbump to 4.9.0.34

* typo
2023-09-07 21:37:24 -05:00
Cory Rivera
32817ae52e Handle undefined nodeInfo for top-level database objects (#24298) 2023-09-06 14:12:07 -07:00
Cory Rivera
ec91de78e5 Update task labels for Attach, Detach, and Drop Database (#24289) 2023-09-05 16:21:09 -07:00
Barbara Valdez
e05ee98dae Add advanced tab (#24267) 2023-09-01 16:53:46 -07:00
Barbara Valdez
c695c5f941 Add database settings tab (#24260) 2023-08-31 14:26:08 -07:00
Sai Avishkar Sreerama
41202a65bd Enabling FILEGROUPS tab experience to the database properties (#24226)
* initial changes for loadin dsc table with real values from smo

* Displaying diff columns for DSC for diff sql server

* checkbox maiants the selection

* elevate option fails to load correct value when set to when_supported option

* all working till maxdop, todo pause option, save

* commented MAXDOP changes, as it is causing issues

* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests

* Undo MAXDOP commented code

* refactored with service data

* column header width adjustments

* Maxdop and pause resume options completed, apply button is failing now

* Removed option names from loc  and using Id instead as names may change in future like in doc

* Apply button fixed

* refactored to reduce table reload

* Ledger digest completed

* refactor done: maxdop secondary shows wrong data from pause_resume

* refactor more: all working but table focus disturbs on update table

* adds conditions for unsupported dsc to <2016 server

* maxdop secondary checkbox fix

* rows still loses focus after value change due to update table row data

* Fixed updating secondary dropdown value

* reusing the private method and removed the duplicated codes

* initial commit - fullText and owner need revision

* Enter key in input type allows the change to update the table data, reduces the live update issues

* Setting focus to the current row

* loading data, need stylings-increase col length, etc

* using the existed setTableData method

* Adding new file dialog

* creating addFile, but not displaying in table, issue with appendData

* Adding row to the table, options are getting from STS

* all working except InPercent value

* code review comment updates

* Input type checkbox update table additional validation

* all except path

* fixing the input type focus and reverting the enterKeyPress logic

* browse path is created, need stylings,refactor,filestream selection and add

* fixing the flickering issue with data refresh

* new file options toggle and grid display string updates

* moving code inline and using actual component

* cleanup

* Add file saving is done, except one styling issue with autogrowth section

* add,remove working, need to edit file

* add, edit, remove - all working, need css fixes and -1 fix

* addressing code review comments

* adding local changes adn fixing for edit file

* adjusting css

* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo

* all fixed, need testing and refactor

* vBump STS  and fixing required field causing the apply button not enable for other options on main branch

* fixing autogrowth radio buttons change updates

* all working except some css

* disabled size for filestream

* fixing filegroups and filetypes scnearios, added filename validation for newfile, todo:editingNew file

* added max and min values to the inputs

* editing filename validation completed, all done exccept CSS

* all fixed except scroll bar

* edit db file header, filename enable issue fix

* PR comment supporting updates for STS

* initial commit

* min updates

* loading data into table.. adding rows

* modfying addButtonsForTable method and reusing it for edit button

* add empty row/remove done, edit name and other columns required and save with tests

* All working except new name validation

* adding validation

* code review comment updates

* Dialogbase addbuttons to table refactored

* more typo fixes

* all working except 'Remove' revist logic and delete correct row

* removing fulltext index prop

* adding defualt conditions to the columns checkboxes

* service fix

* using path.join instead of hardcoded separators

* updating files is updating filegroups tabs, removing fg to file update required

* fixed toggle remove button for tab;es

* filegroup refactor

* update filegroups and files on new fg name

* final commit changes

* code review updates

* vBump STS to 4.9.0.26
2023-08-30 19:21:46 -05:00
Cory Rivera
e4abe4d167 Add Attach Database dialog (#24225) 2023-08-30 13:38:25 -07:00
Barbara Valdez
362290f8ec Add security tab for server properties (#24209)
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-08-29 13:28:17 -07:00
Sai Avishkar Sreerama
c4b1765745 Enabling Files tab to the database properties (#24138)
* initial changes for loadin dsc table with real values from smo

* Displaying diff columns for DSC for diff sql server

* checkbox maiants the selection

* elevate option fails to load correct value when set to when_supported option

* all working till maxdop, todo pause option, save

* commented MAXDOP changes, as it is causing issues

* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests

* Undo MAXDOP commented code

* refactored with service data

* column header width adjustments

* Maxdop and pause resume options completed, apply button is failing now

* Removed option names from loc  and using Id instead as names may change in future like in doc

* Apply button fixed

* refactored to reduce table reload

* Ledger digest completed

* refactor done: maxdop secondary shows wrong data from pause_resume

* refactor more: all working but table focus disturbs on update table

* adds conditions for unsupported dsc to <2016 server

* maxdop secondary checkbox fix

* rows still loses focus after value change due to update table row data

* Fixed updating secondary dropdown value

* reusing the private method and removed the duplicated codes

* initial commit - fullText and owner need revision

* Enter key in input type allows the change to update the table data, reduces the live update issues

* Setting focus to the current row

* loading data, need stylings-increase col length, etc

* using the existed setTableData method

* Adding new file dialog

* creating addFile, but not displaying in table, issue with appendData

* Adding row to the table, options are getting from STS

* all working except InPercent value

* code review comment updates

* Input type checkbox update table additional validation

* all except path

* fixing the input type focus and reverting the enterKeyPress logic

* browse path is created, need stylings,refactor,filestream selection and add

* fixing the flickering issue with data refresh

* new file options toggle and grid display string updates

* moving code inline and using actual component

* cleanup

* Add file saving is done, except one styling issue with autogrowth section

* add,remove working, need to edit file

* add, edit, remove - all working, need css fixes and -1 fix

* addressing code review comments

* adding local changes adn fixing for edit file

* adjusting css

* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo

* all fixed, need testing and refactor

* vBump STS  and fixing required field causing the apply button not enable for other options on main branch

* fixing autogrowth radio buttons change updates

* all working except some css

* disabled size for filestream

* fixing filegroups and filetypes scnearios, added filename validation for newfile, todo:editingNew file

* added max and min values to the inputs

* editing filename validation completed, all done exccept CSS

* all fixed except scroll bar

* edit db file header, filename enable issue fix

* PR comment supporting updates for STS

* min updates

* modfying addButtonsForTable method and reusing it for edit button

* code review comment updates

* Dialogbase addbuttons to table refactored

* more typo fixes

* removing fulltext index prop

* service fix

* using path.join instead of hardcoded separators

* final commit changes
2023-08-29 14:42:09 -05:00
Barbara Valdez
60bff01240 Add processors tab (#23634)
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-08-21 10:52:55 -07:00
Cory Rivera
0e7942913b Replace usage of Delete with Drop in object management code (#24159)
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-08-17 14:26:03 -07:00
Sai Avishkar Sreerama
e5b7bff7b4 Enabling Database scoped configurations tab to DB Properties (#23890)
* initial changes for loadin dsc table with real values from smo

* Displaying diff columns for DSC for diff sql server

* checkbox maiants the selection

* elevate option fails to load correct value when set to when_supported option

* all working till maxdop, todo pause option, save

* commented MAXDOP changes, as it is causing issues

* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests

* Undo MAXDOP commented code

* refactored with service data

* column header width adjustments

* Maxdop and pause resume options completed, apply button is failing now

* Removed option names from loc  and using Id instead as names may change in future like in doc

* Apply button fixed

* refactored to reduce table reload

* Ledger digest completed

* refactor done: maxdop secondary shows wrong data from pause_resume

* refactor more: all working but table focus disturbs on update table

* adds conditions for unsupported dsc to <2016 server

* maxdop secondary checkbox fix

* rows still loses focus after value change due to update table row data

* Fixed updating secondary dropdown value

* reusing the private method and removed the duplicated codes

* Enter key in input type allows the change to update the table data, reduces the live update issues

* Setting focus to the current row

* using the existed setTableData method

* code review comment updates

* Input type checkbox update table additional validation

* fixing the input type focus and reverting the enterKeyPress logic

* fixing the flickering issue with data refresh

* moving code inline and using actual component

* cleanup

* addressing code review comments

* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo

* vBump STS  and fixing required field causing the apply button not enable for other options on main branch
2023-08-16 12:00:18 -05:00
Cory Rivera
22e2b0df9f Add Delete Database dialog to enable additional deletion options (#24109) 2023-08-14 11:20:08 -07:00
Cory Rivera
cc778ad69f Use faster, editable dropdown for Collations in database dialogs (#23974)
* Also fixed an issue where a manually edited text field doesn't get updated when selecting the same dropdown value from before the manual edit.
---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-26 10:04:29 -07:00
Cory Rivera
fed4f2a18e Change OK button label based on whether the dialog is creating a new object or updating an existing one. (#23908) 2023-07-17 15:54:30 -07:00
Barbara Valdez
017fcf14b0 Fix issues found in the bug bash (#23741)
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-11 10:15:41 -07:00
Barbara Valdez
a52f86bc48 Add memory inputs validation (#23685)
* memory validation

* Update extensions/mssql/src/objectManagement/localizedConstants.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update extensions/mssql/src/objectManagement/localizedConstants.ts

Co-authored-by: Cory Rivera <corivera@microsoft.com>

* rename property to match sts

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-07-07 12:36:55 -07:00
Cory Rivera
f4688f447c Add New Object context menu entries on the objects themselves in OE (#23676) 2023-07-07 10:45:39 -07:00
Sai Avishkar Sreerama
acfa93fbb8 Enabling options tab for database properties (#23448)
* Initial commit for adding a basic general tab for the database properties

* Refactoring for dialog inputs

* removed properties nodeType and using database node and additional cleanup, diabling the functionality.

* Changes according to STS data fetch

* Reuse database Dialog

* Undo contract file change

* more refactoring

* fetched scrollbar fix into this PR

* Tabbed panel is being used for horizontal tabs

* stying fix for general tab button

* final commit for today :)

* Updates according to STS changes

* missed updates

* Refactored updates

* moved options as discussed and added collapsible sections... need to fix scroll bar

* Fixing the horizontal scroll bar of tabbedpanel

* initial updates

* need to fix the error!

* rror fixed and options are loading with sample values

* need to load real values for all felds and map values to dropdown options

* Dd loading correctly, need to add validation to recovery field and save options back

* refactor

* removing nullable property

* All changes done except recoveryTime validation

* Refactoring

* all values are saving as expected, isDirty flag is fixed. Todo: recovery validation and tests

* added general section for the options tab

* modifying pageVerify and userAccess to string array

* updates to general section of options tb

* disabling couple of general properties for MI

* Adding server edition conditions and toggling the UI options

* adding numeric validation to the recovey time

* Removing serveInfo logic and using the unsupported options approach from STS

* addressing comments and little code refactor

* changes with nullOrUndefined helper method

* replacing dropdowns with checkboxes

* adding unit test for helper method

* removed commented sample code and added comments
2023-07-06 18:22:20 -05:00
Barbara Valdez
32356cabc5 Server properties fixes (#23667)
* server properties fixes
2023-07-06 12:58:01 -07:00
Cory Rivera
e5aa752740 Add Detach Database option to database context menu (#23480) 2023-06-27 12:32:09 -07:00
Barbara Valdez
378585d43e Add server properties dialog (#23270)
Add General tab for server properties
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-06-22 13:38:51 -07:00
Sai Avishkar Sreerama
c8ed14f4a3 Adding database properties general tab with read-only fields (#23318)
* Initial commit for adding a basic general tab for the database properties

* Refactoring for dialog inputs

* removed properties nodeType and using database node and additional cleanup, diabling the functionality.

* Changes according to STS data fetch

* Reuse database Dialog

* Undo contract file change

* more refactoring

* fetched scrollbar fix into this PR

* Tabbed panel is being used for horizontal tabs

* stying fix for general tab button

* final commit for today :)

* Updates according to STS changes

* missed updates

* Refactored updates

* moved options as discussed and added collapsible sections... need to fix scroll bar

* Fixing the horizontal scroll bar of tabbedpanel
2023-06-22 10:30:14 -05:00
Cory Rivera
b135a06f8a Add link to Azure pricing calculator in New Database dialog (#23389) 2023-06-14 16:23:01 -07:00
Cory Rivera
398a91456d Add Configure SLO section to Create Database dialog for Azure servers (#23359) 2023-06-13 13:43:55 -07:00
Hai Cao
437f216cda Auto-refresh OE with table designer (#23370) 2023-06-12 09:16:41 -07:00
Alan Ren
7886b28565 move object management interfaces (#23358) 2023-06-08 12:46:44 -07:00
Alan Ren
f4d5ab616c add objects dialog (#23243) 2023-05-30 09:53:44 -07:00
Alan Ren
1a1839ab09 fix find object dialog type display name issue (#23232) 2023-05-26 07:59:34 -07:00
Alan Ren
b56f2ccb60 add securable settings (#22936)
* wip

* Update typings

* nullable

* update test service

* support securables

* updata test data

* fix issues

* fix build failure

* update test mocks

* fix typo

* fix reference

* fix findobjectdialog issue

* update SearchResultItem type

* fix table component perf issue

* hide effective permission for server role

* hide effective permission for app role and db role

* vbump sts and fix a couple issues

* STS update and UI update

* fix user login display issue

* vbump sts
2023-05-15 15:01:57 -07:00
Cory Rivera
27e0d67dec Add context menu entries for deleting a database (#22948) 2023-05-05 12:12:35 -07:00
Charles Gagnon
c3bf85f026 Create separate ScriptableDialogBase (#22974)
* Create separate ScriptableDialogBase

* more
2023-05-05 09:17:51 -07:00
Alan Ren
6a7899281a remove auth type from user (#22905)
* remove auth type from user

* vbump sts
2023-05-01 13:29:55 -07:00
Alan Ren
4f53d76eb5 User Management - Support new object types: Server Role, Application Role and Database Role (#22889)
* server role dialogs

* dialogs for other types

* refactor

* find object dialog

* script button

* refactoring

* fix issues

* fix title

* vbump sts

* remove language from links
2023-04-28 12:05:20 -07:00
Alan Ren
decbe8dded simplify object management feature APIs (#22781) 2023-04-19 19:26:29 -07:00
Alan Ren
9456285c65 support scripting in object management dialogs (#22429)
* user management - scripting

* remove confirmation

* update sts

* update string
2023-04-14 13:52:06 -07:00
Alan Ren
20cf2489a2 support rename for login, user and a few other types (#22331)
* rename object

* add comment

* use URN property

* vbump STS

* revert loc string change

* fix name check

* pr comments
2023-03-16 15:00:07 -07:00
Alan Ren
6ace579986 user management fixes (#22282)
* fix a few user management bugs

* revert user dialog change
2023-03-09 14:11:04 -08:00
Alan Ren
ec515a3b23 allow nothing is selected as initial state (#22260) 2023-03-09 08:44:35 -08:00
Alan Ren
b5ce7af090 Add support for Login and User management (#21981)
* initial commit

* leave only march release objects

* clean up

* login dialog

* localize and use background operation

* code cleanup

* remove tab

* support server role in login

* remove canEditName

* add user support

* comments and bug fixes

* remove hasDBAccess for now

* refactoring

* fix error

* user dialog UI

* telemetry, error handling and refactoring

* Fix references to dialogInfo (#21914)

* update telemetry

* Bump STS and use actual object management service

* add preview and handle no-change scenario

* fix merge issue

---------

Co-authored-by: Karl Burtram <karlb@microsoft.com>
2023-02-17 18:02:31 -08:00