Commit Graph

303 Commits

Author SHA1 Message Date
Maddy
ae830d9e64 Pinning Notebooks on Notebooks view (#11963)
* initial commit

* added tests

* code cleanup and more tests

* add missed util test

* changes to address comments

* remove pin from resources
2020-08-31 08:53:11 -07:00
Vasu Bhog
d59063ebab Add tests to NotebookUriHandler (#11959)
* NotebookUriHandler Test

* set test to previous, return promise for handleUri

* Added tests for file uri scheme https/http

* Updated NotebookUri to await handleUri calls and add more tests
2020-08-28 10:51:12 -05:00
Lucy Zhang
a3121c0b2d Add tests for Jupyter Session (#11961)
* add tests for config kernel and connection

* move sinon.restore and fix config filepath
2020-08-25 18:59:53 -07:00
Chris LaFreniere
82132583af Re-enable previously commented out configure python wizard tests (#11945)
* Re-enable configure python wizard tests

* Remove extra comment
2020-08-25 11:26:37 -07:00
Maddy
384553c231 bookTreeView tests (#11746)
* bookTreeView tests

* add types

* CI failure change test

* test mix up corrected

* check notebook path exists

* missing file error fix

* error msg update

* openNotebook test error alternative fix

* move openNotebook test to unstable

* skip instead of marking unstable
2020-08-24 14:41:12 -07:00
Amir Omidi
ca2b893c2c Update test cover dependency (#11889) 2020-08-20 12:25:12 -07:00
Vasu Bhog
29fbc7d952 Refactored Server Instance Tests (#11868)
* Refactored and improved testing through sinon

* Addressed changes - helper function and direct call to function refactor
2020-08-19 17:28:15 -05:00
Cory Rivera
0f063d3a2e Skip adding python user package directory to PATH on SAW devices. (#11849) 2020-08-18 17:14:19 -07:00
Cory Rivera
92db8df000 Simplify python reinstallation by only installing jupyter. (#11820) 2020-08-17 11:02:18 -07:00
Chris LaFreniere
a34a72795b Notebook Code Cleanup + Utils Test (#11754)
* Cleanup + Utils Test

* Removing unnecessary util method
2020-08-14 14:08:56 -07:00
Cory Rivera
ff2d2d0339 Remove preview flag for Configure Python wizard. (#11813) 2020-08-14 12:36:40 -07:00
Cory Rivera
d68433ec22 Add some package management unit tests for JupyterServerInstallation (#11777) 2020-08-13 13:12:28 -07:00
Cory Rivera
d380328f8b Use a regex to detect notebook started message. (#11642) 2020-08-04 18:00:52 -07:00
Barbara Valdez
e7ec278ef2 Replace URL and use vscode.URI on local paths (#11624)
* Use vscode.URI for local paths

* Use vscode.uri file method to set the name for remotebookfull path compressed file

* Add await on extract tar function

* Replace remote paths too

* Use vscode.uri.file instead of parse for local paths
2020-08-04 13:22:28 -07:00
Maddy
eeb1f7cf3e remove old code (#11620) 2020-08-03 17:08:00 -07:00
Barbara Valdez
c52155b621 Add setting for collapsing/expanding books at root level (#11543)
* Add setting for max number of expanded books

* Remove extra commas

* Add setting for expanding/collapsing books at root level

* Change typo in name of setting

* Change default value to false
2020-07-31 14:44:45 -07:00
Charles Gagnon
ee540ac89c Fix Notebook toolbar contributed actions (#11572)
* Fix Notebook toolbar contributed actions

* Fix args

* Remove unused imports
2020-07-30 14:11:15 -07:00
Barbara Valdez
6d9efbd603 Open books from Github (#10670)
* Add open book option in UI

* Add dropdowns option on dialog

* Add flow logic

* Fetch releases and validate URL

* Add class for github books and shared file books

* Change code structure

* Unblock local copy + stack overflows

* Download books from github

* Remove unused files

* Clean code and use the openNotebookFolder command to open remote book

* Checkpoint

* Refactor remote book dialog model to only hold data

* Remove ApiWrapper and refactor createlocalcopy method

* Use sinon js framework instead of typemoq for testing remotebookController

* Remove api wrapper

* Add some tests

* Add more tests and address pr comments

* Address PR comments

* Fix remotebook broken tests

* Add download location in output channel and use openBook command

* Address PR comments

* Fix typos, print error message and remove failing test

* Print error message

* Separate tests in different files

* Declare controller variable inside extension.tst

Co-authored-by: chlafreniere <hichise@gmail.com>
2020-07-24 19:39:03 -07:00
Maddy
21cf89fb7e Fix/open book error (#11379)
* add isNotebook param and showPreview option

* showPreview changes

* update OpenNotebookFolder to open a specific path

* added test for showPreviewFile

* test name typo

* remove isNotebook from openBook
2020-07-22 22:23:37 -07:00
Leila Lali
4a88adffd2 Adding button plugin to table component (#10918)
* Added delete plugin to table component
2020-07-22 16:26:16 -07:00
Chris LaFreniere
0c3c714be1 Stop hardcoding python3 (#11464) 2020-07-21 16:38:04 -07:00
Cory Rivera
7461cf844d Add some unit tests for PyPiClient. (#11442) 2020-07-21 10:56:25 -07:00
Maddy
f780db907d fix (#11437) 2020-07-21 10:10:35 -07:00
Charles Gagnon
8828758b2f Remove CMS ApiWrapper (#11439) 2020-07-20 15:24:36 -07:00
Cory Rivera
047c51921b Exclude Spark notebook kernels when running on SAW devices. (#11416) 2020-07-20 12:36:40 -07:00
cssuh
0833de1e7c Merge branch 'ads-main-vscode-2020-07-15T23-51-12' into main 2020-07-17 15:00:28 -04:00
dependabot[bot]
27983d4c66 Bump lodash from 4.17.15 to 4.17.19 in /extensions/notebook (#11394)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-07-17 08:46:10 -07:00
chlafreniere
b96ea07d8f Test fix try finding text documents multiple times 2020-07-16 18:48:07 -07:00
Maddy
9b1eb53665 Test/highlight correct nb (#11348)
* unit test of the method

* stash changes

* revealActiveDocumentInViewlet test

* separate tests

* test on activate

* added tests

* feedback changes

* naming change
2020-07-16 10:55:46 -07:00
Chris LaFreniere
171f091c88 Fix no books currently selected error in viewlet (#11269)
* Fix no books currently selected error

* check sections undefined vs length
2020-07-09 23:14:46 -07:00
Maddy
9c0f415bd9 Feat/search in books (#11117)
* clean up unsavedBooks to providedBooks

* added notebooks viewley contribution

* added notebookExporerAction context

* temp shortcut key B

* remove commenred code

* changes with master merge

* fix comments

* initial tests

* fix casing and description

* merged master and resolved errors

* initial commit

* search view changes

* remove extension point & add custom view container

* merge latest from master

* remove unused files

* move book images to common

* remove notebookExplorer contrib & move to notebook

* build fix

* remove explorer specific sryles from common

* vscode convention to define container actions

* rename notebooks/title

* show collapsible search view separately

* style changes

* rename method

* code cleanup

* enable search on type

* merged master and resolved compile errors

* highlight fix

* code cleanup

* rename interface

* fix hygiene floating promises errors

* more hygiene errors

* avoid circular dependency

* new ids for notebookSearch actions

* reuse SearchSortOrder from search

* merged main and resolved compile errors

* reuse search code

* vscode merge regression on highlight

* extend searchView

* missed resoved files

* null to undefined

* make treeView readonly

* revert carbon edit

* address PR comments

* convert async
2020-07-09 13:13:36 -07:00
Charles Gagnon
2a7483c036 Fix error when calling getParent (#11252) 2020-07-08 14:23:52 -07:00
Charles Gagnon
b3a01fcf77 Remove ApiWrapper from notebook extension (#11224)
* Remove ApiWrapper in notebook extension

* delete file

* Remove copyrights
2020-07-08 11:06:32 -07:00
Chris LaFreniere
5f8180ebbf Add Notebook Completion Item Provider Unit Tests (#11222)
* completion item provider tests

* Add nb completionItemProvider tests
2020-07-07 12:48:22 -07:00
Cory Rivera
f409abfc01 Disable python downloads when running notebooks on a SAW. (#11186) 2020-07-07 11:32:05 -07:00
Maddy
d51bba8fe9 check for jupyter-book versions and install 6.4 (#11167)
* check for jupyter-book versions and install 6.4

* added a note before installation
2020-07-01 15:27:45 -07:00
Chris LaFreniere
a8a7559229 Add more notebook extension tests (#11143)
* more tests

* More tests

* More tests

* Add prompt tests
2020-06-30 11:01:51 -07:00
Maddy
561b881200 Fix/highlight correct item (#11016)
* get children of unexpanded books

* highlight item inside collapsed parent in treeView

* fix path issue on windows

* refactor common code into separate func

* refactor
2020-06-24 13:44:50 -07:00
Chris LaFreniere
7080e3ec4e Notebooks: Add Some Jupyter Controller Tests (#11053)
* First jupyter controller tests

* PR comments

* remove unnecessary checks for throw

* fix comment typo
2020-06-23 23:08:25 -07:00
ADS Merger
5e7071e466 Merge from vscode 4d91d96e5e121b38d33508cdef17868bab255eae 2020-06-19 10:59:23 -07:00
Chris LaFreniere
eaf753f79e Remove unused prompt code (#10996) 2020-06-18 17:23:32 -07:00
Chris LaFreniere
77ba5a36aa Add Jupyter Notebook Manager Tests (#10955)
* jupyter notebook manager tests

* cover config duplicate integrationTest
2020-06-17 14:42:35 -07:00
Charles Gagnon
94bc0d9559 Fix open notebook bug (#10930)
* Fix open notebook bug

* cleanup

* clean up spaces
2020-06-16 13:06:44 -07:00
Karl Burtram
434d017a6b Update various branch references to main branch (#10913) 2020-06-13 14:26:18 -07:00
Maddy
26a00696d4 Fix/prev next links issue (#10523)
* intital test code

* added tests

* remove commented code

* fix for failing tests

* reuse exported enum

* changes to address comments

* add back onVisibility highlight

* port highlight fix from Chris

* fix tests
2020-06-12 18:42:17 -07:00
Chris LaFreniere
960aa14027 stop running magics that dont exist (#10894) 2020-06-12 14:25:01 -07:00
Chris LaFreniere
168ef80d8f Fix Notebook Viewlet Highlighting (#10868)
* Stop double tree data provider registrations

* revert book finding logic, leverage currentBook
2020-06-10 22:27:16 -07:00
Charles Gagnon
dff43687e2 Clean up coverage and fix issue with notebook names (#10826)
* Clean up coverage and fix issue with notebook names

* update name
2020-06-10 13:44:38 -07:00
Maddy
22d7c9083e highlight correct notebook on navigation. (#10807)
* highlight correct notebook on navigation.

* add back behavior of highight on viewlet visible

* optimize bookViewer create

* createTreeView for every book
2020-06-08 19:09:43 -07:00
Cory Rivera
5d60254bb9 Add custom width to Python wizard to reduce wasted space. (#10705)
* Also use double quotes for localize calls in the wizard.
2020-06-03 14:41:39 -07:00